Author Topic: NV 430: abbrev, no city  (Read 2095 times)

0 Members and 1 Guest are viewing this topic.

Offline yakra

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 4234
  • Last Login:April 07, 2024, 11:18:57 pm
  • I like C++
NV 430: abbrev, no city
« on: March 09, 2020, 08:03:41 pm »
Queried the DB for routes with an abbrev & no city, and came across NV430Nor.
A bit of a weird one, as there's no vanilla NV430 without an abbrev. Maybe there originally was, back during development in the CHM days?
Suggest changing to vanilla NV430, and adding NV430Nor as an AltRouteName.
Sri Syadasti Syadavaktavya Syadasti Syannasti Syadasti Cavaktavyasca Syadasti Syannasti Syadavatavyasca Syadasti Syannasti Syadavaktavyasca

Offline oscar

  • TM Collaborator
  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 1528
  • Last Login:Today at 04:34:42 am
    • Hot Springs and Highways pages
Re: NV 430: abbrev, no city
« Reply #1 on: March 10, 2020, 03:08:06 am »
In my queue.

EDIT: Fix is in the HB.
« Last Edit: March 20, 2020, 11:01:51 pm by oscar »

Offline yakra

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 4234
  • Last Login:April 07, 2024, 11:18:57 pm
  • I like C++
Re: NV 430: abbrev, no city
« Reply #2 on: May 01, 2020, 03:06:18 am »
Oops, I failed to notice:
Duplicate main list name in nv.nv430: 'NV NV430' already points to nv.us395altwas
No harm now, though, as NV NV430 isn't in use in any .list files, and usanv is processed after usaus thus the .list name points to the correct route.
However, this will matter in the near future, so we should remove the AltRouteName from usausb.csv.
Sri Syadasti Syadavaktavya Syadasti Syannasti Syadasti Cavaktavyasca Syadasti Syannasti Syadavatavyasca Syadasti Syannasti Syadavaktavyasca

Offline oscar

  • TM Collaborator
  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 1528
  • Last Login:Today at 04:34:42 am
    • Hot Springs and Highways pages
Re: NV 430: abbrev, no city
« Reply #3 on: May 01, 2020, 08:44:20 am »
Oops, I failed to notice:
Duplicate main list name in nv.nv430: 'NV NV430' already points to nv.us395altwas
No harm now, though, as NV NV430 isn't in use in any .list files, and usanv is processed after usaus thus the .list name points to the correct route.
However, this will matter in the near future, so we should remove the AltRouteName from usausb.csv.

Fix is made in my local copy, in my queue for tonight's canqc pull request. usausb_con.csv requires no change.

.csv changes often get me in trouble. However, I have the datacheck.sh process memorized by now, and have been using it on every canqc review pull request, so if there's a glitch it'll get caught before getting merged into the master.

Offline yakra

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 4234
  • Last Login:April 07, 2024, 11:18:57 pm
  • I like C++
Re: NV 430: abbrev, no city
« Reply #4 on: May 01, 2020, 11:50:59 am »
Duplicate AltRouteNames still aren't caught by datacheck.sh, so this one flew right over both our heads. Fix pending.
« Last Edit: May 01, 2020, 02:17:35 pm by yakra »
Sri Syadasti Syadavaktavya Syadasti Syannasti Syadasti Cavaktavyasca Syadasti Syannasti Syadavatavyasca Syadasti Syannasti Syadavaktavyasca