Author Topic: islth (Iceland Þjóðvegur)  (Read 1713 times)

0 Members and 1 Guest are viewing this topic.

Offline Duke87

  • TM Collaborator
  • Full Member
  • *****
  • Posts: 124
  • Last Login:July 12, 2018, 08:27:14 pm
islth (Iceland Þjóðvegur)
« on: February 13, 2017, 10:13:21 pm »
This system is now ready for peer review. Have at it, folks!

Depending on how soon you read this the last batch may be missing from the HB - I only just submitted the Git pull so it's waiting for the next update as of right now.

I have also uploaded a readme file which will be here once the pull is merged. This file documents my assumptions and sources.

Offline si404

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 679
  • Last Login:Today at 04:33:25 pm
Re: islth (Iceland Þjóðvegur)
« Reply #1 on: May 17, 2017, 12:15:56 pm »
TH25: fine
TH26: fine
TH30: fine
TH31: fine
TH32: fine
TH33: fine
TH34: fine
TH35: fine
TH36: fine
TH37: fine
TH38: fine
TH39: fine
TH40: fine
TH41: KflFlu -> KefFlu, AegisGat -> AegGat
TH42: fine
TH43: fine
TH44: FerRod -> FerRoth (ð is not d)
TH45: fine
TH46: really? obviously it is TH46 and signed as such, but boy is that short
TH47: fine
TH48: fine
TH49: add point for Kringlan as grade-separated junction

Offline michih

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 1004
  • Gender: Male
  • Last Login:Today at 03:25:59 am
Re: islth (Iceland Þjóðvegur)
« Reply #2 on: May 17, 2017, 02:41:09 pm »
TH46: really? obviously it is TH46 and signed as such, but boy is that short

0.10mi. Why not?

Is there any rule or do we wanna introduce a minimum limit?

Offline si404

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 679
  • Last Login:Today at 04:33:25 pm
Re: islth (Iceland Þjóðvegur)
« Reply #3 on: May 17, 2017, 03:14:43 pm »
TH46: really? obviously it is TH46 and signed as such, but boy is that short

0.10mi. Why not?

Is there any rule or do we wanna introduce a minimum limit?
No it's fine about inclusion. The comment was about the tiny route having such a decent number (I guess the Isle of Man's unsigned A8 really takes the biscuit).

Offline si404

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 679
  • Last Login:Today at 04:33:25 pm
Re: islth (Iceland Þjóðvegur)
« Reply #4 on: May 18, 2017, 09:47:19 am »
TH1: add extra shaping points near TH51_S; ThverDal -> ThvDal; ThelVeg -> TheVeg; OldS1Thin -> OldTH1_Thi? Thi?; point for TH936; OldS1_N -> OldTH1_N; OldS1_S ->OldTH1_S; OldS1Mar -> OldTH1_Mar

Offline Duke87

  • TM Collaborator
  • Full Member
  • *****
  • Posts: 124
  • Last Login:July 12, 2018, 08:27:14 pm
Re: islth (Iceland Þjóðvegur)
« Reply #5 on: May 19, 2017, 09:04:46 pm »
Thanks for your input!

Couple general notes regarding characters:

- I consistently and deliberately substituted d for ð, on account of this being seemingly standard practice among sources within Iceland. See for example the official website of Vegagerðin, Iceland's DOT: http://www.vegagerdin.is/
- I've transcribed æ as ae but continued to treat it as one letter for the purpose of determining when to trim names. So, Ægisgata, per the standard rule of "keep all characters in the street name if there are four or fewer, trim to three if five or more" becomes ÆgisGat ("Ægis" is four characters), which is then transcribed into AegisGat
- Likewise for transcribing Þ into th.


Offline yakra

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 1344
  • Last Login:Today at 12:28:50 pm
Re: islth (Iceland Þjóðvegur)
« Reply #6 on: May 20, 2017, 02:11:52 am »
Hm. I'd think that should go the other way round -- Transcribe before truncate, not vice versa.

Offline michih

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 1004
  • Gender: Male
  • Last Login:Today at 03:25:59 am
Re: islth (Iceland Þjóðvegur)
« Reply #7 on: May 27, 2017, 05:37:09 am »
There are some datacheck errors: http://tm.teresco.org/devel/datacheck.php#preview.

Many VISIBLE_DISTANCE and SHARP_ANGLE errors which must be fixed or marked FP before activation but there are also some more "critical" errors like:

Code: [Select]
isl.th001;x062;;;DUPLICATE_LABEL;
isl.th054;+X39;+X40;Byli;BAD_ANGLE;
isl.th054;+X40;Byli;Hva;BAD_ANGLE;
isl.th061;+X082;+X083;;DUPLICATE_COORDS;(65.563147,-21.804943)
isl.th061;+X081;+X082;+X083;BAD_ANGLE;
isl.th061;+X082;+X083;+X084;BAD_ANGLE;
isl.th211;TH211;;;LABEL_SELFREF;
isl.th248;TH248;;;LABEL_SELFREF;
isl.th325;x02;;;DUPLICATE_LABEL;
isl.th643;BasSta;TH645_W;;DUPLICATE_COORDS;(65.76426,-21.683664)
isl.th643;GeiVeg;BasSta;TH645_W;BAD_ANGLE;
isl.th643;BasSta;TH645_W;+X02;BAD_ANGLE;
...

TH54 errors: There's a visible and hidden wp at the same location.
TH61 errors: 2 hidden wps at the same location.

Most of the errors are already detected by the wp editor.

Offline si404

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 679
  • Last Login:Today at 04:33:25 pm
Re: islth (Iceland Þjóðvegur)
« Reply #8 on: May 27, 2017, 07:02:20 am »
- I consistently and deliberately substituted d for ð, on account of this being seemingly standard practice among sources within Iceland. See for example the official website of Vegagerðin, Iceland's DOT: http://www.vegagerdin.is/
Yep, you're right. I anglicised the transliteration. Swedish turned ð into d and Welsh (OK, a Celtic language rather than North Germanic) uses dd for a similar sound - eg Caerdydd is written in English as Cardiff.
Quote
- I've transcribed æ as ae but continued to treat it as one letter for the purpose of determining when to trim names. So, Ægisgata, per the standard rule of "keep all characters in the street name if there are four or fewer, trim to three if five or more" becomes ÆgisGat ("Ægis" is four characters), which is then transcribed into AegisGat
- Likewise for transcribing Þ into th.
As yakra says, transcribe before truncate.

I did have more comments, but they got eaten by my computer crashing. What I can remember, beyond the truncate-before-transcribing issue that made labels too long was 'Gat' -> 'Gata' changes (with Ægisgata, I got bogged down in the Ægis and ignored the four-letter 'Gata' shouldn't be truncated to 'Gat').

Offline michih

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 1004
  • Gender: Male
  • Last Login:Today at 03:25:59 am
Re: islth (Iceland Þjóðvegur)
« Reply #9 on: May 30, 2017, 04:15:26 pm »
There's a little mistake in islth.csv file:

ERROR: Duplicate list name: ISL TH807

https://github.com/TravelMapping/DataProcessing/issues/45#issuecomment-304973676

Offline Duke87

  • TM Collaborator
  • Full Member
  • *****
  • Posts: 124
  • Last Login:July 12, 2018, 08:27:14 pm
Re: islth (Iceland Þjóðvegur)
« Reply #10 on: June 07, 2017, 12:04:14 am »
What I can remember, beyond the truncate-before-transcribing issue that made labels too long was 'Gat' -> 'Gata' changes (with Ægisgata, I got bogged down in the Ægis and ignored the four-letter 'Gata' shouldn't be truncated to 'Gat').

What I can confirm from my travels around Iceland is that there are, seemingly, no official abbreviations. The entire name is always spelled out on street signs (e.g. "Ægisgata"). So, I used the first three letters as abbreviations for all Icelandic street name suffixes.

While one could certainly opine in favor of doing something different, this is a purely stylistic matter and one for which a decision on how to handle Iceland needn't impact any other country. I would therefore not think it worthwhile to go through every file and replace every instance of "Gat" with "Gata", "Myr" with "Myri", etc. unless for some reason it's really really necessary.


Also, thanks for the datacheck link. I had heard legends of the mystical datacheck page but never seen it prior to today. I've already fixed (or should have fixed - let's see!) all of the red errors and flagged some of the black ones as false positives.

How fussy do we want to be about the visible distance errors? I know there's a guideline that points should not be more than 10 miles apart, but a lot of Iceland is rather sparse and oftentimes there simply are not any intersections or points of any particular interest for longer than that. As it is I'm pretty sure I've co-opted a few people's private driveways to make waypoints out of.

Offline si404

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 679
  • Last Login:Today at 04:33:25 pm
Re: islth (Iceland Þjóðvegur)
« Reply #11 on: June 07, 2017, 02:33:59 am »
Quote
How fussy do we want to be about the visible distance errors? I know there's a guideline that points should not be more than 10 miles apart, but a lot of Iceland is rather sparse and oftentimes there simply are not any intersections or points of any particular interest for longer than that. As it is I'm pretty sure I've co-opted a few people's private driveways to make waypoints out of.
These errors are normally not errors, but the check was added long ago in case a big chunk of route was missing in the middle.

Offline Jim

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 1147
  • Last Login:Today at 07:07:37 am
Re: islth (Iceland Þjóðvegur)
« Reply #12 on: June 07, 2017, 08:17:45 am »
Quote
How fussy do we want to be about the visible distance errors? I know there's a guideline that points should not be more than 10 miles apart, but a lot of Iceland is rather sparse and oftentimes there simply are not any intersections or points of any particular interest for longer than that. As it is I'm pretty sure I've co-opted a few people's private driveways to make waypoints out of.
These errors are normally not errors, but the check was added long ago in case a big chunk of route was missing in the middle.

In the cases where remote routes simply do not have any points worthy of a visible waypoint, these can be marked as FPs.  I'd suggest waiting until just before activation to take care of those, in case some points are adjusted during review.

Offline si404

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 679
  • Last Login:Today at 04:33:25 pm
Re: islth (Iceland Þjóðvegur)
« Reply #13 on: June 13, 2017, 06:32:50 am »
TH50 - fine
TH51 - fine
TH52 - fine
TH54 - fine
TH55 - fine
TH56 - fine
TH58 - fine
TH59 - fine
TH60 - OldTH60Abc_D -> OldTH60_AbcD ?
TH61 - off-route shaping points on other side of Fjord from GruSt
TH62 - fine
TH63 - fine
TH64 - fine
TH65 - fine
TH68 - fine
TH72 - fine
TH74 - fine
TH75 - fine
TH76 - fine
TH77 - fine
TH82 - fine
TH83 - fine
TH85 - OldTH85Abc_D -> OldTH85_AbcD ?
TH87 - fine
TH91 - fine
TH92 - EgiBra -> EgiBra_E (?) as concurrency diverge; OldTH92Abc_D -> OldTH92_AbcD ?
TH93 - fine
TH94 - fine
TH96 - fine
TH97 - fine
TH98 - fine
TH99 - check route in Hofn

Offline Duke87

  • TM Collaborator
  • Full Member
  • *****
  • Posts: 124
  • Last Login:July 12, 2018, 08:27:14 pm
Re: islth (Iceland Þjóðvegur)
« Reply #14 on: June 14, 2017, 11:35:07 pm »
TH99 - check route in Hofn

The route I've mapped is consistent with the path shown on Vegagerdin's official map, which I follow over OSM on account of it being a primary source. There is no signage in town along either routing.

Will fix the others in my next pull.