Author Topic: usapr: Puerto Rico Territorial Highways  (Read 2906 times)

0 Members and 1 Guest are viewing this topic.

Offline mapcat

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 715
  • Last Login:Yesterday at 10:45:56 pm
usapr: Puerto Rico Territorial Highways
« on: April 10, 2017, 12:48:18 pm »
I've made some progress on the usapr set and am up to PR400. It appears that there will be approximately 1200 routes in the set when it's finished. Should it be divided into usapr1, usapr2, etc, or should I put them all in one set? Despite having different shields, usapr routes ultimately belong in a single set. PR123, for example, can be found with (at least) three different shields, but all segments are part of the same continuous route, and simply refer to the relative importance of that segment.

Most of the routes >199 are very short (10km or less) and therefore would not require much time for peer review. But I can see how a set of around 1200 of any length might be a little more than someone would want to take on at once.
« Last Edit: June 24, 2017, 02:55:18 am by michih »
Clinched:

Offline mapcat

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 715
  • Last Login:Yesterday at 10:45:56 pm
Re: usapr
« Reply #1 on: May 05, 2017, 03:22:09 pm »
This set is in preview now and ready for peer review. A little over 1100 routes total.
Clinched:

Offline compdude787

  • TM Collaborator
  • Full Member
  • *****
  • Posts: 163
  • Last Login:November 17, 2018, 12:50:41 am
Re: usapr
« Reply #2 on: May 20, 2017, 01:52:52 am »
Okay, I am starting my peer review.

PR1: Not sure if the PR25_B waypoint is necessary as it seems to be really close to the one for PR35. These two could be combined. PR18/52 waypoint needs to be adjusted to be more centered on the interchange. Do likewise for the corresponding point in the I-PR1, PR52 and PR18 waypoint files. Need a shaping point about where PR1 crosses a bridge over PR 834. Two NMPs at the north end of Caguas need fixing: PR52(15) and PR30. Those waypoints both need to have their lat/lon coordinates changed to match the waypoints on PR52/I-PR1 and PR 30. According to Google Street View and OSM (very recently updated), it appears that just west of Salinas, the PR1 and PR 701 junction has been moved just SW of the existing location, so that waypoint needs repositioning.

That's all for tonight. PR 2 will have to wait till tomorrow because it's super long (looks longer than PR 1), but hopefully this whole process will go quicker as the routes get shorter.

Offline compdude787

  • TM Collaborator
  • Full Member
  • *****
  • Posts: 163
  • Last Login:November 17, 2018, 12:50:41 am
Re: usapr
« Reply #3 on: May 21, 2017, 12:24:04 am »
Okay, now I'm continuing my peer review.

PR 2: First off, in Ponce, the PR52 waypoint needs to be moved a smidge south (if you look at it in the HDX you'll understand why) as well as the corresponding points on PR 52 and I-PR2. Next, waypoint 213 needs to be moved east just a slight bit (same goes for the corresponding waypoints on I-PR2 and PR 385). A shaping point should be added near where PR 127 crosses over PR 2. At waypoint 181, there's an NMP with PR 102. Just south of the PR109/115 waypoint, there is a shaping point that should be moved southeast to where the road actually curves. In Aguadilla, I'd suggest adding a waypoint at Avenida Las Cascadas, since there is a waterpark and a stadium there, which seem like major destinations. Just east of there, there needs to be a waypoint at the intersection of the road that connects to PR 469 (again, don't forget to add both of these waypoints to the I-PR2 waypoint file). In Arecibo, the waypoints AveCollTos and PR129 need to be recentered.

PR2RPon: No issues found.

Okay, that's all for now...

Offline mapcat

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 715
  • Last Login:Yesterday at 10:45:56 pm
Re: usapr
« Reply #4 on: May 21, 2017, 11:33:50 am »
Thanks for the thorough review!

At waypoint 181, there's an NMP with PR 102. Just south of the PR109/115 waypoint, there is a shaping point that should be moved southeast to where the road actually curves.
That shaping point is actually a placeholder for where PR401 will eventually intersect. Note that in the file it's called +FutPR401. Once the intersection is built, there won't be a need for another shaping point in that segment.

The rest of the changes have been made in my files.
Clinched:

Offline compdude787

  • TM Collaborator
  • Full Member
  • *****
  • Posts: 163
  • Last Login:November 17, 2018, 12:50:41 am
Re: usapr
« Reply #5 on: May 23, 2017, 12:44:33 am »
I'll probably continue reviewing in the next few days, but I noticed that PR 30 was missing from the list of highways in the highway browser, because apparently it wasn't in the usapr.csv file or the usapr_con.csv file. I just did a pull request to add it, but you might want to check to see if there are any other errors of this sort.

Offline si404

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 724
  • Last Login:Today at 03:04:47 am
Re: usapr
« Reply #6 on: May 23, 2017, 04:57:30 am »
PR30 is in the Select Numbered State Freeways currently, as are PR53 and PR66. They need to be removed from there when they are added to usapr, which shouldn't really be until the system is activated.

Offline mapcat

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 715
  • Last Login:Yesterday at 10:45:56 pm
Re: usapr
« Reply #7 on: May 23, 2017, 08:47:19 am »
I'll probably continue reviewing in the next few days, but I noticed that PR 30 was missing from the list of highways in the highway browser, because apparently it wasn't in the usapr.csv file or the usapr_con.csv file. I just did a pull request to add it, but you might want to check to see if there are any other errors of this sort.
Since there's sometimes a reason for omissions, I'd appreciate it if you'd just point them out here and let me make the call on whether or not to add them. It doesn't usually take me too long. As Si said, 2 PR53's and PR66 are also in usansf and will stay there until activation.
Clinched:

Offline compdude787

  • TM Collaborator
  • Full Member
  • *****
  • Posts: 163
  • Last Login:November 17, 2018, 12:50:41 am
Re: usapr
« Reply #8 on: May 23, 2017, 10:05:19 am »
I'll probably continue reviewing in the next few days, but I noticed that PR 30 was missing from the list of highways in the highway browser, because apparently it wasn't in the usapr.csv file or the usapr_con.csv file. I just did a pull request to add it, but you might want to check to see if there are any other errors of this sort.
Since there's sometimes a reason for omissions, I'd appreciate it if you'd just point them out here and let me make the call on whether or not to add them. It doesn't usually take me too long. As Si said, 2 PR53's and PR66 are also in usansf and will stay there until activation.

Sorry, I forgot that it was in usansf. I just thought I was being helpful...

Offline compdude787

  • TM Collaborator
  • Full Member
  • *****
  • Posts: 163
  • Last Login:November 17, 2018, 12:50:41 am
Re: usapr
« Reply #9 on: June 03, 2017, 02:02:46 am »
Okay, I am now continuing my review.

PR2RMay: According to GSV, PR380 doesn't appear to be signed at its intersection with PR 2R, so it should be removed. The waypoint for CllMenVigo should be centered on the intersection because there is not a one-way couplet here, according to GSV.

PR2RAgu: No problems found.

PR3: CamBal should be changed to CllFer. Just south of Ceiba, there should be a point at PR 53 (the corresponding 6a waypoint on PR 53 doesn't appear to actually be closed per GSV). PR30(28A) should be PR30(28), and the waypoint for PR713 should be moved a few hundred feet west to the actual intersection.

Okay, that's all for now, time to go to bed. Sorry about the slow pace. Hopefully it will go faster as the routes get shorter!

Offline mapcat

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 715
  • Last Login:Yesterday at 10:45:56 pm
Re: usapr
« Reply #10 on: June 03, 2017, 10:14:09 pm »
Thanks for catching those. No worries about the delay. It seems that the rest of them should be easier.

Changes made and submitted, except for the PR30(28) point edit, since it looks like you might have meant that as a change for the PR30 file. In case it is, I'd rather wait to see if you have other suggestions for that file once you get to it.
Clinched:

Offline compdude787

  • TM Collaborator
  • Full Member
  • *****
  • Posts: 163
  • Last Login:November 17, 2018, 12:50:41 am
Re: usapr
« Reply #11 on: June 03, 2017, 10:56:59 pm »
Thanks for catching those. No worries about the delay. It seems that the rest of them should be easier.

Changes made and submitted, except for the PR30(28) point edit, since it looks like you might have meant that as a change for the PR30 file.

I was referring to the waypoint named PR30(28A) in the PR3 file. According to the official PR map you sent me, (and GSV) that exit is numbered just 28. The corresponding waypoint on PR30 is labeled as PR 3, which is weird because I thought we put in exit numbers on freeways where they exist.

Offline mapcat

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 715
  • Last Login:Yesterday at 10:45:56 pm
Re: usapr
« Reply #12 on: June 04, 2017, 07:42:46 am »
I was referring to the waypoint named PR30(28A) in the PR3 file. According to the official PR map you sent me, (and GSV) that exit is numbered just 28. The corresponding waypoint on PR30 is labeled as PR 3, which is weird because I thought we put in exit numbers on freeways where they exist.

Sorry, I'm not finding a point with that label in the PR3 file:

Code: [Select]
PR1_N http://www.openstreetmap.org/?lat=18.396821&lon=-66.054590
PR25 http://www.openstreetmap.org/?lat=18.396627&lon=-66.053195
CllCamSoto http://www.openstreetmap.org/?lat=18.395510&lon=-66.049902
PR27 http://www.openstreetmap.org/?lat=18.395225&lon=-66.042815
PR181_N http://www.openstreetmap.org/?lat=18.394950&lon=-66.031303
PR47 http://www.openstreetmap.org/?lat=18.396477&lon=-66.023868
PR849 http://www.openstreetmap.org/?lat=18.397204&lon=-66.005543
PR8 http://www.openstreetmap.org/?lat=18.398127&lon=-65.995490
PR887_W http://www.openstreetmap.org/?lat=18.398350&lon=-65.989943
PR190/8887 http://www.openstreetmap.org/?lat=18.394604&lon=-65.982015
PR26/66 http://www.openstreetmap.org/?lat=18.391679&lon=-65.978051
PR887_E http://www.openstreetmap.org/?lat=18.380246&lon=-65.962547
PR874_W http://www.openstreetmap.org/?lat=18.376209&lon=-65.954881
PR853 http://www.openstreetmap.org/?lat=18.375115&lon=-65.947473
PR857 http://www.openstreetmap.org/?lat=18.376071&lon=-65.934121
PR874_E http://www.openstreetmap.org/?lat=18.377527&lon=-65.921638
PR9959_W http://www.openstreetmap.org/?lat=18.376387&lon=-65.907079
PR185 http://www.openstreetmap.org/?lat=18.374890&lon=-65.899735
PR9959_E http://www.openstreetmap.org/?lat=18.378953&lon=-65.891179
PR188 http://www.openstreetmap.org/?lat=18.379268&lon=-65.885053
PR958 http://www.openstreetmap.org/?lat=18.377904&lon=-65.862828
PR959 http://www.openstreetmap.org/?lat=18.378281&lon=-65.856412
PR187R http://www.openstreetmap.org/?lat=18.377864&lon=-65.836735
PR66/187 http://www.openstreetmap.org/?lat=18.375964&lon=-65.827690
PR186 http://www.openstreetmap.org/?lat=18.375226&lon=-65.822997
PR955_A http://www.openstreetmap.org/?lat=18.374462&lon=-65.818094
PR967 http://www.openstreetmap.org/?lat=18.374275&lon=-65.813288
PR955_B http://www.openstreetmap.org/?lat=18.374819&lon=-65.810074
PR955_C http://www.openstreetmap.org/?lat=18.375079&lon=-65.808905
PR955_D http://www.openstreetmap.org/?lat=18.378357&lon=-65.793273
Cll9 http://www.openstreetmap.org/?lat=18.377008&lon=-65.788381
PR955_E http://www.openstreetmap.org/?lat=18.373613&lon=-65.784025
PR191 http://www.openstreetmap.org/?lat=18.371892&lon=-65.771520
PR968 http://www.openstreetmap.org/?lat=18.371974&lon=-65.767523
PR955_F http://www.openstreetmap.org/?lat=18.371888&lon=-65.765952
PR992_W http://www.openstreetmap.org/?lat=18.373022&lon=-65.761832
PR193_A http://www.openstreetmap.org/?lat=18.379513&lon=-65.747165
PR193_B http://www.openstreetmap.org/?lat=18.379165&lon=-65.743099
PR193_C http://www.openstreetmap.org/?lat=18.379251&lon=-65.739612
CamFer http://www.openstreetmap.org/?lat=18.381768&lon=-65.730220
PR193/992 http://www.openstreetmap.org/?lat=18.371728&lon=-65.716079
PR940_W http://www.openstreetmap.org/?lat=18.354932&lon=-65.698253
PR194/940 http://www.openstreetmap.org/?lat=18.345910&lon=-65.672842
PR985 http://www.openstreetmap.org/?lat=18.340840&lon=-65.668325
PR195 http://www.openstreetmap.org/?lat=18.326612&lon=-65.656926
PR53_N http://www.openstreetmap.org/?lat=18.314618&lon=-65.650531
PR194_S http://www.openstreetmap.org/?lat=18.314739&lon=-65.650145
PR53(2) http://www.openstreetmap.org/?lat=18.298225&lon=-65.646669
PR982 http://www.openstreetmap.org/?lat=18.284709&lon=-65.638670
PR979_N http://www.openstreetmap.org/?lat=18.271018&lon=-65.640988
CllIsaRos http://www.openstreetmap.org/?lat=18.270192&lon=-65.639878
+X890456 http://www.openstreetmap.org/?lat=18.258761&lon=-65.646401
PR979_S http://www.openstreetmap.org/?lat=18.259719&lon=-65.649169
ToPR53 http://www.openstreetmap.org/?lat=18.256553&lon=-65.651480
PR974 http://www.openstreetmap.org/?lat=18.236671&lon=-65.662902
PR53(10) http://www.openstreetmap.org/?lat=18.229759&lon=-65.670003
PR973 http://www.openstreetmap.org/?lat=18.216809&lon=-65.696161
PR31 http://www.openstreetmap.org/?lat=18.213704&lon=-65.703763
CllCam http://www.openstreetmap.org/?lat=18.189357&lon=-65.713601
PR192 http://www.openstreetmap.org/?lat=18.195320&lon=-65.722968
CllAdu http://www.openstreetmap.org/?lat=18.165271&lon=-65.744741
Cll5 http://www.openstreetmap.org/?lat=18.158104&lon=-65.758614
PR925_N http://www.openstreetmap.org/?lat=18.150794&lon=-65.780200
PR53(31) http://www.openstreetmap.org/?lat=18.143980&lon=-65.803696
PR925_S http://www.openstreetmap.org/?lat=18.143372&lon=-65.805855
PR923 http://www.openstreetmap.org/?lat=18.144781&lon=-65.810476
PR60 http://www.openstreetmap.org/?lat=18.146851&lon=-65.814693
PR198 http://www.openstreetmap.org/?lat=18.149466&lon=-65.825491
PR908_N http://www.openstreetmap.org/?lat=18.144002&lon=-65.826736
PR909 http://www.openstreetmap.org/?lat=18.139210&lon=-65.827337
PR30 http://www.openstreetmap.org/?lat=18.134989&lon=-65.825438
PR910 http://www.openstreetmap.org/?lat=18.116982&lon=-65.821812
PR906_N http://www.openstreetmap.org/?lat=18.111699&lon=-65.822176
PR906_S http://www.openstreetmap.org/?lat=18.090039&lon=-65.847400
PR908_S http://www.openstreetmap.org/?lat=18.086613&lon=-65.855253
PR905 http://www.openstreetmap.org/?lat=18.072742&lon=-65.873235
PR902 http://www.openstreetmap.org/?lat=18.065052&lon=-65.876840
PR9909/9910 http://www.openstreetmap.org/?lat=18.054627&lon=-65.875145
PR901 http://www.openstreetmap.org/?lat=18.044956&lon=-65.869308
PR182 http://www.openstreetmap.org/?lat=18.040692&lon=-65.877977
SecLaPan http://www.openstreetmap.org/?lat=18.035272&lon=-65.906175
PR939 http://www.openstreetmap.org/?lat=18.010451&lon=-65.896873
CllLMRivera_E http://www.openstreetmap.org/?lat=18.007422&lon=-65.899344
PR750 http://www.openstreetmap.org/?lat=18.008274&lon=-65.901452
PR760 http://www.openstreetmap.org/?lat=18.005678&lon=-65.903812
PR759 http://www.openstreetmap.org/?lat=18.004177&lon=-65.905004
+X450413 http://www.openstreetmap.org/?lat=17.981412&lon=-65.909413
PR7758 http://www.openstreetmap.org/?lat=17.974667&lon=-65.936342
+X637927 http://www.openstreetmap.org/?lat=17.971269&lon=-65.954055
PR758 http://www.openstreetmap.org/?lat=17.978044&lon=-65.972573
+X840267 http://www.openstreetmap.org/?lat=17.978716&lon=-66.003494
PR53Pat_E http://www.openstreetmap.org/?lat=17.982093&lon=-66.003376
PR757 http://www.openstreetmap.org/?lat=17.996318&lon=-66.009159
PR181_S http://www.openstreetmap.org/?lat=18.005042&lon=-66.013418
PR184 http://www.openstreetmap.org/?lat=17.998869&lon=-66.025445
PR53Pat_W http://www.openstreetmap.org/?lat=17.982348&lon=-66.030917
PR178/753 http://www.openstreetmap.org/?lat=17.974552&lon=-66.058453
PR178_W http://www.openstreetmap.org/?lat=17.977628&lon=-66.069106
PR54/748 http://www.openstreetmap.org/?lat=17.980547&lon=-66.085328
PR748_S http://www.openstreetmap.org/?lat=17.980139&lon=-66.086916
PR744 http://www.openstreetmap.org/?lat=17.979742&lon=-66.110310
PR15 http://www.openstreetmap.org/?lat=17.985190&lon=-66.113545
PR54_W http://www.openstreetmap.org/?lat=17.977685&lon=-66.123845
PR710 http://www.openstreetmap.org/?lat=17.960162&lon=-66.139069
PR7707 http://www.openstreetmap.org/?lat=17.957284&lon=-66.154368
PR7710 http://www.openstreetmap.org/?lat=17.956243&lon=-66.159862
PR707 http://www.openstreetmap.org/?lat=17.955324&lon=-66.165398
PR713 http://www.openstreetmap.org/?lat=17.966357&lon=-66.181491
PR706 http://www.openstreetmap.org/?lat=17.970775&lon=-66.218628
PR705 http://www.openstreetmap.org/?lat=17.971592&lon=-66.226535
PR703 http://www.openstreetmap.org/?lat=17.968040&lon=-66.260589
PR180 http://www.openstreetmap.org/?lat=17.974215&lon=-66.289095
PR1_S http://www.openstreetmap.org/?lat=17.976202&lon=-66.298542

Here's the PR30 file, which has borh 28 and 28A points (due to two interchanges that have different numbers in different directions):

Code: [Select]
PR52 http://www.openstreetmap.org/?lat=18.264239&lon=-66.038608
0 http://www.openstreetmap.org/?lat=18.259400&lon=-66.037145
3 http://www.openstreetmap.org/?lat=18.248977&lon=-66.017103
4 http://www.openstreetmap.org/?lat=18.245899&lon=-66.007356
5 http://www.openstreetmap.org/?lat=18.246735&lon=-65.993843
7 http://www.openstreetmap.org/?lat=18.249683&lon=-65.975770
8 http://www.openstreetmap.org/?lat=18.249130&lon=-65.972139
9 http://www.openstreetmap.org/?lat=18.249812&lon=-65.961485
12 http://www.openstreetmap.org/?lat=18.236790&lon=-65.926015
13 http://www.openstreetmap.org/?lat=18.234375&lon=-65.921627
14 http://www.openstreetmap.org/?lat=18.226518&lon=-65.917196
19 http://www.openstreetmap.org/?lat=18.184691&lon=-65.888143
21 http://www.openstreetmap.org/?lat=18.175150&lon=-65.876899
22 http://www.openstreetmap.org/?lat=18.168626&lon=-65.868423
25 http://www.openstreetmap.org/?lat=18.155904&lon=-65.841064
26 http://www.openstreetmap.org/?lat=18.144710&lon=-65.833039
28 http://www.openstreetmap.org/?lat=18.138491&lon=-65.830164
28A http://www.openstreetmap.org/?lat=18.134989&lon=-65.825438
30 http://www.openstreetmap.org/?lat=18.124919&lon=-65.817300
I can switch PR 30's 28 and 28A labels if you think that would make more sense.
Clinched:

Offline compdude787

  • TM Collaborator
  • Full Member
  • *****
  • Posts: 163
  • Last Login:November 17, 2018, 12:50:41 am
Re: usapr
« Reply #13 on: June 04, 2017, 03:45:43 pm »
Well, that's weird. The HDX, which I'm mainly using for this peer review, shows a different name for the waypoint where PR 3 meets PR30. I guess I should just use the highway browser to review routes.

Anyway....as for PR 30,  the point currently labeled as 28 should be 27, and the point that's currently 28A should be 28.

Offline Jim

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 1318
  • Last Login:Yesterday at 11:43:22 pm
Re: usapr
« Reply #14 on: June 04, 2017, 04:25:07 pm »
Well, that's weird. The HDX, which I'm mainly using for this peer review, shows a different name for the waypoint where PR 3 meets PR30. I guess I should just use the highway browser to review routes.

Anyway....as for PR 30,  the point currently labeled as 28 should be 27, and the point that's currently 28A should be 28.

HDX loads graphs, not routes.  There's an extensive process that simplifies labels at intersections and along concurrencies.  Definitely use the HB, not HDX, as the way to see what the labels are for TM purposes.