Author Topic: usaga: Georgia State Highways  (Read 38372 times)

dfilpus and 2 Guests are viewing this topic.

Online oscar

  • TM Collaborator
  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 939
  • Last Login:Today at 08:41:31 am
    • Hot Springs and Highways pages
Re: usaga: Georgia State Highways
« Reply #300 on: March 22, 2020, 08:50:26 am »
GA 115 should get another waypoint in Cleveland, matching the GA115 point on US 129 Bypass.

Thanks for all the Perry area changes, which I've just incorporated in my list file.

Offline neroute2

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 539
  • Last Login:Yesterday at 11:56:13 pm
Re: usaga: Georgia State Highways
« Reply #301 on: March 22, 2020, 09:52:30 am »
GA 115 should get another waypoint in Cleveland, matching the GA115 point on US 129 Bypass.
115 also has waypoints in the wrong order in Cleveland.

Offline ntallyn

  • TM Collaborator
  • Full Member
  • *****
  • Posts: 163
  • Last Login:Yesterday at 06:30:04 pm
Re: usaga: Georgia State Highways
« Reply #302 on: March 22, 2020, 10:56:36 am »
Looks like both of these issues are due to a "Duplicate Coordinate" issue. It appears I put the US129 coordinates in for the US129Byp label as well. Fixed locally.

Offline ntallyn

  • TM Collaborator
  • Full Member
  • *****
  • Posts: 163
  • Last Login:Yesterday at 06:30:04 pm
Re: usaga: Georgia State Highways
« Reply #303 on: Yesterday at 03:50:25 pm »
Everything has been pushed. I went through all of the route files and updated/removed all of the Old* labels. The ones that remain in the files fall into one of the following categories:

1. Closed intersections
2. Intersections that are actually signed Old*
3. Intersections that I couldn't find any evidence that the label was incorrect.

https://github.com/TravelMapping/HighwayData/pull/3705

At this point, I've completed all of the comments and suggestions in this thread, as well as all of the updates mentioned in the GA route update forum. Once this is merged, I believe this system is ready for activation.

Offline Jim

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 1606
  • Last Login:Yesterday at 09:56:10 pm
Re: usaga: Georgia State Highways
« Reply #304 on: Yesterday at 04:39:14 pm »
Assuming usaga is next to activate, it will be the one that puts us over 1,000,000 miles in active systems, and will blow past what we need to get there by quite a bit.

Offline michih

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 2168
  • Last Login:Yesterday at 04:50:30 pm
Re: usaga: Georgia State Highways
« Reply #305 on: Yesterday at 04:41:38 pm »
Once this is merged,

with tonight's update

I believe this system is ready for activation.

You just need to edit systems.csv and systemupdates.csv.

Code: [Select]
usaga;USA;Georgia State Highways;brown;4;preview
->
usaga;USA;Georgia State Highways;brown;4;active

Code: [Select]
-->
2020-03-28;(USA) Georgia;usaga;Georgia State Highways;active

Offline ntallyn

  • TM Collaborator
  • Full Member
  • *****
  • Posts: 163
  • Last Login:Yesterday at 06:30:04 pm
Re: usaga: Georgia State Highways
« Reply #306 on: Yesterday at 06:17:14 pm »
I'm also moving the 3 NSF routes into the regular GA state highway folder. Do I need to do anything else with those?

Should I edit my current pull request with these files?

Offline si404

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 1169
  • Last Login:Today at 06:40:04 am
Re: usaga: Georgia State Highways
« Reply #307 on: Yesterday at 06:47:46 pm »
I'm also moving the 3 NSF routes into the regular GA state highway folder. Do I need to do anything else with those?
Remove them from the NSF system .csvs

Offline Jim

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 1606
  • Last Login:Yesterday at 09:56:10 pm
Re: usaga: Georgia State Highways
« Reply #308 on: Yesterday at 09:16:09 pm »
Are we good to go for tonight?  I can wait for the additions to the pull request or a new pull request that does the activation, or that can just happen tomorrow instead.