Author Topic: IA, WI, SD, IL, MO: NMPs  (Read 1114 times)

0 Members and 1 Guest are viewing this topic.

Offline Highway63

  • TM Collaborator
  • Full Member
  • *****
  • Posts: 214
  • Last Login:August 07, 2019, 02:26:48 am
IA, WI, SD, IL, MO: NMPs
« on: September 07, 2018, 01:22:04 am »
I could volunteer to do Iowa for you and see where things go from there...

Edit: I went ahead and did Iowa anyway, on my local machine, just to see how long it would take.  ;D
18:59, of which 3:48 was just downloading the HighwayData repo, a step that won't need to be repeated.
So, 15:11 for 22 pairs? Not bad. I did leave out many points at state lines, but still wasted time looking them over to see if they could be best fixed by only changing the coords in the IA files. (At that rate, MO would take me... 3:16:42?)
If you'd like, I can put in a pull request and email you the changed files.
YES PLEASE. I spent 45 minutes Tuesday night in the Bloomington area alone and another 20 today on US 150/I-74. I'll hold off trying to plug away at more while you try your method.

Even if that leaves all the state-line points - of which there appear to be quite a few, not all of which are both states I do - that would get me light-years ahead as opposed to my golf-cart speed.
« Last Edit: September 07, 2018, 01:26:44 am by Highway63 »

Offline yakra

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 2074
  • Last Login:Yesterday at 12:42:58 am
Re: IA, WI, SD, IL, MO: NMPs
« Reply #1 on: September 07, 2018, 03:28:19 am »
YES PLEASE. ...
Even if that leaves all the state-line points - of which there appear to be quite a few, not all of which are both states I do - that would get me light-years ahead as opposed to my golf-cart speed.
Most of the state-line points are between two of your states, which makes things easier. What I'm thinking is:
1st pass: Go state-by-state, only editing NMPs fully within a single state.
2nd pass: Fix NMPs at state lines.
2½: Any NMPs at the MN state line where MN has the obviously better coords.
Whatever's left over could be sorted out with froggie.

I spent 45 minutes Tuesday night in the Bloomington area alone and another 20 today on US 150/I-74. I'll hold off trying to plug away at more while you try your method.
Looks like, since I posted, there have been no changes in IA.
Shall I go ahead and commit my IA changes, then?
Did you have any work in progress there I'd need to watch out for?

Did some work in WI too; I see there have been some changes there. Will need to give a closer look to make sure none of my edits conflict.

Offline froggie

  • TM Collaborator
  • Sr. Member
  • *****
  • Posts: 464
  • Last Login:Today at 09:53:14 am
Re: IA, WI, SD, IL, MO: NMPs
« Reply #2 on: September 07, 2018, 07:08:11 am »
^ If Jason's fine with that, I'll take care of the MN/IA border points.

(and now that I look at the log, the MN/WI border points as well)

Offline yakra

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 2074
  • Last Login:Yesterday at 12:42:58 am
Re: IA, WI, SD, IL, MO: NMPs
« Reply #3 on: September 08, 2018, 02:08:51 am »
Highway63, are these changes OK with you?
https://github.com/TravelMapping/HighwayData/pull/2201

Offline Highway63

  • TM Collaborator
  • Full Member
  • *****
  • Posts: 214
  • Last Login:August 07, 2019, 02:26:48 am
Re: IA, WI, SD, IL, MO: NMPs
« Reply #4 on: September 08, 2018, 12:13:52 pm »
Highway63, are these changes OK with you?
https://github.com/TravelMapping/HighwayData/pull/2201
Those all look good. For the sake of efficiency, since there are so many routes and points and since you have a much better handle on your matching system than I do, it's OK for you to go through the points and submit batches at a time. I just need to know which routes were changed and I'll just download the new versions after the fact (since, as I learned with the Bloomington work, multiple points along a single route can change).

The only weakness I see in this method, and it's hardly a justification for doing it the slow way, is seeing cases when both points are just "off" enough that I want to make a new one for all of them.

Offline yakra

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 2074
  • Last Login:Yesterday at 12:42:58 am
Re: IA, WI, SD, IL, MO: NMPs
« Reply #5 on: September 08, 2018, 02:05:26 pm »
For the sake of efficiency, since there are so many routes and points and since you have a much better handle on your matching system than I do, it's OK for you to go through the points and submit batches at a time. I just need to know which routes were changed and I'll just download the new versions after the fact (since, as I learned with the Bloomington work, multiple points along a single route can change).
I'm keeping track of which routes change as I go; everything I've saved locally after a certain date/time. If it makes it easier for you, rather than downloading them all one-by-one when it's all said & done, I can ZIP up all the files that have changed and email that to you.

In the meantime, for each pull request, you can click on Files changed and see which ones.
( ia.i380.wpt ia.ia027.wpt ia.ia141.wpt ia.ia330.wpt ia.us006.wpt ia.us061.wpt ia.us065.wpt ia.us136.wpt ia.us075bussio.wpt il.us030.wpt )

The only weakness I see in this method, and it's hardly a justification for doing it the slow way, is seeing cases when both points are just "off" enough that I want to make a new one for all of them.
When there are only two routes involved in one spot, I usually just take the better-looking coords and copy them into the other file. When there are, say, 3 routes where 2 match and 1 doesn't, I'll keep it simple & edit the 1 file to match the 2 others, unless the 2 routes have coords that are significantly "off" enough for me to decide they're more in need of a fix. If all the points look bad enough, sometimes I'll grab fresh coords from WPTeit and edit all the affected files.

Offline yakra

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 2074
  • Last Login:Yesterday at 12:42:58 am
Re: IA, WI, SD, IL, MO: NMPs
« Reply #6 on: September 08, 2018, 02:12:46 pm »
Did some work in WI too; I see there have been some changes there. Will need to give a closer look to make sure none of my edits conflict.
Upon closer look, I see the only change was to WI WI92 WI78, identical to a change I made. We should be in good shape here.

Edit: https://github.com/TravelMapping/HighwayData/pull/2203
« Last Edit: September 08, 2018, 02:29:51 pm by yakra »

Offline froggie

  • TM Collaborator
  • Sr. Member
  • *****
  • Posts: 464
  • Last Login:Today at 09:53:14 am
Re: IA, WI, SD, IL, MO: NMPs
« Reply #7 on: September 08, 2018, 02:40:46 pm »
Didn't see a response from Jason or Eric so assuming I have green light to address the IA/MN and MN/WI border points.

Offline yakra

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 2074
  • Last Login:Yesterday at 12:42:58 am
Re: IA, WI, SD, IL, MO: NMPs
« Reply #8 on: September 08, 2018, 03:22:06 pm »
How about we wait till the rest of the NMPs in Jeff's states are fixed, to avoid any potential edit conflicts, and then pick off what state line points are left over from there, choosing the best coords for both states as appropriate?

Offline froggie

  • TM Collaborator
  • Sr. Member
  • *****
  • Posts: 464
  • Last Login:Today at 09:53:14 am
Re: IA, WI, SD, IL, MO: NMPs
« Reply #9 on: September 08, 2018, 05:14:22 pm »
Sure, I can wait.  I just hadn't seen a response to my query the other day, despite the proliferation of posts.

Offline yakra

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 2074
  • Last Login:Yesterday at 12:42:58 am
Re: IA, WI, SD, IL, MO: NMPs
« Reply #10 on: September 09, 2018, 02:21:57 am »

Offline Highway63

  • TM Collaborator
  • Full Member
  • *****
  • Posts: 214
  • Last Login:August 07, 2019, 02:26:48 am
Re: IA, WI, SD, IL, MO: NMPs
« Reply #11 on: September 09, 2018, 11:55:34 pm »
I'm keeping track of which routes change as I go; everything I've saved locally after a certain date/time. If it makes it easier for you, rather than downloading them all one-by-one when it's all said & done, I can ZIP up all the files that have changed and email that to you.
That would be great. :) I notice the GitHub file lists don't have a "last modified" option; that's kind of a bummer on general purpose.

Quote
When there are only two routes involved in one spot, I usually just take the better-looking coords and copy them into the other file. When there are, say, 3 routes where 2 match and 1 doesn't, I'll keep it simple & edit the 1 file to match the 2 others, unless the 2 routes have coords that are significantly "off" enough for me to decide they're more in need of a fix. If all the points look bad enough, sometimes I'll grab fresh coords from WPTeit and edit all the affected files.
I'd likely do about the same. The whole NMP issue kind of stumps me, though. A handful of the ones I did touch because of this hadn't been touched since at least 2012, when the conversion from GGM to WPT was made.

Offline yakra

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 2074
  • Last Login:Yesterday at 12:42:58 am
Re: IA, WI, SD, IL, MO: NMPs
« Reply #12 on: September 10, 2018, 01:27:42 am »
I notice the GitHub file lists don't have a "last modified" option; that's kind of a bummer on general purpose.
The info is there; you just have to surf around a bit to get to it. From the Files Changed link, click the "View" button in the gray area at the upper-right of the diff for whatever file you want to check out. That lets you view the whole file at the most recent commit. In the case of IA I-380, that takes you here. From there, at the right of the gray bar above the .wpt code, click "History". You can see the previous commits for that file, and there are links to the diffs from those commits as well.

The whole NMP issue kind of stumps me, though. A handful of the ones I did touch because of this hadn't been touched since at least 2012, when the conversion from GGM to WPT was made.
As I go thru IL, I'm seeing a lot of Business Interstates. We know Tim wasn't bothered by non-matching points when drafting that system, so there's that. :)

Offline yakra

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 2074
  • Last Login:Yesterday at 12:42:58 am
Re: IA, WI, SD, IL, MO: NMPs
« Reply #13 on: September 10, 2018, 01:44:56 am »
« Last Edit: September 10, 2018, 02:14:24 am by yakra »

Offline yakra

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 2074
  • Last Login:Yesterday at 12:42:58 am
Re: IA, WI, SD, IL, MO: NMPs
« Reply #14 on: September 10, 2018, 03:15:26 pm »
MO NMPs @ https://github.com/TravelMapping/HighwayData/pull/2214
Next step = state lines, marking FPs, and anything I may have missed.