Author Topic: Morocco Route Nationale (marn)  (Read 1405 times)

0 Members and 1 Guest are viewing this topic.

Offline panda80

  • TM Collaborator
  • Jr. Member
  • *****
  • Posts: 91
  • Last Login:Yesterday at 09:53:21 am
Re: Morocco Route Nationale (marn)
« Reply #30 on: January 20, 2019, 03:07:32 pm »
MAR N16:

N16_E --> A5_E (or A5_KsaN?); alt label required


Why put an alt Label on N16? It's not yet possible for someone to have mileage there.

ToCeu: The route to Ceuta is indicated "N13" on GM but not on OSM. Any idea about the actual status? I guess N13 is outdated (the different N16 routing to the south on GM too)
Yes, these are reminiscent from the old numbering.

MAR N17:
I think P1522 is totally off, isn't it?
By zooming out or deep zooming in, is the point where I placed it.

MAR/MRT --> ESH/MRT

According to Si, is MAR/MRT correct. You also accepted his point of view.

Offline michih

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 1515
  • Gender: Male
  • Last Login:Yesterday at 10:41:53 am
Re: Morocco Route Nationale (marn)
« Reply #31 on: January 20, 2019, 03:17:39 pm »
MAR N16:

N16_E --> A5_E (or A5_KsaN?); alt label required

Why put an alt Label on N16? It's not yet possible for someone to have mileage there.

For A5, not for N16

MAR N17:
I think P1522 is totally off, isn't it?
By zooming out or deep zooming in, is the point where I placed it.

IS http://www.openstreetmap.org/?lat=30.060254&lon=-6.869416
SHOULD_BE http://www.openstreetmap.org/?lat=30.060388&lon=-6.869387

MAR/MRT --> ESH/MRT

According to Si, is MAR/MRT correct. You also accepted his point of view.

Yep, but I've posted it before :) I've edited the original post now.

Offline panda80

  • TM Collaborator
  • Jr. Member
  • *****
  • Posts: 91
  • Last Login:Yesterday at 09:53:21 am
Re: Morocco Route Nationale (marn)
« Reply #32 on: January 20, 2019, 03:29:37 pm »
IS http://www.openstreetmap.org/?lat=30.060254&lon=-6.869416
SHOULD_BE http://www.openstreetmap.org/?lat=30.060388&lon=-6.869387

Ok, I thought you were reffering to the other position, more to the NE, which is shown by OSM at some zoom levels.

Offline panda80

  • TM Collaborator
  • Jr. Member
  • *****
  • Posts: 91
  • Last Login:Yesterday at 09:53:21 am
Re: Morocco Route Nationale (marn)
« Reply #33 on: January 21, 2019, 04:24:46 am »
N25_N --> N25_E
N25 is for me a N-S route.

MAR N29:

Move +X9 a little bit to the north

First round of review done.

Thank you. Implemented the changes, will come with the next pull request.

Offline panda80

  • TM Collaborator
  • Jr. Member
  • *****
  • Posts: 91
  • Last Login:Yesterday at 09:53:21 am
Re: Morocco Route Nationale (marn)
« Reply #34 on: January 24, 2019, 04:41:23 am »
System is now in preview.

Offline michih

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 1515
  • Gender: Male
  • Last Login:Yesterday at 10:41:53 am
Re: Morocco Route Nationale (marn)
« Reply #35 on: January 26, 2019, 03:11:08 am »
1. I recommend adding a shaping point on N1 south of A501 wp so that A501 and N1 can be distinguished on mapview. It currently looks like being concurrent.

2. N8/N29 concurrency is broken north of P7308 (both shaping points need to be synced)

3. N10/N13 concurrency is broken (N13 wp N10_W needs to be moved to N10 wp N13_N location)

4. A3 end point label needs to be corrected: +N8_D N11/N11A --> N11/N11A +N8_D. It's an invisible wp which cannot be browsed right now: http://travelmapping.net/hb/index.php?r=mar.a003

5. N7/N10 concurrency is broken west of P1731

6. Additional N11 segment b/n A101/N1 and A3?

@panda80, I recommend you exploring HDX to see how you can find the issues.
I used Option 1 "Search for a METAL graph by name." to find all issues but you can also download mar.nmp from here and upload to HDX by option 3 to find NMPs. You might find issue no. 2, 3 and 5 this way much easier.

http://travelmapping.net/devel/datacheck.php?sys=null&rg=MAR

The HIDDEN_TERMINUS error for A3 and the VISIBLE_HIDDEN_COLOC for N11 are caused by issue no. 4
The HIDDEN_JUNCTION erros should be caused by the broken concurrencies but I'm not sure.
The DUPLICATE_LABEL errors should be clear, just change the names.
Please check all SHARP_ANGLE errors manually but I guess all should be on purpose and can be marked FP. Copy the content of the "FP Entry to Submit" column to datacheckfps.csv after checking the situation with wpt editor
The same for LONG_SEGMENT errors. Check that they are on purpose and mark them FP.
VISIBLE_DISTANCE errors can generally be ignored here.

All tools can be found here: http://travelmapping.net/devel/tools.php

If there's any question, just ask :)

Offline michih

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 1515
  • Gender: Male
  • Last Login:Yesterday at 10:41:53 am
Re: Morocco Route Nationale (marn)
« Reply #36 on: January 26, 2019, 03:20:26 am »
http://travelmapping.net/devel/datacheck.php?sys=null&rg=ESH

The N1 LABEL_SELFREF error needs to be marked FP too.
Other errors are handled like the MAR issues mentioned above.

Offline michih

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 1515
  • Gender: Male
  • Last Login:Yesterday at 10:41:53 am
Re: Morocco Route Nationale (marn)
« Reply #37 on: January 26, 2019, 01:34:41 pm »
Another issue is the system name. I've changed system.csv (I've enter wrong by accident) and systemupdates.csv entries to "Morocco Routes Nationales" like mara and fran system names.

Offline michih

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 1515
  • Gender: Male
  • Last Login:Yesterday at 10:41:53 am
Re: Morocco Route Nationale (marn)
« Reply #38 on: January 28, 2019, 01:01:45 pm »
You've added N11Cas and N11 needs a "city" name now. I think there is no relevant city describing the route fine. I would add (Main).

Offline michih

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 1515
  • Gender: Male
  • Last Login:Yesterday at 10:41:53 am
Re: Morocco Route Nationale (marn)
« Reply #39 on: March 23, 2019, 06:07:07 am »
I think that the system is ready for activation. Any objections?

Offline michih

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 1515
  • Gender: Male
  • Last Login:Yesterday at 10:41:53 am
Re: Morocco Route Nationale (marn)
« Reply #40 on: April 07, 2019, 02:20:45 am »
System is active now.

Congrats! First system activated, panda80! :)

Offline panda80

  • TM Collaborator
  • Jr. Member
  • *****
  • Posts: 91
  • Last Login:Yesterday at 09:53:21 am
Re: Morocco Route Nationale (marn)
« Reply #41 on: April 08, 2019, 02:43:55 am »
Congrats! First system activated, panda80! :)

Thanks a lot for your help :)