Author Topic: Better edge/connection popups  (Read 687 times)

0 Members and 1 Guest are viewing this topic.

Offline Jim

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 1490
  • Last Login:Today at 06:13:33 am
Better edge/connection popups
« on: June 30, 2019, 10:22:46 pm »
I've worked some today on improving the popups that appear when you click on an edge/connection on a map.  Much of it has so far been deciphering and streamlining some of the existing code.  Nothing should have changed in HDX, but in the HB and on Mapview, you should now be able to get at least some meaningful and hopefully correct information.

Try out this version by going to any of the maps from the tmtest.teresco.org instance of the site.

Relevant issue: https://github.com/TravelMapping/Web/issues/228

Offline mapcat

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 828
  • Last Login:Yesterday at 01:33:06 pm
Re: Better edge/connection popups
« Reply #1 on: July 01, 2019, 12:17:25 am »
Great new feature! The only odd behavior I've noticed so far is that occasionally the map shifts seemingly randomly after clicking on a segment. I.e., clicking on a segment in the center of the map may result in that segment moving to the edge of the map when the popup appears.

Edit: Eric mentioned the same behavior in the issue comments.
Clinched:

Offline michih

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 1608
  • Last Login:Today at 02:29:48 pm
Re: Better edge/connection popups
« Reply #2 on: July 01, 2019, 10:28:13 am »
Thanks :) In HB, the units conversion doesn't apply to the popup. The number of positions after decimal point should be identical on the site (2 vs. 4)

Offline CharlotteAllisonCDTG

  • Newbie
  • *
  • Posts: 46
  • Gender: Female
  • Last Login:Today at 11:30:34 am
  • Transgender Lesbian and Traveler
    • My Wikipedia User Page
Re: Better edge/connection popups
« Reply #3 on: July 01, 2019, 11:50:58 am »
I went to the test web address.  Since I live just off GA 223 in Grovetown, Georgia, I looked at that page.  When I clicked on it, the map showed a spot in the Albany, NY area!  When I clicked on the junctions on the left side of the page, the map jumped to the correct area.  However, the junctions don't have any markers to click on.  Therefore, I can't test this feature out.   :-[
Completely clinched:  I-24, I-35W (MN), I-97, I-124, I-126, I-155 (MO-TN), I-190 (SD), I-195 (MD), I-240 (NC), I-295 (FL), I-375 (MI), I-516, I-520, I-526, I-564, I-585, I-640, I-675 (GA), I-895A, US 178, US 276

Offline michih

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 1608
  • Last Login:Today at 02:29:48 pm
Re: Better edge/connection popups
« Reply #4 on: July 01, 2019, 01:03:38 pm »
Same here. No graph at all. Anything must have been changed in the last 2 hours.

Offline Jim

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 1490
  • Last Login:Today at 06:13:33 am
Re: Better edge/connection popups
« Reply #5 on: July 01, 2019, 01:33:05 pm »
Yes, active development today and I broke it.  Should be back soon.

Offline Jim

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 1490
  • Last Login:Today at 06:13:33 am
Re: Better edge/connection popups
« Reply #6 on: July 02, 2019, 02:46:23 pm »
Several improvements this afternoon.  Mostly in mapview behavior.  Check it out on tmtest.

Main flaws I am aware of:

- only the "topmost" polyline's info is used for concurrencies.  So the highest tier route, and within that, the one latest in the DB.

- Everything is miles, does not honor units preferences (waiting until the end to consider that).

Offline Jim

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 1490
  • Last Login:Today at 06:13:33 am
Re: Better edge/connection popups
« Reply #7 on: July 02, 2019, 05:01:38 pm »
Route names including HB links are now in the connection popups.  I think it's working on all but I'm happy to have people test.

Next idea: somehow highlight the Polyline on the map (maybe make it more opaque and/or wider or put some partially transparent Polyline on top of it) while the corresponding popup is showing.  I don't think this is hard.

Offline Jim

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 1490
  • Last Login:Today at 06:13:33 am
Re: Better edge/connection popups
« Reply #8 on: July 02, 2019, 10:04:27 pm »
Polyline highlighting now works everywhere I've tried.  A black but partially transparent and double width polyline is drawn over the selected segment.  I think it looks sharp as is, but I'm open to ideas on how to improve and of course let me know if anything appears broken.  This is all still on the tmtest.teresco.org version of the server.

Offline yakra

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 2055
  • Last Login:Today at 12:35:30 pm
Re: Better edge/connection popups
« Reply #9 on: July 02, 2019, 10:59:20 pm »
An option to click for a list of travelers would be nice. Maybe a JavaScript alert; something with we could copy & paste would be ideal.

Offline mapcat

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 828
  • Last Login:Yesterday at 01:33:06 pm
Re: Better edge/connection popups
« Reply #10 on: July 03, 2019, 09:14:10 am »
The highlighting looks good. How about making links in popups open in a new tab?



Clinched:

Offline Jim

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 1490
  • Last Login:Today at 06:13:33 am
Re: Better edge/connection popups
« Reply #11 on: July 03, 2019, 09:37:57 am »
The highlighting looks good. How about making links in popups open in a new tab?

Good idea.  Done.

Offline michih

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 1608
  • Last Login:Today at 02:29:48 pm
Re: Better edge/connection popups
« Reply #12 on: July 04, 2019, 02:21:56 pm »
Polyline highlighting now works everywhere I've tried.
Route names including HB links are now in the connection popups.

Works fine. Is it possible to highlight the same segment in HB too?

Offline Jim

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 1490
  • Last Login:Today at 06:13:33 am
Re: Better edge/connection popups
« Reply #13 on: July 04, 2019, 11:01:37 pm »
Polyline highlighting now works everywhere I've tried.
Route names including HB links are now in the connection popups.

Works fine. Is it possible to highlight the same segment in HB too?

You mean in the HB window that pops up?  I think that would take some effort, but if it's a feature you think would be useful, I'd say put it in a GitHub issue in the Web repository.

Offline michih

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 1608
  • Last Login:Today at 02:29:48 pm
Re: Better edge/connection popups
« Reply #14 on: July 05, 2019, 09:27:40 am »