Author Topic: Better edge/connection popups  (Read 2107 times)

0 Members and 1 Guest are viewing this topic.

Offline Jim

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 1532
  • Last Login:Yesterday at 10:02:26 pm
Re: Better edge/connection popups
« Reply #15 on: July 05, 2019, 02:12:03 pm »
The main functionality here is now live on the production site.  If there are additional features of interest that don't already have GitHub issues, please create them.

Offline oscar

  • TM Collaborator
  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 811
  • Last Login:Yesterday at 11:41:58 pm
    • Hot Springs and Highways pages
Re: Better edge/connection popups
« Reply #16 on: July 05, 2019, 08:42:30 pm »
Maybe a related new problem with the HB -- when I call up a route (in this particular case, new MD 206 -- but same issue for other routes), using my regular username oscar, instead of a map centered on the requested route, it's centered on the Siena College campus. When I click one of the waypoints listed in the HB's left column, it takes me to the right map location, but doesn't show any of the waypoints or associated popups.

Offline Jim

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 1532
  • Last Login:Yesterday at 10:02:26 pm
Re: Better edge/connection popups
« Reply #17 on: July 05, 2019, 09:13:40 pm »
@oscar: try a shift-reload to make sure your browser isn't caching old versions of any Javascript files.

Offline oscar

  • TM Collaborator
  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 811
  • Last Login:Yesterday at 11:41:58 pm
    • Hot Springs and Highways pages
Re: Better edge/connection popups
« Reply #18 on: July 05, 2019, 09:43:00 pm »
That worked. Thanx.

Offline mapcat

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 875
  • Last Login:Yesterday at 03:25:37 pm
Re: Better edge/connection popups
« Reply #19 on: July 06, 2019, 05:22:17 pm »
The main functionality here is now live on the production site.  If there are additional features of interest that don't already have GitHub issues, please create them.

Okay, here's one: https://github.com/TravelMapping/Web/issues/316

Shift-click to select multiple segments in mapview, produce .list entry in popup
Clinched:

Offline Jim

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 1532
  • Last Login:Yesterday at 10:02:26 pm
Re: Better edge/connection popups
« Reply #20 on: July 09, 2019, 02:19:58 pm »
Thinking about this modification: force the popup window to be at the northernmost point on the connection/edge (which would necessarily be an endpoint or shaping point) so it doesn't obscure any of the actual Polyline.  Opinions?

Offline michih

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 1752
  • Last Login:Today at 02:41:50 am
Re: Better edge/connection popups
« Reply #21 on: July 09, 2019, 04:04:55 pm »
I'm not sure whether I like or dislike it more. I think it would look odd when the segment is vertical. But I'd like to see it live an play with it.

Offline mapcat

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 875
  • Last Login:Yesterday at 03:25:37 pm
Re: Better edge/connection popups
« Reply #22 on: July 09, 2019, 07:02:44 pm »
Thinking about this modification: force the popup window to be at the northernmost point on the connection/edge (which would necessarily be an endpoint or shaping point) so it doesn't obscure any of the actual Polyline.  Opinions?
Go for it. The need to close the popup to select another segment slightly annoyed me.
Clinched:

Offline yakra

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 2134
  • Last Login:Today at 01:42:51 am
Re: Better edge/connection popups
« Reply #23 on: July 14, 2019, 09:44:07 am »
Not implemented yet, I presume?
https://github.com/TravelMapping/Web/issues/327

I'm not sure whether I like or dislike it more.
Seconded.

Offline Jim

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 1532
  • Last Login:Yesterday at 10:02:26 pm
Re: Better edge/connection popups
« Reply #24 on: July 14, 2019, 11:04:59 am »
I haven't done it yet.

Offline Jim

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 1532
  • Last Login:Yesterday at 10:02:26 pm
Re: Better edge/connection popups
« Reply #25 on: July 15, 2019, 08:52:25 pm »
tmtest has the "put the popup at the northernmost point on the Polyline" mentioned above.

I think it's an improvement, but would leave it as it is on the production server if there's a lot of preference expressed for the old way.

Offline Jim

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 1532
  • Last Login:Yesterday at 10:02:26 pm
Re: Better edge/connection popups
« Reply #26 on: July 15, 2019, 09:14:53 pm »
As part of my attempt to address https://github.com/TravelMapping/Web/issues/327 I've also changed it so at zoom levels 12 and up, it does not force the popup at the northernmost point.

Offline michih

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 1752
  • Last Login:Today at 02:41:50 am
Re: Better edge/connection popups
« Reply #27 on: July 16, 2019, 01:09:59 pm »
Since it's only at zoom level 12 and down, it's fine to me! I'm also sure that it would be bad with higher zoom levels. I'd leave it as-is and bring it to the production server.

Offline yakra

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 2134
  • Last Login:Today at 01:42:51 am
Re: Better edge/connection popups
« Reply #28 on: July 16, 2019, 01:28:47 pm »
Sounds like a good compromise, best-of-both-worlds approach.
Is a compromise really best-of-both-worlds though? Maybe I mean "second-best-of-both-worlds approach." Bleah. Semantics.

Offline michih

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 1752
  • Last Login:Today at 02:41:50 am
Re: Better edge/connection popups
« Reply #29 on: July 16, 2019, 02:46:09 pm »
Is a compromise really best-of-both-worlds though? Maybe I mean "second-best-of-both-worlds approach."

I think it is the best solution since we have different use-cases.