Author Topic: PA / DE: grepping for waypoint labels  (Read 244 times)

0 Members and 1 Guest are viewing this topic.

Offline yakra

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 2245
  • Last Login:October 18, 2019, 03:13:53 pm
PA / DE: grepping for waypoint labels
« on: October 04, 2019, 04:41:48 pm »
Markkos1992 advised me via a PM that he would not have a problem if you weighed in with this stuff on PA and DE.
Otherwise, I'm not sure I'd wanna dump a ton of these results on the board without someone asking for it first. (Regions undergoing peer review aside!) :) For those who want to look into it themselves, the option is available.
For a more detailed description of just what it is I'm doing & how, and the rationale behind each search, see this topic. There are a few more searches listed there; in this post I've only included those with results in PA or DE.

Old highway designation labels
grep '^Old..[0-9]' $rg/*/*.wpt
Waypoints for roads that no longer have a name or no longer exist as a road
Quote
MainSt
If the old highway has a posted name or number, use that name or number (don't make one up), and label the waypoint according to the usual rules.
If US 30/Main Street becomes Main Street, then the label is MainSt, not something like OldUS30.

OldUS40
If the old highway has a posted name that mentions the old designation, then applying the above rule will result in a label like OldUS40 for "Old Route 40" if the route was formerly US 40.
There will be a good number of false-positive, legitimate labels here. I did see a few that looked like changes were in order, OldUS22 for William Penn Hwy, a couple OldPA86 labels.
I'm not sure how closely these rules (if it's a requirement & not an option) have been followed; there are a lot of examples where "OldRt" or "OldHwy", etc. are used if a road is signed as such in the field, or if that's the official name. (Although, Tim may have done it that way before these specific guidelines were codified...) May be something worth discussing in the forum. If you decide not to change some of these cases I won't cry about it.
PA/usapa/pa.pa008.wpt: OldRt8 http://www.openstreetmap.org/?lat=41.216257&lon=-79.971113
PA/usapa/pa.pa066busgre.wpt: OldRt66 http://www.openstreetmap.org/?lat=40.376716&lon=-79.573296
PA/usapa/pa.pa066.wpt: OldPA66 http://www.openstreetmap.org/?lat=40.730865&lon=-79.535045
PA/usapa/pa.pa099.wpt: OldPA86 http://www.openstreetmap.org/?lat=41.813313&lon=-80.057625
PA/usapa/pa.pa110.wpt: OldUS119 http://www.openstreetmap.org/?lat=40.657775&lon=-79.126303
PA/usapa/pa.pa143.wpt: OldUS22 http://www.openstreetmap.org/?lat=40.572242&lon=-75.886315
PA/usapa/pa.pa217.wpt: OldPA217 +OldPA17 http://www.openstreetmap.org/?lat=40.374117&lon=-79.266376
PA/usapa/pa.pa262.wpt: OldPA262_E http://www.openstreetmap.org/?lat=40.172778&lon=-76.826824
PA/usapa/pa.pa286.wpt: OldPA56 http://www.openstreetmap.org/?lat=40.580130&lon=-79.223871
PA/usapa/pa.pa308.wpt: OldRt8 http://www.openstreetmap.org/?lat=41.269864&lon=-79.926170
PA/usapa/pa.pa419.wpt: OldUS22 http://www.openstreetmap.org/?lat=40.484321&lon=-76.226192
PA/usapa/pa.pa481.wpt: OldRt71 http://www.openstreetmap.org/?lat=40.136934&lon=-79.950605
PA/usapa/pa.pa484.wpt: OldRt126 http://www.openstreetmap.org/?lat=39.766882&lon=-78.246976
PA/usapa/pa.pa501.wpt: OldUS22 http://www.openstreetmap.org/?lat=40.474448&lon=-76.292021
PA/usapa/pa.pa643.wpt: OldRt126 http://www.openstreetmap.org/?lat=39.865875&lon=-78.245053
PA/usapa/pa.pa737.wpt: OldUS22 http://www.openstreetmap.org/?lat=40.578937&lon=-75.797497
PA/usapa/pa.pa819.wpt: OldRt119 http://www.openstreetmap.org/?lat=40.126268&lon=-79.549685
PA/usapa/pa.pa861.wpt: OldPA861 http://www.openstreetmap.org/?lat=41.017399&lon=-79.481988
PA/usapa/pa.pa863.wpt: OldUS22 http://www.openstreetmap.org/?lat=40.578256&lon=-75.707935
PA/usapa/pa.pa940.wpt: OldPA940 http://www.openstreetmap.org/?lat=41.109324&lon=-75.500174
PA/usausb/pa.us006bustun.wpt: OldPA92 http://www.openstreetmap.org/?lat=41.537816&lon=-75.937285
PA/usaus/pa.us006n.wpt: OldPA86 http://www.openstreetmap.org/?lat=41.889491&lon=-80.055361
PA/usaus/pa.us011.wpt: OldUS11 http://www.openstreetmap.org/?lat=41.895829&lon=-75.730664
PA/usaus/pa.us022.wpt: OldUS22 http://www.openstreetmap.org/?lat=40.432574&lon=-78.367227
PA/usaus/pa.us022.wpt: OldUS22_Tho http://www.openstreetmap.org/?lat=40.565329&lon=-77.171767
PA/usaus/pa.us022.wpt: OldRt22 http://www.openstreetmap.org/?lat=40.427657&lon=-76.459168
PA/usaus/pa.us030.wpt: OldRt30 http://www.openstreetmap.org/?lat=39.866964&lon=-77.318146
PA/usaus/pa.us119.wpt: OldUS119 http://www.openstreetmap.org/?lat=40.523615&lon=-79.160037
PA/usaus/pa.us322.wpt: OldUS322_W http://www.openstreetmap.org/?lat=41.475925&lon=-79.944098
PA/usaus/pa.us322.wpt: OldUS22_Tho http://www.openstreetmap.org/?lat=40.565329&lon=-77.171767




Too many words
grep -s . $rg/*/*.wpt | sed -e 's/ /%/' -e 's/\(.\+\)%.\+/\1/' | grep -v '[NPS]P$\|:[A-Z]*[a-z]*Mc[A-Z][A-Z][a-z]*$\|:Mc[A-Z][A-Z]\+[a-z]*[A-Z][a-z]*$\|:[A-Z]*Mc[A-Z]\+[a-z]\?$' | grep '[A-Z]\+[a-z]\+[A-Z]\+[a-z]\+[A-Z]\+[a-z]\+[A-Z]\+[a-z]*\|[A-Z]\+[a-z]\+[A-Z]\+[a-z]\+[A-Z]\+[a-z]\?[A-Z]\+[a-z]\+\|[A-Z]\+[a-z]\+[A-Z]\+[a-z]\?[A-Z]\+[a-z]\+[A-Z]\+[a-z]*\|[A-Z]\+[a-z]\?[A-Z]\+[a-z]\+[A-Z]\+[a-z]\+[A-Z]\+[a-z]*'
Intersections with named highways
Quote
MarKingBlvd MLKingBlvd
If the cross road name has more than 3 words, use one of two options:
1. Pick out the two most important words besides the road type and use only those: Martin Luther King Boulevard becomes MarKingBlvd. Three words in total are included in shortened form.
2. Pick out one important word besides the road type and use it and the initials of the other words: Martin Luther King Boulevard becomes MLKingBlvd. Two words in total are included in shortened form along with initials of the rest.
An older style for 3-words road names was to have Two truncated words & one initial. E.G., Lisbon Falls Village Rd -> LisFalVRd.
This was later deprecated in favor of the rule quoted above. LisFalRd, LFVilRd, etc.
PA/usapa/pa.pa026.wpt: SixMRunRd
PA/usapa/pa.pa026.wpt: StoCreRRd
PA/usapa/pa.pa036.wpt: BelMilCRd
PA/usapa/pa.pa038.wpt: NicKahLRd
PA/usapa/pa.pa042.wpt: OldEagMRd
PA/usapa/pa.pa044.wpt: LPineCreRd
PA/usapa/pa.pa044.wpt: LowPineBRd
PA/usapa/pa.pa046.wpt: OldNCreRd
PA/usapa/pa.pa046.wpt: SixMHolLn
PA/usapa/pa.pa054.wpt: BigMRunRd
PA/usapa/pa.pa054.wpt: YOldHauRd
PA/usapa/pa.pa073.wpt: NHanSquRd
PA/usapa/pa.pa074.wpt: IronStoHRd
PA/usapa/pa.pa077.wpt: ErieCouLRd
PA/usapa/pa.pa125.wpt: SweArrLRd
PA/usapa/pa.pa153.wpt: CleGRicHwy
PA/usapa/pa.pa166.wpt: RalNSalRd
PA/usapa/pa.pa168.wpt: WamMouARd
PA/usapa/pa.pa182.wpt: IndRDamRd_W
PA/usapa/pa.pa182.wpt: IndRDamRd_E
PA/usapa/pa.pa183.wpt: SweArrLRd
PA/usapa/pa.pa231.wpt: ClaTayRRd
PA/usapa/pa.pa241.wpt: OldMGreRd
PA/usapa/pa.pa259.wpt: GirlScoCRd
PA/usapa/pa.pa287.wpt: LPineCreRd
PA/usapa/pa.pa287.wpt: UBayCreRd
PA/usapa/pa.pa372.wpt: MPosOffRd
PA/usapa/pa.pa425.wpt: MouOChuRd
PA/usapa/pa.pa453.wpt: LitCleCRd
PA/usapa/pa.pa472.wpt: LitECreRd
PA/usapa/pa.pa504.wpt: OneMileRRd
PA/usapa/pa.pa551.wpt: WamMouARd
PA/usapa/pa.pa611.wpt: MarCBelHwy
PA/usapa/pa.pa655.wpt: MillCreHRd
PA/usapa/pa.pa660.wpt: StoForkSRd
PA/usapa/pa.pa664.wpt: LitPRunRd
PA/usapa/pa.pa731.wpt: McKGapRd_W
PA/usapa/pa.pa829.wpt: TroCreVRd
PA/usapa/pa.pa851.wpt: MouOChuRd
PA/usapa/pa.pa928.wpt: HeaAcrRRd
PA/usapa/pa.pa958.wpt: GraPriHRd
PA/usapa/pa.pa981.wpt: CalMamPRd
PA/usapa/pa.pa982.wpt: CalMamPRd
PA/usaus/pa.us019.wpt: KirGarFRd
PA/usaus/pa.us030.wpt: PotGarRRd
PA/usaus/pa.us030.wpt: LinWayMcC_W
PA/usaus/pa.us030.wpt: LinWayMcC_E
PA/usaus/pa.us040.wpt: ChaHOhiRd
PA/usaus/pa.us040.wpt: DinBOhiRd
PA/usaus/pa.us119.wpt: BelMilCRd
PA/usaus/pa.us220.wpt: MilESmiRd
PA/usaus/pa.us322.wpt: BigRPreRd
PA/usaus/pa.us422.wpt: HarBriERd
DE/usade/de.de054altbet.wpt: OldMillBRd
DE/usade/de.de071.wpt: OldSumBRd
DE/usade/de.de071.wpt: KirStGRd
DE/usade/de.de896.wpt: OldSumBRd




McDonRd
grep . $rg/*/*.wpt | sed -e 's/ /%/' -e 's/\(.\+\)%.\+/\1/' | grep 'Mc[A-Z][a-z]'
In the above search, the Mc[A-Z] tokens are included to filter out "Old McDonald Farm Rd" style false positives.
OTOH, McDonald is one word, so it makes sense to truncate it to McD, rather than treat it as 2 for McDon.
PA/usapa/pa.pa018.wpt: McCleRd
PA/usapa/pa.pa168.wpt: McCleRd




Tpke for Turnpike
grep -s Tpke $rg/*/*.wpt | sed -e 's/ /%/' -e 's/\(.\+\)%.\+/\1/' | grep 'Tpke'
CHM standardized on "Tpk" for turnpike, standard abbreviations notwithstanding...
PA/usapa/pa.pa054.wpt: ReaTpke
PA/usapa/pa.pa061.wpt: ReaTpke




Directional prefixes
grep '^[NEWS]' $rg/*/*.wpt | sed -e 's/ /%/' -e 's/\(.\+\)%.\+/\1/' | grep ':[NEWS]' | grep -v ":+\|:.[a-z]\|:[A-Z][A-Z]/[A-Z][A-Z]$\|$rg[0-9]\{1,3\}\|:[NEWS]End$"
Intersections with named highways
Quote
6thSt | 33rdAve | SeeLn
Ignore any non-essential direction specifier. N. 6th St becomes 6thSt. 33rd Avenue SW becomes 33rdAve. W. Seedy Lane becomes SeeLn.

NorPkwy | SouBlvd
But keep directions that are the main part of the road name, such as NorPkwy for Northern Parkway or SouBlvd for Southeast Boulevard.
What's a "non-essential direction specifier" and what are "directions that are the main part of the road name" can get wibbly-wobbly at times; use your best judgment. Many of these may be legit, but they're worth checking out. The SR#### examples may have visible road names they could be changed to.
IMO though, N/E/W/S are common enough abbreviations for their respective directions, and there are enough examples of this throughout the data, that I'm not going to call for every WPondRd to be changed to a WestPondRd.
PA/usapa/pa.pa018.wpt: WWRaiRd
PA/usapa/pa.pa029.wpt: SR2024/3023
PA/usapa/pa.pa044.wpt: SBraRd
PA/usapa/pa.pa073.wpt: NHanSquRd
PA/usapa/pa.pa075.wpt: SR3023
PA/usapa/pa.pa075.wpt: SR3013
PA/usapa/pa.pa414.wpt: WLerRd
PA/usapa/pa.pa487.wpt: SR1002_S
PA/usapa/pa.pa487.wpt: SR1002_N
PA/usapa/pa.pa512.wpt: ESt
PA/usapa/pa.pa706.wpt: SR3023
PA/usapa/pa.pa706.wpt: SR3029
PA/usapa/pa.pa729.wpt: WMCemRd
PA/usapa/pa.pa737.wpt: SRValRd
PA/usapa/pa.pa837.wpt: S10thSt
PA/usaus/pa.us006.wpt: WMainSt
PA/usaus/pa.us006.wpt: SR2010




Similarly, a search for suffixed directional specifiers:
grep '[NEWS]' $rg/*/*.wpt | sed -e 's/ /%/' -e 's/\(.\+\)%.\+/\1/' | grep '[NEWS]$' | grep -v ':+\|_\|[0-9]\{1,3\}[NEWS]$\|:[A-Z][A-Z]/[A-Z][A-Z]$\|:CR[A-Z]$\|:Rd[A-Z]$\|:Ave[A-Z]$\|:I\-[0-9]\{1,3\}BS$'
The only result, FriHillNHS, looks like a false positive.

Offline Markkos1992

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 645
  • Last Login:Today at 07:55:01 pm
Re: PA / DE: grepping for waypoint labels
« Reply #1 on: October 04, 2019, 05:10:41 pm »
Quote
An older style for 3-words road names was to have Two truncated words & one initial. E.G., Lisbon Falls Village Rd -> LisFalVRd.

I think this was how I was interpreting the rule.  Hence why quite a few of these popped up. 

I will look further into these once I finish the SC peer review.

In the meantime, I have just been using the phrase that the labels should be shortened when they are too long.

Offline dave1693

  • Jr. Member
  • **
  • Posts: 91
  • Last Login:October 15, 2019, 05:20:36 pm
Re: PA / DE: grepping for waypoint labels
« Reply #2 on: October 06, 2019, 10:34:35 pm »
Addressing specific items in my usual stomping grounds, to wit, intersections with Old US 22 between Allentown and Harrisburg, going east to west. Observations are from GSV.

PA 863: blade clearly shows "OLD 22"
PA 737: blade clearly shows "OLD ROUTE 22"
PA 143: blade at "PennSt_W" shows "PENN ST", blade at "OldUS22" shows "OLD ROUTE 22"
PA 183: blade clearly shows "Old 22"
PA 419: no blades at all at the intersection
PA 501: blade clearly shows "Old Route 22"

West of that, Old US 22 dead-ends before the next crossing highway.

Offline Markkos1992

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 645
  • Last Login:Today at 07:55:01 pm
Re: PA / DE: grepping for waypoint labels
« Reply #3 on: October 07, 2019, 04:08:15 pm »
Addressing specific items in my usual stomping grounds, to wit, intersections with Old US 22 between Allentown and Harrisburg, going east to west. Observations are from GSV.

PA 863: blade clearly shows "OLD 22"
PA 737: blade clearly shows "OLD ROUTE 22"
PA 143: blade at "PennSt_W" shows "PENN ST", blade at "OldUS22" shows "OLD ROUTE 22"
PA 183: blade clearly shows "Old 22"
PA 419: no blades at all at the intersection
PA 501: blade clearly shows "Old Route 22"

West of that, Old US 22 dead-ends before the next crossing highway.


I believe I decided at some point to use OldUS22, OldPA86, etc. based on the old designation being mentioned even with the blades maybe saying "ROUTE".

PennSt_W is correct because PA 143 is Penn St in Lenhartsville along Old US 22.

Offline dave1693

  • Jr. Member
  • **
  • Posts: 91
  • Last Login:October 15, 2019, 05:20:36 pm
Re: PA / DE: grepping for waypoint labels
« Reply #4 on: October 07, 2019, 05:00:17 pm »
PA 143: blade at "PennSt_W" shows "PENN ST", blade at "OldUS22" shows "OLD ROUTE 22"
I believe I decided at some point to use OldUS22, OldPA86, etc. based on the old designation being mentioned even with the blades maybe saying "ROUTE".
PennSt_W is correct because PA 143 is Penn St in Lenhartsville along Old US 22.

Might be more accurate to say that in the western 2/3 of Lenhartsville borough, Old US 22 is Penn St. East of the Deitsch Eck, Penn St forks off to the north from Old Route 22, crosses the creek by a separate bridge (currently out), and rejoins Old Route 22 east of where PA 143 forks off to the south.

Basically, GSV supports all the labels in that region as currently configured.

Offline Markkos1992

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 645
  • Last Login:Today at 07:55:01 pm
Re: PA / DE: grepping for waypoint labels
« Reply #5 on: October 12, 2019, 07:21:37 pm »
The DE label revisions have been completed.

https://github.com/TravelMapping/HighwayData/pull/3223

The PA label revisions will be done via a separate pull request.

Offline Markkos1992

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 645
  • Last Login:Today at 07:55:01 pm
Re: PA / DE: grepping for waypoint labels
« Reply #6 on: October 13, 2019, 09:34:46 pm »
Pull Request for PA routes that I have fully worked on:  https://github.com/TravelMapping/HighwayData/pull/3227

I also included US 322 as one of its points with US 22 was directly affected. 

The other routes will be done as I look at them fully.

My progress will be shown in this linked Google Doc.

PA 31 and PA 819 Edits: https://github.com/TravelMapping/HighwayData/pull/3242
« Last Edit: Yesterday at 11:06:04 pm by Markkos1992 »