Travel Mapping

Highway Data Discussion => Updates to Highway Data => Solved Highway data updates => Topic started by: gpw on October 25, 2021, 10:10:34 pm

Title: ID US2/95 Broken Concurrency
Post by: gpw on October 25, 2021, 10:10:34 pm

Just north of Sandpoint, Idaho, US95 has a visible point (KooCutRd) that US2 does not.

-GPW

Title: Re: ID US2/95 Broken Concurrency
Post by: oscar on October 26, 2021, 02:16:02 am

There seem to be several other waypoints between the northern and southern junctions of US 2 with US 95 where the coordinates in the US 2 file don't match the ones in the US 95 file. Those mismatches create additional broken concurrencies.

Title: Re: ID US2/95 Broken Concurrency
Post by: compdude787 on October 26, 2021, 06:08:39 pm

Oops...I made some changes to US 95 in northern Idaho awhile back and completely forgot to apply these changes to US 2 where it's concurrent with US 95.

I'll work on this tonight when I'm home from work.

Title: Re: ID US2/95 Broken Concurrency
Post by: compdude787 on October 26, 2021, 10:37:37 pm

Fixed:

https://github.com/TravelMapping/HighwayData/pull/5255

Title: Re: ID US2/95 Broken Concurrency
Post by: Markkos1992 on October 27, 2021, 06:51:52 am

I did notice that NorLodHRd needs to be shortened on both routes as part of the following rule in the manual.  (https://travelmapping.net/devel/manual/wayptlabels.php#truncate)

Quote

If the cross road name has more than 3 words, use one of three options:
1. Pick out the two most important words besides the road type and use only those: Martin Luther King Boulevard becomes MarKingBlvd. Three words in total are included in shortened form.
2. Pick out one important word besides the road type and use it and the initials of the other words: Martin Luther King Boulevard becomes MLKingBlvd. Two words in total are included in shortened form along with initials of the rest.
3. Use initials only besides the road type: Martin Luther King Boulevard becomes MLKBlvd, University of California Santa Barbara Boulevard becomes UCSBBlvd.

Title: Re: ID US2/95 Broken Concurrency
Post by: compdude787 on May 12, 2022, 12:45:34 am

Finally got around to fixing this:
https://github.com/TravelMapping/HighwayData/pull/5772

Title: Re: ID US2/95 Broken Concurrency
Post by: Markkos1992 on May 12, 2022, 07:20:08 pm

Quote from: compdude787 on May 12, 2022, 12:45:34 am

Finally got around to fixing this:
https://github.com/TravelMapping/HighwayData/pull/5772

That is odd.  I do not see any files changed in the pull request...

Title: Re: ID US2/95 Broken Concurrency
Post by: compdude787 on May 13, 2022, 01:13:52 am

Not sure why it did that. I could have sworn it was pulling from my patch-1 repository, but no, it decided to pull from my master repository.  ::)

Here's the actual pull request. https://github.com/TravelMapping/HighwayData/pull/5775

Title: Re: ID US2/95 Broken Concurrency
Post by: rickmastfan67 on May 13, 2022, 02:39:00 am

Quote from: compdude787 on May 13, 2022, 01:13:52 am

Not sure why it did that. I could have sworn it was pulling from my patch-1 repository, but no, it decided to pull from my master repository.  ::)

Here's the actual pull request. https://github.com/TravelMapping/HighwayData/pull/5775

Honestly, this is why I edit files on my PC, and just create a separate branch on the main TM directory when updating.  Don't have to worry about phantom edits that way. lol.

Title: Re: ID US2/95 Broken Concurrency
Post by: Markkos1992 on May 13, 2022, 05:55:56 am

I have been using the "Fetch Upstream" function lately whenever I am updating a branch, and it has helped immensely since I can do that now without creating new patches and stuff.