Author Topic: NC: US-15/401/501 offset point issues  (Read 1736 times)

0 Members and 1 Guest are viewing this topic.

Offline rickmastfan67

  • TM Collaborator (A)
  • Hero Member
  • *****
  • Posts: 1829
  • Gender: Male
  • Last Login:Today at 06:11:34 am
NC: US-15/401/501 offset point issues
« on: December 30, 2020, 02:15:51 am »
US-15:
US15Bus_S --- offset a good distance from the intersection.  Needs to be recentered.  Also affect US401, US15BusLau, & US401BusLau.  Could also be renamed as well in both US-15 & US-401's files to US15/401Bus.
NC144 --- this needs to be recentered, as they build a brand new roundabout to the north of the original intersection.  This will also effect US501 & NC144.

US-401:
US401BusLau -> US401BusLau_N --- Also needs to be recentered too. Would affect US401BusLau as well.

Offline mapmikey

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 1171
  • Last Login:Today at 06:18:24 am
    • Co-curator Virginia Highways Project
Re: NC: US-15/401/501 offset point issues
« Reply #1 on: February 04, 2021, 08:43:52 pm »
fixed and in the queue

Offline Markkos1992

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 3075
  • Last Login:Today at 08:37:39 am
Re: NC: US-15/401/501 offset point issues
« Reply #2 on: February 06, 2021, 01:05:44 pm »
It looks like the US 15 label is now just "US" instead of US15/401Bus.

Offline rickmastfan67

  • TM Collaborator (A)
  • Hero Member
  • *****
  • Posts: 1829
  • Gender: Male
  • Last Login:Today at 06:11:34 am
Re: NC: US-15/401/501 offset point issues
« Reply #3 on: February 06, 2021, 02:29:52 pm »
It looks like the US 15 label is now just "US" instead of US15/401Bus.

Plus I don't think the point is in the correct place.  IMO, it should be at the traffic light.

Offline Markkos1992

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 3075
  • Last Login:Today at 08:37:39 am
Re: NC: US-15/401/501 offset point issues
« Reply #4 on: February 06, 2021, 02:47:12 pm »
Actually the issue is that the line ended up being  "US +15/401Bus +US15Bus_S".  So "15/401Bus" is now a hidden alternate label under "US".

Offline rickmastfan67

  • TM Collaborator (A)
  • Hero Member
  • *****
  • Posts: 1829
  • Gender: Male
  • Last Login:Today at 06:11:34 am
Re: NC: US-15/401/501 offset point issues
« Reply #5 on: February 06, 2021, 03:32:38 pm »
Actually the issue is that the line ended up being  "US +15/401Bus +US15Bus_S".  So "15/401Bus" is now a hidden alternate label under "US".

I know.  That's why I said 'plus'.

Offline mapmikey

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 1171
  • Last Login:Today at 06:18:24 am
    • Co-curator Virginia Highways Project
Re: NC: US-15/401/501 offset point issues
« Reply #6 on: February 09, 2021, 05:09:38 pm »
fixed the error

Offline Markkos1992

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 3075
  • Last Login:Today at 08:37:39 am
Re: NC: US-15/401/501 offset point issues
« Reply #7 on: February 28, 2021, 04:12:25 pm »
I want to note here that the use of US15/401Bus created a self-reference error for US 15.  I presume that we will just consider it a FP, but I did want to note that.

EDIT (3-2-2021):  https://github.com/TravelMapping/HighwayData/pull/4592 (added FP)
« Last Edit: March 02, 2021, 01:56:41 pm by Markkos1992 »

Offline yakra

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 4234
  • Last Login:February 13, 2024, 07:19:36 pm
  • I like C++
Re: NC: US-15/401/501 offset point issues
« Reply #8 on: March 02, 2021, 04:30:28 pm »
I want to note here that the use of US15/401Bus created a self-reference error for US 15.  I presume that we will just consider it a FP, but I did want to note that.
Overall, LABEL_SELFREF needs some attention...
What we have here is (US15/401)(Bus) rather than (US15)/(401Bus).
There are a lot of these cases in HighwayData; it makes sense to continue to allow them, and not force a bunch of conversions to US15Bus/401Bus.
Perhaps in the future, these could be detected and not flagged, and we won't have to worry about marking the FPs.
https://github.com/TravelMapping/DataProcessing/issues/420

As an aside, I dislike the ambiguity in US15/401Bus style on the one hand and the lack of brevity in US15Bus/401Bus on the other (still think they should be allowed though), and resolve these cases by just going with US15Bus.
« Last Edit: March 02, 2021, 04:36:17 pm by yakra »
Sri Syadasti Syadavaktavya Syadasti Syannasti Syadasti Cavaktavyasca Syadasti Syannasti Syadavatavyasca Syadasti Syannasti Syadavaktavyasca