Author Topic: How can I get started on editing the project?  (Read 30918 times)

0 Members and 1 Guest are viewing this topic.

Offline neroute2

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 1129
  • Last Login:Today at 04:29:43 am
How can I get started on editing the project?
« on: August 23, 2019, 01:40:37 pm »
I'd like to start improving Mexican coverage, towards which I've been slowly working on a list. How do I edit files on the project (nobody controls Mexico)? I've seen mention of a waypoint editor; where is this?

Offline michih

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 4809
  • Last Login:Today at 11:19:28 am
Re: How can I get started on editing the project?
« Reply #1 on: August 23, 2019, 03:08:40 pm »
You can find all tools here: http://travelmapping.net/devel/tools.php It's linked in the footer.
The most important tool is the wpt editor: http://travelmapping.net/wptedit/

Mexico does currently not have a maintainer. Feel free to work on drafting new wpt files but be careful with active systems.
You need to be familar with Github hwy data repository, are you?

Offline neroute2

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 1129
  • Last Login:Today at 04:29:43 am
Re: How can I get started on editing the project?
« Reply #2 on: August 23, 2019, 04:29:32 pm »
Mexico does currently not have a maintainer. Feel free to work on drafting new wpt files but be careful with active systems.
You need to be familar with Github hwy data repository, are you?
I think I successfully submitted a simple pull request: https://github.com/TravelMapping/HighwayData/pull/3072


Is there any way to import the waypoint list into the editor, or do you have to copy/paste from github?
« Last Edit: August 23, 2019, 04:33:49 pm by neroute2 »

Offline mapcat

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 1746
  • Last Login:Yesterday at 09:50:56 pm
Re: How can I get started on editing the project?
« Reply #3 on: August 23, 2019, 04:55:16 pm »
The edit looks okay, as does the pull request. In the future you'll want to give the pull request a more descriptive title, of course.

The editor is not set up to import any files afaik. Just copy-paste into the edit window (and into the in-use labels box, if you're considering changing the name of a waypoint).
Clinched:

Offline neroute2

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 1129
  • Last Login:Today at 04:29:43 am
Re: How can I get started on editing the project?
« Reply #4 on: August 23, 2019, 05:25:10 pm »
Is there a new URL for the manual? http://cmap.m-plex.com/tools/manual.php doesn't work and isn't archived.

Offline michih

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 4809
  • Last Login:Today at 11:19:28 am
Re: How can I get started on editing the project?
« Reply #5 on: August 24, 2019, 05:45:57 am »
The old manual is gone for good. @yakra might still have a copy - on a broken drive?

Jim has requested a review of your first modifications. I've checked 2D so far, see my comments  @ https://github.com/TravelMapping/HighwayData/pull/3074

Offline neroute2

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 1129
  • Last Login:Today at 04:29:43 am
Re: How can I get started on editing the project?
« Reply #6 on: August 24, 2019, 09:05:41 am »
I replied to 2D.

Offline yakra

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 4354
  • Last Login:Today at 10:05:00 am
  • I like C++
Re: How can I get started on editing the project?
« Reply #7 on: August 24, 2019, 09:50:40 am »
(and into the in-use labels box, if you're considering changing the name of a waypoint).
http://travelmapping.net/logs/pointsinuse.log
Sri Syadasti Syadavaktavya Syadasti Syannasti Syadasti Cavaktavyasca Syadasti Syannasti Syadavatavyasca Syadasti Syannasti Syadavaktavyasca

Offline yakra

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 4354
  • Last Login:Today at 10:05:00 am
  • I like C++
Re: How can I get started on editing the project?
« Reply #8 on: August 24, 2019, 11:55:40 pm »
The old manual is gone for good. @yakra might still have a copy - on a broken drive?
Found a copy right here on my main desktop, in an out-of-the-way place I didn't expect to look at first. I'll fix some of the links up to not point to cmap.m-plex.com, and then put it online.

Edit: http://yakra.teresco.org/manual/manual.html
It's chock full of outdated info, but it's a start. Better than having all this just disappear on us.

I'll see about updating some of the info there. Maybe. ;)
« Last Edit: August 25, 2019, 12:42:55 am by yakra »
Sri Syadasti Syadavaktavya Syadasti Syannasti Syadasti Cavaktavyasca Syadasti Syannasti Syadavatavyasca Syadasti Syannasti Syadavaktavyasca

Offline neroute2

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 1129
  • Last Login:Today at 04:29:43 am
Re: How can I get started on editing the project?
« Reply #9 on: September 15, 2019, 03:03:54 pm »
I think I've taken care of all the objections for https://github.com/TravelMapping/HighwayData/pull/3073 and https://github.com/TravelMapping/HighwayData/pull/3074. Is there anything else I can do?

Offline yakra

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 4354
  • Last Login:Today at 10:05:00 am
  • I like C++
Re: How can I get started on editing the project?
« Reply #10 on: September 16, 2019, 01:42:42 am »
I'm setting aside sometime on Tuesday to have a detailed look at the pull requests.
Sri Syadasti Syadavaktavya Syadasti Syannasti Syadasti Cavaktavyasca Syadasti Syannasti Syadavatavyasca Syadasti Syannasti Syadavaktavyasca

Offline neroute2

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 1129
  • Last Login:Today at 04:29:43 am
Re: How can I get started on editing the project?
« Reply #11 on: September 16, 2019, 08:38:48 am »
I'm setting aside sometime on Tuesday to have a detailed look at the pull requests.
Thanks :)

Offline neroute2

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 1129
  • Last Login:Today at 04:29:43 am
Re: How can I get started on editing the project?
« Reply #12 on: November 01, 2019, 12:16:58 pm »
Would it make sense to demote mexd and mexed back to preview? I have so many corrections that I'm sitting on because there's apparently no process for updating an active unmaintained system in a timely manner.

Offline Jim

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 2846
  • Last Login:Today at 11:13:35 am
Re: How can I get started on editing the project?
« Reply #13 on: November 01, 2019, 04:13:56 pm »
Would it make sense to demote mexd and mexed back to preview? I have so many corrections that I'm sitting on because there's apparently no process for updating an active unmaintained system in a timely manner.

Related to this, it looks like only 18 travelers claim any segments anywhere in Mexico, and only a handful of places have any segments with more than a traveler or two.  Most segments are untraveled.  To me, this means more flexibility in updating even in an active system.  It's not surprising so many changes are needed given how long those systems have sat with little if any maintenance and that their implementation predates some of our current tools and guidelines.

Offline michih

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 4809
  • Last Login:Today at 11:19:28 am
Re: How can I get started on editing the project?
« Reply #14 on: November 14, 2019, 04:23:53 am »
Would it make sense to demote mexd and mexed back to preview? I have so many corrections that I'm sitting on because there's apparently no process for updating an active unmaintained system in a timely manner.

We could do it similar to the split of France. Make a new system first, e.g. mexdr and nexedr. We could test it on the 2nd instance tmtest.teresco.org first. When going live, we could just add entries to system updates like we did for France: mexd re-entered and mexed re-entered.

I think you could close your pending pull requests to mexd routes and start revising the whole system with a new pull request instead.

Just wait one or two days whether there is any objection.

Let me know whether we should merge the Mexican threads. I think one for the revision and development for the next systems should be enough.

btw: mexdfeje system name should be shortened, e.g. mexe or mexme
« Last Edit: November 14, 2019, 04:27:53 am by michih »