Author Topic: Failed site update 09-17  (Read 483 times)

0 Members and 1 Guest are viewing this topic.

Offline si404

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 1711
  • Last Login:Today at 05:44:11 am
Failed site update 09-17
« on: September 17, 2022, 04:25:14 am »
Last night's update failed.

I've fixed the error (the new spur in Missouri's file name in the .csvs was 'mo.mo112sprvie' in a copy-paste-edit error, as it should have been 'mo.mo028sprvie' with 'mo.mo112sprroa' being removed).

If the update is run again, it will work (I've run datacheck.sh on it)

Offline Jim

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 2451
  • Last Login:Yesterday at 10:11:24 pm
Re: Failed site update 09-17
« Reply #1 on: September 17, 2022, 10:16:38 am »
Thanks, re-running now.  That was my mistake, I didn't use the updated CSV files that Highway63 sent because they didn't have the standard header line and I made a copy-paste error.

Offline Highway63

  • TM Collaborator
  • Sr. Member
  • *****
  • Posts: 467
  • Gender: Female
  • Last Login:November 18, 2022, 11:50:01 pm
Re: Failed site update 09-17
« Reply #2 on: October 18, 2022, 11:38:46 pm »
I see where I made the typo but apparently I am missing something else.

I seem to recall being told, way long ago, that the first line in the plain CSV file did not matter. I thought it was a perfect place to park a "last modified" message. Now, in the first line of the usamo_con.csv, I have this header, which IS supposed to be standardized:

Quote
systemName;route;banner;groupName;roots

If the first line in the state csv header (usamo.csv) IS supposed to be standard, what is it? Or is it just my copy and paste typo that screwed things up?

Offline yakra

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 3935
  • Last Login:Today at 10:12:30 am
Re: Failed site update 09-17
« Reply #3 on: October 19, 2022, 10:17:43 am »
The first .csv line is ignored, and a "last modified" message should not cause problems.
I haven't looked at the file in question, but I believe it'd just be the copy-paste typo that screwed things up.
Sri Syadasti Syadavaktavya Syadasti Syannasti Syadasti Cavaktavyasca Syadasti Syannasti Syadavatavyasca Syadasti Syannasti Syadavaktavyasca

Offline michih

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 3879
  • Last Login:Yesterday at 03:31:33 pm
Re: Failed site update 09-17
« Reply #4 on: October 19, 2022, 02:40:02 pm »
@yakra:

That was my mistake, I didn't use the updated CSV files that Highway63 sent because they didn't have the standard header line and I made a copy-paste error.

Offline yakra

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 3935
  • Last Login:Today at 10:12:30 am
Re: Failed site update 09-17
« Reply #5 on: October 19, 2022, 10:28:47 pm »
Jim's typo then, not Highway63's. :)
I assume Jim just chose to not use that file for the sake of uniformity of the headers, but header lines are indeed ignored:
https://github.com/TravelMapping/DataProcessing/blob/1e7d3ef1c544a1ba2297f0ee17b606414bd79a91/siteupdate/python-teresco/siteupdate.py#L1338-L1359
Sri Syadasti Syadavaktavya Syadasti Syannasti Syadasti Cavaktavyasca Syadasti Syannasti Syadavatavyasca Syadasti Syannasti Syadavaktavyasca

Offline Jim

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 2451
  • Last Login:Yesterday at 10:11:24 pm
Re: Failed site update 09-17
« Reply #6 on: October 19, 2022, 11:09:59 pm »
Yes, my error.

As far as what's in the header line, I like having the field names there as that's kind of the standard format for CSVs.  Plus, we have git history to give us versions and timestamps.  But I don't care enough about that to force anyone to have files they're responsible for to conform to what I prefer.