Author Topic: Two bugs: route page % clinched by segment  (Read 5385 times)

0 Members and 1 Guest are viewing this topic.

Offline si404

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 1620
  • Last Login:Today at 06:41:02 pm
Re: Two bugs: route page % clinched by segment
« Reply #15 on: April 27, 2021, 10:00:38 am »
I agree with compdude.  There is no reason for this to track percentages for all users because someone like michih, who has a slim chance of traveling most routes in the US, gets tracked if doing all users just like all of us in the US.
And vice versa.

33 users have travelled this (one of the highest in Europe), which is over 10%, but the highest segment is 8.8%. I'm not doing the maths to work out how many that is (27 via a different route to find out).

Arguably a number would be better than a percentage for the segment totals.

Offline mapcat

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 1350
  • Last Login:Today at 08:48:39 pm
Re: Two bugs: route page % clinched by segment
« Reply #16 on: April 27, 2021, 03:47:21 pm »
Arguably a number would be better than a percentage for the segment totals.

Agreed. Plus, this would be consistent with how the data appear in mapview.
Clinched:

Offline andrepoiy

  • Newbie
  • *
  • Posts: 28
  • Gender: Male
  • Last Login:Today at 07:41:39 pm
Re: Two bugs: route page % clinched by segment
« Reply #17 on: April 27, 2021, 04:26:22 pm »
I agree. I thought that it was strange that it was only like 1% when I was the only one that travelled on a certain route.

Offline compdude787

  • TM Collaborator
  • Sr. Member
  • *****
  • Posts: 290
  • Gender: Male
  • Last Login:June 17, 2022, 12:07:01 pm
Re: Two bugs: route page % clinched by segment
« Reply #18 on: April 27, 2021, 05:17:12 pm »
Arguably a number would be better than a percentage for the segment totals.

Agreed. Plus, this would be consistent with how the data appear in mapview.

Yeah, I actually like the idea of having a number rather than a percentage.

Offline vdeane

  • Sr. Member
  • ****
  • Posts: 323
  • Gender: Female
  • Last Login:Today at 09:22:32 pm
    • New York State Roads
Re: Two bugs: route page % clinched by segment
« Reply #19 on: May 01, 2021, 06:49:09 pm »
What does having only a number give us that percent of users who traveled on a given route doesn't?  I would think the percentage would be more useful - it just needs to be put back on the metric that makes sense.  If you want a number, then maybe list both, but I know I'm more interested in the percentage.  I don't really care about the raw number.
Please note: All comments here represent my own personal opinion and do not reflect the official position of NYSDOT or its affiliates.

Offline michih

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 3529
  • Last Login:Today at 01:41:21 pm
Re: Two bugs: route page % clinched by segment
« Reply #20 on: May 02, 2021, 02:30:55 am »
What does having only a number give us that percent of users who traveled on a given route doesn't?

A number is clear. No room for interpretation. With percentage you always need to know the base, i.e. what does 100% mean?

Offline yakra

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 3846
  • Last Login:Today at 08:46:15 pm
Re: Two bugs: route page % clinched by segment
« Reply #21 on: May 02, 2021, 08:55:15 am »
A number is clear. No room for interpretation. With percentage you always need to know the base, i.e. what does 100% mean?
That number is also displayed in the HB, so we can make the calculation.
Sri Syadasti Syadavaktavya Syadasti Syannasti Syadasti Cavaktavyasca Syadasti Syannasti Syadavatavyasca Syadasti Syannasti Syadavaktavyasca

Offline Jim

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 2343
  • Last Login:Today at 09:52:12 pm
Re: Two bugs: route page % clinched by segment
« Reply #22 on: May 02, 2021, 04:24:47 pm »
Looking for opinions about what I have on tmstage.teresco.org (and testing of it to make sure it looks correct now).

Online Markkos1992

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 2423
  • Last Login:Today at 10:07:25 pm
Re: Two bugs: route page % clinched by segment
« Reply #23 on: May 02, 2021, 05:06:16 pm »
Looks fine, but oddly enough, you see it on the connected route page for I-95, but not on the DE I-95 page.  I am not sure how we rectify that though.

EDIT:  Never mind, it must have been straightened out already...

« Last Edit: May 02, 2021, 06:33:59 pm by Jim »

Offline yakra

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 3846
  • Last Login:Today at 08:46:15 pm
Re: Two bugs: route page % clinched by segment
« Reply #24 on: May 02, 2021, 05:45:13 pm »
Looking for opinions about what I have on tmstage.teresco.org (and testing of it to make sure it looks correct now).
I like it. Provides both the raw # & %age, without taking up any more real estate.
Sri Syadasti Syadavaktavya Syadasti Syannasti Syadasti Cavaktavyasca Syadasti Syannasti Syadavatavyasca Syadasti Syannasti Syadavaktavyasca

Offline si404

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 1620
  • Last Login:Today at 06:41:02 pm
Re: Two bugs: route page % clinched by segment
« Reply #25 on: May 02, 2021, 05:57:36 pm »
It's a like from me!

Offline andrepoiy

  • Newbie
  • *
  • Posts: 28
  • Gender: Male
  • Last Login:Today at 07:41:39 pm
Re: Two bugs: route page % clinched by segment
« Reply #26 on: May 02, 2021, 06:30:51 pm »
Is it just me or are the colours still a bit off? For example, ON427 at QEW is still a yellow despite the percentage being 96%

Offline Jim

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 2343
  • Last Login:Today at 09:52:12 pm
Re: Two bugs: route page % clinched by segment
« Reply #27 on: May 02, 2021, 06:34:30 pm »
Looks fine, but oddly enough, you see it on the connected route page for I-95, but not on the DE I-95 page.  I am not sure how we rectify that though.

EDIT:  Never mind, it must have been straightened out already...

Looks like I've got a race condition in there.  I wasn't happy with my solution anyway but thought it was just a little inelegant.  Turns out it's just broken.  Hope to get another look at it before too long.  Big pile of grading awaits first.

Offline compdude787

  • TM Collaborator
  • Sr. Member
  • *****
  • Posts: 290
  • Gender: Male
  • Last Login:June 17, 2022, 12:07:01 pm
Re: Two bugs: route page % clinched by segment
« Reply #28 on: May 03, 2021, 01:56:30 pm »
Looks good to me.

Offline michih

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 3529
  • Last Login:Today at 01:41:21 pm
Re: Two bugs: route page % clinched by segment
« Reply #29 on: May 03, 2021, 01:56:59 pm »
The info text could be improved.