Author Topic: Japan: National Highways 一般国道 system  (Read 2765 times)

0 Members and 1 Guest are viewing this topic.

Offline michih

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 3550
  • Last Login:Today at 12:37:44 am
Re: Japan: National Highways 一般国道 system
« Reply #45 on: June 06, 2022, 08:49:49 am »
There are 564 pairs of near-miss-points to be checked if the wp coords need be synched (I had a quick look into it, and all I checked need to be synced) or marked FP: https://courses.teresco.org/metal/hdx/?load=jpn.nmp

I recommend synching the coords now but only mark the FPs on activation.

Offline Jim

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 2356
  • Last Login:Yesterday at 10:58:36 pm
Re: Japan: National Highways 一般国道 system
« Reply #46 on: June 06, 2022, 09:44:37 am »
Regarding keeping intersection points aligned, I know everyone has their own methods.  When I used to draft highway systems for CHM and during the early days of TM, I would always start the drafting of a new route by bringing in all of the points from existing routes that intersect (grep is your friend), line those up, then fill in the other needed points in the WPT editor.  I found that it saved time while drafting and prevented nearly all non-FP NMPs.

Offline yakra

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 3853
  • Last Login:Today at 12:31:06 am
Re: Japan: National Highways 一般国道 system
« Reply #47 on: June 06, 2022, 10:43:50 am »
Japan's datacheck errors can be seen at https://travelmapping.net/devel/datacheck.php?rg=JPN

VISIBLE_DISTANCE cases are handled a bit differently...
These are often false positives, and aren't reported once the relevant systems are promoted to active. So there's no need to mark them FP; just add intermediate points to fix the ones you can.
It may help to filter them out, address the other errors first, and then come back to these last.



N57BypKit needs a couple shaping points. Recommend:
Code: [Select]
N57 http://www.openstreetmap.org/?lat=32.921039&lon=131.000077
+X840372 http://www.openstreetmap.org/?lat=32.924118&lon=130.987541
P23 http://www.openstreetmap.org/?lat=32.915810&lon=130.981731
OtsHig http://www.openstreetmap.org/?lat=32.899815&lon=130.929381
+X767139 http://www.openstreetmap.org/?lat=32.896153&lon=130.896277
P339 http://www.openstreetmap.org/?lat=32.887664&lon=130.896727
Sri Syadasti Syadavaktavya Syadasti Syannasti Syadasti Cavaktavyasca Syadasti Syannasti Syadavatavyasca Syadasti Syannasti Syadavaktavyasca

Offline michih

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 3550
  • Last Login:Today at 12:37:44 am
Re: Japan: National Highways 一般国道 system
« Reply #48 on: June 06, 2022, 11:02:40 am »
It may help to filter them out, address the other errors first, and then come back to these last.

The errors highlighted in red are more important, especially Duplicate_Label. Hidden_Junction are usually in combination with NMPs. Dealing with NMPs (on HDX) is likely easier than trying to find the error with HB (opened with datacheck link).

Offline nezinscot

  • TM Collaborator
  • Jr. Member
  • *****
  • Posts: 88
  • Last Login:June 26, 2022, 08:46:26 pm
Re: Japan: National Highways 一般国道 system
« Reply #49 on: June 06, 2022, 08:08:49 pm »
Thanks for all the suggestions.  I'm currently in the puckerbrush in rural Maine and have intermittent web access.  I'll be home tomorrow and can start working on these issues then.

FYI all Japan national highways are now in jpnh.  The system files for the temporary systems should be deleted by today's submission.  I needed to use Github Desktop to do the bulk moves.  Have you found it useful for other tasks?

Offline michih

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 3550
  • Last Login:Today at 12:37:44 am
Re: Japan: National Highways 一般国道 system
« Reply #50 on: June 07, 2022, 02:17:43 am »
I needed to use Github Desktop to do the bulk moves.  Have you found it useful for other tasks?

I always use Github Desktop because I always open all (sometimes up to 1,000) relevant files to pick up wp coords to avoid NMPs.

Offline Jim

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 2356
  • Last Login:Yesterday at 10:58:36 pm
Re: Japan: National Highways 一般国道 system
« Reply #51 on: June 07, 2022, 08:09:58 pm »
Not sure if you're aware or if they might be of any use, but there are .wpt files generated by each site update that line up all NMPs.  Unfortunately that would include (unmarked only? I'd have to check) FPs.  They can be found on the server in /home/www/tm/nmp_merged or on the web under https://travelmapping.net/nmp_merged/

Offline nezinscot

  • TM Collaborator
  • Jr. Member
  • *****
  • Posts: 88
  • Last Login:June 26, 2022, 08:46:26 pm
Re: Japan: National Highways 一般国道 system
« Reply #52 on: June 24, 2022, 04:51:53 pm »
All the data errors and NMPs for Japan systems have been fixed or marked as FPs.  I also have done a first pass at checking concurrencies.

I just uploaded an SVG file for the jpnh system.  I have a few questions about how the shields directory is used.
-- How do these SVG files get chosen for use? Is it based on the file name, in this case template_jpnh.svg.
-- How can I add another font?  The svg file should probably be using IPAGothic, a free Japanese sans-serif font.
-- The roads in the jpntk system have separate shields for each city network.  I did see shields unique to one road, but is it possible to have a shield shared by some but not all of a system?
-- The jpne system could use a simple shared shield, or for each expressway have much more complicated separate shields that list the road name.  Which would be the better choice?

Because of their shape, national highway shields are known colloquially as onigiri - meaning rice ball.

« Last Edit: June 24, 2022, 05:03:32 pm by nezinscot »

Offline michih

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 3550
  • Last Login:Today at 12:37:44 am
Re: Japan: National Highways 一般国道 system
« Reply #53 on: June 25, 2022, 06:10:49 am »
I just uploaded an SVG file for the jpnh system.  I have a few questions about how the shields directory is used.
-- How do these SVG files get chosen for use? Is it based on the file name, in this case template_jpnh.svg.

Thanks :) If memory serves*, you need to call the svg file from https://github.com/TravelMapping/Web/blob/master/shields/shieldgen.php

@the-spui-ninja (or @rschen7754?) might help you if you need support.

*I dealt with it in 2016/17 but don't remember details. I think that the code was reworked meanwhile?!?

Offline michih

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 3550
  • Last Login:Today at 12:37:44 am
Re: Japan: National Highways 一般国道 system
« Reply #54 on: June 25, 2022, 06:15:37 am »
No, it is loaded automatically but most shields require a special treatment.

Offline nezinscot

  • TM Collaborator
  • Jr. Member
  • *****
  • Posts: 88
  • Last Login:June 26, 2022, 08:46:26 pm
Re: Japan: National Highways 一般国道 system
« Reply #55 on: June 25, 2022, 06:53:41 am »
I looked at shieldgen.php and it looks pretty easy to add a case for jpnh.  All I need to do is strip out the N prefix.

        case 'jpnh':
            $routeNum = str_replace("N", "", $row['route']);
            $svg = str_replace("***NUMBER***", $routeNum, $svg);
            break;

I'm leery of adding it to the code for
        case 'alakt':
        case 'alavt':
        case 'canmbw': .....
because I don't know if any of those cases have an N in prefixes.
       
Looking at shieldgen answered my question about the jpntk system having separate shields for each city network.  It should be possible by adding a separate case for jpntk that determines the city network being processed.

Offline Jim

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 2356
  • Last Login:Yesterday at 10:58:36 pm
Re: Japan: National Highways 一般国道 system
« Reply #56 on: June 25, 2022, 08:45:53 am »
Thanks for working on the Japan shields.  Instead of pulling into the master branch of the repository, I've pulled your work so far into a branch named jpnshields.  I've installed what's there on tmdevel, for example:

https://tmdevel.teresco.org/hb/showroute.php?units=miles&u=terescoj&r=jpn.n002

It looks like we're on the right track, but something's not quite right.

I might be able to take a look a little later today, but please feel free to investigate and submit another PR (to that branch, if you can) and I can put it on tmdevel to try it out.

Offline michih

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 3550
  • Last Login:Today at 12:37:44 am
Re: Japan: National Highways 一般国道 system
« Reply #57 on: June 25, 2022, 09:05:18 am »
The shields don't appear on https://tmdevel.teresco.org/shields/clinched.php?units=miles&u=nagamasa&cort=traveled (I've selected a traveler with jpnh travels)

chlinched.php might help to see more shields at the same time to validate if changes work.

I never had to do anything to make the shields visible there.

Offline Jim

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 2356
  • Last Login:Yesterday at 10:58:36 pm
Re: Japan: National Highways 一般国道 system
« Reply #58 on: June 25, 2022, 09:56:30 am »
@nezinscot if you'd like to be able to experiment and are comfortable with working your way around the Unix command line and transferring files, I can set up a development server where you can try things out.  Send me a direct message here or email me if you'd like to go in that direction.

Offline nezinscot

  • TM Collaborator
  • Jr. Member
  • *****
  • Posts: 88
  • Last Login:June 26, 2022, 08:46:26 pm
Re: Japan: National Highways 一般国道 system
« Reply #59 on: June 25, 2022, 11:19:22 am »
Maybe starting in mid-July I can work with the development server. 

Monday I'm heading to central Texas for two weeks.  (My sister owes me bigtime for trading coastal Maine summer weather for Texas 100+ heat.)