Travel Mapping
Highway Data Discussion => Updates to Highway Data => Solved Highway data updates => Topic started by: yakra on December 19, 2019, 10:44:54 pm
-
Can't remember how I became aware that this is broken, but have had a few browser tabs open as a reminder for a couple weeks now.
WI159 never got an AltRouteName when WI123 was deleted, and
WI136 never got AltRouteNames when WI159 was deleted.
Opened a pull request that fixes the following .list lines: (https://github.com/TravelMapping/HighwayData/pull/3430/files)
bulldog1979.list: WI WI123 CRDL WI33
bulldog1979.list: WI WI159 US12 WI123
imgoph.list: WI WI123 CRDL WI159
imgoph.list: WI WI159 US12 WI123
julmac.list: WI WI123 WI33 CRDI
keithcavey.list: WI WI123 CRDL WI159
keithcavey.list: WI WI123 WI113_S WI33
keithcavey.list: WI WI159 US12 WI123
sipes23.list: WI WI123 CRDL WI33
sipes23.list: WI WI159 US12 ParkRd
Highway63, since WI is your state, you have veto power over this of course.
This look OK?
-
Does it mean that users with WI123 and WI159 entries will have their points read as WI 136? Am I interpreting that correctly? If so, that's fine.
On the last line for 136, one of those labels needs to get a "+" as an alt, and it's CRDL not CRDI.
-
Does it mean that users with WI123 and WI159 entries will have their points read as WI 136? Am I interpreting that correctly? If so, that's fine.
Yes.
On the last line for 136, one of those labels needs to get a "+" as an alt,
For hidden AltLabels, the '+' is unnecessary; the HB only shows the primary label, and .lists get parsed the same either way.
If you prefer though, I can easily add it back in.
wptedit will add a '+' in for AltLabels that don't have one already , as soon as you start editing the file...
and it's CRDL
CRDL is already a primary label elsewhere (http://www.openstreetmap.org/?lat=43.438228&lon=-89.743752), so we can't duplicate it here.
not CRDI.
CRDI was an AltLabel here in the last version of WI123 (https://github.com/TravelMapping/HighwayData/commit/aa46188974b532182cd5cab46bb362d106ec76dd#diff-62c48b649613438cc4e1b83873c705d9L1) before deletion (chm_final too (https://github.com/TravelMapping/HighwayData/blob/master/chm_final/usawi/wi.wi123.wpt)). Maybe a fix for a long-ago typo? CRDI is in use, so I kept it to preserve compatibility with julmac.list.
-
Either a long-ago typo or, when I looked at OSM, it might have said CR DI before the DI was reinterpreted as a DL.
In that light, would this label ending for 136 be correct?
PoiRocRd +US12 http://www.openstreetmap.org/?lat=43.438212&lon=-89.768944
CRDL +CRDI +WI123 +WI159 http://www.openstreetmap.org/?lat=43.438228&lon=-89.743752
ParkRd http://www.openstreetmap.org/?lat=43.434520&lon=-89.739847
-
No, because the coords (http://www.openstreetmap.org/?lat=43.434520&lon=-89.739847&zoom=15) of the old CRDI AltLabel match those of the new ParkRd point, so that's the point it which the label was used.
-
I've sent a new file. If something still looks askew after that let me know.
-
Looks good (https://github.com/TravelMapping/HighwayData/commit/27896f32b5ed7d514bb92d61f0c031eaf6c12587#diff-4925eea25faa874ec8a52956cd03fada).
-
I guess that the topic can be marked solved? I do............
-
Yay, I at least got one of these figured out! :P