Travel Mapping

User Discussions => Welcome & Notices => Topic started by: Markkos1992 on September 28, 2022, 03:04:59 am

Title: Failed Site Update 9-27
Post by: Markkos1992 on September 28, 2022, 03:04:59 am
I did not run Datacheck on my pull request yesterday as it was just minor label changes, but it was successful when I ran it this morning so I am unsure what happened.
Title: Re: Failed Site Update 9-27
Post by: si404 on September 28, 2022, 05:35:28 am
I made a bad updates.csv line (sorry), and Jim fixed it for me (https://github.com/TravelMapping/HighwayData/commit/8f8e36922ae7052cd0b955380c7b88fc687d9fe9) (terrible phrasing, I know, sorry!), but then somehow mucked up a different line, which I've just fixed (https://github.com/si404/HighwayData/commit/440557a8ceeffd43b05b39bdc301b7bf0dc6894a).
Title: Re: Failed Site Update 9-27
Post by: Jim on September 28, 2022, 07:37:31 am
Thanks for the fix.  Looks like I made a stray edit unintentionally while searching for the original problematic line.  I should know better than to try to save a few minutes by editing right on GitHub and not taking a closer look at the changes I'm about to commit.  And then going to bed without waiting for the update to complete.

An update is in progress now.
Title: Re: Failed Site Update 9-27
Post by: Markkos1992 on September 28, 2022, 09:29:24 am
I'm not sure that si404's update has been merged in Github yet.
Title: Re: Failed Site Update 9-27
Post by: osu-lsu on September 28, 2022, 10:53:13 am
All I know is at 10:52 EDT, there is an update still going on.  ???
Title: Re: Failed Site Update 9-27
Post by: michih on September 28, 2022, 12:26:13 pm
I'm not sure that si404's update has been merged in Github yet.

It's not in the master branch (last commit to updates.csv (https://github.com/TravelMapping/HighwayData/commits/master/updates.csv) is from Jim) and the update failed again.
Title: Re: Failed Site Update 9-27
Post by: michih on September 28, 2022, 01:37:52 pm
The site is back to normal now. Thanks! :)