Author Topic: usaky3: Kentucky Highways 1000-1499  (Read 7055 times)

0 Members and 1 Guest are viewing this topic.

Offline si404

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 1450
  • Last Login:Yesterday at 06:17:16 pm
Re: usaky3: Kentucky Highways 1000-1499
« Reply #30 on: March 05, 2016, 01:36:18 pm »
Having given review to this system back in the CHM days, I don't want to put effort into reviewing it now - I gather that my comments from then were dealt with, so I'm fine with activation whenever yakra feels its OK.

This one remaining datacheck error looks to be a false positive.
ky.ky1499;KY366;+X633272;+X817752;SHARP_ANGLE;138.61

Offline mapcat

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 1120
  • Last Login:Yesterday at 07:33:15 pm
Re: usaky3: Kentucky Highways 1000-1499
« Reply #31 on: March 05, 2016, 08:08:27 pm »
This one remaining datacheck error looks to be a false positive.
ky.ky1499;KY366;+X633272;+X817752;SHARP_ANGLE;138.61

Thanks for pointing out that this one is back from the dead. I had added this error to the fps file already, but it came back after I adjusted a waypoint location and the angle changed slightly (the last 3 digits were different). Is there a reason that the error log has to state the angle measurement?
Clinched:

Offline mapcat

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 1120
  • Last Login:Yesterday at 07:33:15 pm
Re: usaky3: Kentucky Highways 1000-1499
« Reply #32 on: March 19, 2016, 01:36:59 am »
2 weeks with no further comments...can we activate?


I'll deal with the connector routes separately, since I plan on going through the KYTC material county by county collecting the remaining routes before making new files, and it will be easier to look for other routes ending in "C" while doing that.
Clinched:

Offline yakra

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 3134
  • Last Login:Yesterday at 01:49:52 pm
Re: usaky3: Kentucky Highways 1000-1499
« Reply #33 on: March 19, 2016, 01:00:08 pm »
I personally don't have a strong opinion either way on including the connector routes, and won't shout you down if you want to activate usaky3.

Do you have any knowledge as to whether similar routes were included/excluded from Kentucky Highways 1-999?

You're probably aware, but I just wanna make sure, that on activation, all the usaky3 files would be moved into the usaky directory, and the contents of the usaky3 CSVs would be merged into the usaky CSVs.
Sri Syadasti Syadavaktavya Syadasti Syannasti Syadasti Cavaktavyasca Syadasti Syannasti Syadavatavyasca Syadasti Syannasti Syadavaktavyasca

Offline mapcat

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 1120
  • Last Login:Yesterday at 07:33:15 pm
Re: usaky3: Kentucky Highways 1000-1499
« Reply #34 on: March 19, 2016, 09:12:06 pm »
Do you have any knowledge as to whether similar routes were included/excluded from Kentucky Highways 1-999?
The only ones were the routes actually signed KYXXXC.

Quote
You're probably aware, but I just wanna make sure, that on activation, all the usaky3 files would be moved into the usaky directory, and the contents of the usaky3 CSVs would be merged into the usaky CSVs.
I realized that would happen, and was assuming that Jim would have a simple way of doing it behind the scenes. Or should I make the moves myself?
Clinched:

Offline Jim

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 2105
  • Last Login:Yesterday at 10:45:23 pm
Re: usaky3: Kentucky Highways 1000-1499
« Reply #35 on: March 20, 2016, 08:57:31 am »
You're probably aware, but I just wanna make sure, that on activation, all the usaky3 files would be moved into the usaky directory, and the contents of the usaky3 CSVs would be merged into the usaky CSVs.
I realized that would happen, and was assuming that Jim would have a simple way of doing it behind the scenes. Or should I make the moves myself?

Right - if you're not comfortable with git from the command line and similar things, it's probably easiest to let me know when it's ready and I'll do all of the appropriate renaming and merging.

Offline si404

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 1450
  • Last Login:Yesterday at 06:17:16 pm
Re: usaky3: Kentucky Highways 1000-1499
« Reply #36 on: March 20, 2016, 09:18:45 am »
I realized that would happen, and was assuming that Jim would have a simple way of doing it behind the scenes. Or should I make the moves myself?
It's really simple anyway - copy the data in the .csv files of usaky3 (minus the header line) and paste into the respective usaky .csvs at the bottom. Do a find-replace 'usaky3' for 'usaky' and then that's it.

Though, of course, you have to also move the files from KY/usaky3 to KY/usaky, which might prove harder for you. You don't need git from the command line to do it. The 'for Windows' makes it rather easy (simply do it the same way you'd move any bunch of files) and I believe the web interface now allows you to drag and drop to add files to folders (though I don't know whether you can do mass deletions).

Offline mapcat

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 1120
  • Last Login:Yesterday at 07:33:15 pm
Re: usaky3: Kentucky Highways 1000-1499
« Reply #37 on: March 20, 2016, 08:06:14 pm »
All right, I'll try it and let you know if I run into any problems.
Clinched:

Offline mapcat

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 1120
  • Last Login:Yesterday at 07:33:15 pm
Re: usaky3: Kentucky Highways 1000-1499
« Reply #38 on: March 20, 2016, 08:48:41 pm »
No problems with changing .csv files.

But now that I'm moving the individual .wpts from usaky3 to usaky, I've run into this error message in my local fork:

Quote
Sorry, we had to truncate this directory to 1,000 files. 166 entries were omitted from the list.

Does git have a limit of 1000 files in a directory? Why else might I be getting this message?
Clinched:

Offline Jim

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 2105
  • Last Login:Yesterday at 10:45:23 pm
Re: usaky3: Kentucky Highways 1000-1499
« Reply #39 on: March 20, 2016, 11:38:58 pm »
Does git have a limit of 1000 files in a directory? Why else might I be getting this message?

My guess is that the web interface is just showing 1000 but that they all exist.

Offline si404

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 1450
  • Last Login:Yesterday at 06:17:16 pm
Re: usaky3: Kentucky Highways 1000-1499
« Reply #40 on: March 21, 2016, 07:58:06 am »
My guess is that the web interface is just showing 1000 but that they all exist.
Exactly this.

Offline mapcat

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 1120
  • Last Login:Yesterday at 07:33:15 pm
Re: usaky3: Kentucky Highways 1000-1499
« Reply #41 on: March 21, 2016, 05:55:26 pm »
OK, thanks. Submitted.

I did not attempt to delete the files from the usaky3 directory yet since I want to make sure all of them copied correctly first.
Clinched:

Offline Jim

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 2105
  • Last Login:Yesterday at 10:45:23 pm
Re: usaky3: Kentucky Highways 1000-1499
« Reply #42 on: March 22, 2016, 07:33:50 pm »
The usaky3->usaky merge is complete and usaky3 files are now deleted.

Any objections to my system updates entry for this?  I marked usaky3 as "merged" and usaky as "extended".

Offline mapcat

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 1120
  • Last Login:Yesterday at 07:33:15 pm
Re: usaky3: Kentucky Highways 1000-1499
« Reply #43 on: March 22, 2016, 07:42:10 pm »
The usaky3->usaky merge is complete and usaky3 files are now deleted.

Any objections to my system updates entry for this?  I marked usaky3 as "merged" and usaky as "extended".
Thanks! The updates language makes sense to me.
Clinched:

Offline michih

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 3075
  • Last Login:Yesterday at 03:35:03 pm
Re: usaky3: Kentucky Highways 1000-1499
« Reply #44 on: March 23, 2016, 02:19:18 pm »
I marked usaky3 as "merged" and usaky as "extended".

Great idea! :)

btw: Si merged some systems last year (Spain, Italy, UK and Czech Republic). The "New Status" is cut: "delete (merge in ? ? ? ?"...