Travel Mapping

Highway Data Discussion => Updates to Highway Data => Solved Highway data updates => Topic started by: yakra on May 23, 2018, 04:39:57 am

Title: NIR: out of bounds coords
Post by: yakra on May 23, 2018, 04:39:57 am
WARNING: out-of-bounds coords in nir.glenbalsr: http://www.openstreetmap.org/?lat=55.018551&lon=-366.146634
WARNING: out-of-bounds coords in nir.b014: http://www.openstreetmap.org/?lat=55.018551&lon=-366.146634
Off by 360° ;)

Worked fine in Google; doesn't play nice with Leaflet.
I'll get to work on coding a datacheck in the morn--afternoon.

Si, let's hold off on submitting a fix until I get the datacheck working.
Title: Re: NIR: out of bounds coords
Post by: si404 on May 23, 2018, 06:05:55 am
How did Tim's CHM editor do that? I didn't do that deliberately*.


*Unlike the intersection of the B1165 and B1168 with one at 0 and one at -0, to see if it worked, but looks like I made them both -0, with them appearing as 0.000000 on the co-ordinates in the browser (and the trailing zeros are on the files). Fixing that for my little experiment again - seems like every point on the meridian is at -0, rather than 0, but that isn't 360 degrees out.
Title: Re: NIR: out of bounds coords
Post by: yakra on May 23, 2018, 11:14:04 am
Quote
How did Tim's CHM editor do that? I didn't do that deliberately*.
No idea. I've just tried to recreate it by scrolling  360° around the world between adding successive points. No dice.
Title: Re: NIR: out of bounds coords
Post by: si404 on May 23, 2018, 11:52:49 am
It was more rhetorical than anything.

I've fixed them locally, but won't submit until you're happy with a datacheck and all.
Title: Re: NIR: out of bounds coords
Post by: yakra on May 23, 2018, 03:19:39 pm
Right,  just noting that I'm right there with you, asking the same question.

I've encountered some unexpected oddities while working on the datacheck that will take a little delving into. Be back at it after lunch...
Title: Re: NIR: out of bounds coords
Post by: yakra on May 23, 2018, 09:58:11 pm
I've encountered some unexpected oddities while working on the datacheck that will take a little delving into.
This appears unrelated to the changes I was making.
https://github.com/TravelMapping/DataProcessing/issues/85

As for the actual datacheck,
https://github.com/TravelMapping/DataProcessing/pull/86
Title: Re: NIR: out of bounds coords
Post by: yakra on May 25, 2018, 12:06:25 am
These are now showing up on the datacheck page as intended.