Travel Mapping
Highway Data Discussion => Updates to Highway Data => Solved Highway data updates => Topic started by: osu-lsu on September 08, 2018, 09:18:22 pm
-
When one goes to:
http://travelmapping.net/hb/?units=miles&u=osu_lsu&r=pa.pa023alttrkkop.wpt
http://travelmapping.net/hb/?units=miles&u=osu_lsu&r=pa.pa160trkwil.wpt
You will see the following:
Warning: Division by zero in /home/www/tm/hb/index.php on line 276
Somebody's coding needs to be fixed.
-
http://travelmapping.net/hb/?units=miles&u=osu_lsu&r=pa.pa160trkwil
http://travelmapping.net/hb/?units=miles&u=osu_lsu&r=pa.pa023alttrkkop
Code fixed ;D
-
Was this a result of what you told me this morning?
I made sure to immediately put in a pull request to fix that.
-Mark
-
http://travelmapping.net/hb/?units=miles&u=osu_lsu&r=pa.pa160trkwil
http://travelmapping.net/hb/?units=miles&u=osu_lsu&r=pa.pa023alttrkkop
Code fixed ;D
Sort of.
If you go to the update page and click on the link for either of those routes, you still get the error message.
-
Somebody's coding needs to be fixed.
Any nonexistent route that attempts to get loaded results in that kind of thing.
The code fix that needs to be made is not at the line 276 divide by zero, but to put up an error page when a nonexistent route is specified. This normally only happens when people hand-edit URLs or as in this case, that there is a bad link being created from updates.csv in the update table.
This is a known issue that hasn't risen to the top of the priority queue yet: https://github.com/TravelMapping/DataProcessing/issues/62
-
Sort of.
If you go to the update page and click on the link for either of those routes, you still get the error message.
Ah, didn't realize you were pointing out the same ones Mark had fixed this morning. Tonight's pull request will correct the entries.
-
https://github.com/TravelMapping/HighwayData/pull/2202 (for reference)
-
In any case, with tonight's update done, the updates.csv fixes have been ingested and the Updates page now has the correct links.