Travel Mapping
Highway Data Discussion => Updates to Highway Data => Solved Highway data updates => Topic started by: yakra on March 09, 2020, 08:03:41 pm
-
Queried the DB for routes with an abbrev & no city, and came across NV430Nor.
A bit of a weird one, as there's no vanilla NV430 without an abbrev. Maybe there originally was, back during development in the CHM days?
Suggest changing to vanilla NV430, and adding NV430Nor as an AltRouteName.
-
In my queue.
EDIT: Fix is in the HB.
-
Oops, I failed to notice:
Duplicate main list name in nv.nv430: 'NV NV430' already points to nv.us395altwas
No harm now, though, as NV NV430 isn't in use in any .list files, and usanv is processed after usaus thus the .list name points to the correct route.
However, this will matter in the near future (https://github.com/TravelMapping/DataProcessing/issues/316), so we should remove the AltRouteName from usausb.csv.
-
Oops, I failed to notice:
Duplicate main list name in nv.nv430: 'NV NV430' already points to nv.us395altwas
No harm now, though, as NV NV430 isn't in use in any .list files, and usanv is processed after usaus thus the .list name points to the correct route.
However, this will matter in the near future (https://github.com/TravelMapping/DataProcessing/issues/316), so we should remove the AltRouteName from usausb.csv.
Fix is made in my local copy, in my queue for tonight's canqc pull request. usausb_con.csv requires no change.
.csv changes often get me in trouble. However, I have the datacheck.sh process memorized by now, and have been using it on every canqc review pull request, so if there's a glitch it'll get caught before getting merged into the master.
-
Duplicate AltRouteNames still aren't caught by datacheck.sh, so this one flew right over both our heads. Fix pending. (https://github.com/TravelMapping/DataProcessing/issues/316)