Author Topic: TN: TN-131 reroute @ US-25E  (Read 10463 times)

0 Members and 1 Guest are viewing this topic.

Offline rickmastfan67

  • TM Collaborator (A)
  • Hero Member
  • *****
  • Posts: 2090
  • Gender: Male
  • Last Login:Yesterday at 10:15:24 pm
TN: TN-131 reroute @ US-25E
« on: January 28, 2024, 06:12:53 pm »
At it's intersection with US-25E, the intersection has now been split apart, creating a short multiplex with US-25E now.

When they did this, the 'original' location of the intersection is now gone, as they put the two intersections on either side of it.

Thus, the 'TN131' point in US-25E should be marked as a 'closed' point when the new intersections are added in.

No imagery shows this yet, but both OSM & Google have been updated to reflect this.  Plus GSV was already in the area to photograph it back in July '21.

Offline mapcat

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 1782
  • Last Login:Yesterday at 08:56:54 pm
Re: TN: TN-131 reroute @ US-25E
« Reply #1 on: February 24, 2024, 06:36:04 pm »
https://github.com/TravelMapping/HighwayData/pull/7243


Fortunately the 3 users with travels on TN 131 that used the US25E point in their lists were either using it for travel the same direction (north of the point) or keeping it in an unused line, so US25E +> US25E_N and no broken lists.
Clinched:

Offline rickmastfan67

  • TM Collaborator (A)
  • Hero Member
  • *****
  • Posts: 2090
  • Gender: Male
  • Last Login:Yesterday at 10:15:24 pm
Re: TN: TN-131 reroute @ US-25E
« Reply #2 on: February 24, 2024, 08:48:16 pm »
https://github.com/TravelMapping/HighwayData/pull/7243


Fortunately the 3 users with travels on TN 131 that used the US25E point in their lists were either using it for travel the same direction (north of the point) or keeping it in an unused line, so US25E +> US25E_N and no broken lists.

You forgot to add in the '*OldTN131' point in TN-131 where the old intersection with US-25E was.  Thus, the site will not properly trigger the multiplex between the two routes because of that.

Offline mapcat

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 1782
  • Last Login:Yesterday at 08:56:54 pm
Re: TN: TN-131 reroute @ US-25E
« Reply #3 on: February 24, 2024, 11:27:45 pm »
Fix submitted and pulled in.

FWIW, if there's an urgent message for me, I won't look for it here. Thanks for deciding to post it to Github too.
Clinched:

Offline rickmastfan67

  • TM Collaborator (A)
  • Hero Member
  • *****
  • Posts: 2090
  • Gender: Male
  • Last Login:Yesterday at 10:15:24 pm
Re: TN: TN-131 reroute @ US-25E
« Reply #4 on: February 24, 2024, 11:35:34 pm »
FWIW, if there's an urgent message for me, I won't look for it here. Thanks for deciding to post it to Github too.

Well, it wasn't 'THAT' urgent.  At least it wasn't a point that made a route traverse the earth 10x times over. LOL!

Offline rickmastfan67

  • TM Collaborator (A)
  • Hero Member
  • *****
  • Posts: 2090
  • Gender: Male
  • Last Login:Yesterday at 10:15:24 pm
Re: TN: TN-131 reroute @ US-25E
« Reply #5 on: July 13, 2024, 12:17:53 pm »
Can't believe I didn't notice this on the 'error log' page, but a duplicate label sadly got introduced here.

Code: [Select]
tn.tn131 OldUS25E DUPLICATE_LABEL This is always a true error and cannot be marked false positive.
Thankfully, label isn't currently in-use.

Offline mapcat

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 1782
  • Last Login:Yesterday at 08:56:54 pm
Re: TN: TN-131 reroute @ US-25E
« Reply #6 on: July 13, 2024, 04:39:19 pm »
Guess I should check that more often. https://github.com/TravelMapping/HighwayData/pull/7547
Clinched: