Author Topic: usaga: Georgia State Highways  (Read 46400 times)

0 Members and 1 Guest are viewing this topic.

Offline Jim

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 1843
  • Last Login:Today at 10:37:43 pm
Re: usaga (Georgia State Highways) - Preview
« Reply #210 on: December 02, 2019, 07:56:05 am »
I can get this stuff ready to merge back in, but would like to address some of these items from my last couple posts in the process.
@ntallyn, once you go to merge it back into your master branch, there will be merge conflicts. Rather than poke the git gods with a stick & try to resolve them, I'm thinking that resetting your master branch to the state it was in before your last commit may be the safer option. It's a clunky process, a bit roundabout. I can post instructions.

For our purposes it might be easiest to delete and recreate the fork.  I think this would only be problematic if there are changes in the local clone that are not yet either in the TravelMapping master or in the offending pull request that yarka's working through.

Offline neroute2

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 623
  • Last Login:Today at 08:10:24 pm
Re: usaga (Georgia State Highways) - Preview
« Reply #211 on: December 02, 2019, 08:22:14 am »
To update your own repository, use this link (replacing neroute2 with your own username): https://github.com/neroute2/HighwayData/compare/master...TravelMapping:master

Offline yakra

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 2776
  • Last Login:Today at 06:50:34 pm
Re: usaga (Georgia State Highways) - Preview
« Reply #212 on: December 02, 2019, 10:13:07 am »
To update your own repository, use this link (replacing neroute2 with your own username): https://github.com/neroute2/HighwayData/compare/master...TravelMapping:master
That would cause some hairy merge conflicts.

For our purposes it might be easiest to delete and recreate the fork.  I think this would only be problematic if there are changes in the local clone that are not yet either in the TravelMapping master or in the offending pull request that yarka's working through.
Probably easier, yes. ntallyn would lost the existing pull request and issue history for his fork. And it looks like there are none.
Yes, delete and recreate looks simpler here.

https://xkcd.com/1597/
« Last Edit: December 02, 2019, 10:57:07 am by yakra »

Offline dave1693

  • Full Member
  • ***
  • Posts: 108
  • Last Login:May 19, 2020, 02:31:35 am
Re: usaga (Georgia State Highways) - Preview
« Reply #213 on: December 20, 2019, 01:41:21 pm »
Yes, delete and recreate looks simpler here.

https://xkcd.com/1597/

 ;D  ::)  X-D

Offline ntallyn

  • TM Collaborator
  • Full Member
  • *****
  • Posts: 172
  • Last Login:Today at 07:11:27 pm
Re: usaga (Georgia State Highways) - Preview
« Reply #214 on: December 21, 2019, 10:59:41 pm »
Pull request submitted:
https://github.com/TravelMapping/HighwayData/pull/3367

But there are conflicts (in the usausb.csv files). So obviously I'm doing something wrong. I figured when the system fetched the origin branch, it would update my master branch, as it does when I do it at work (though that is git, not github), and notify me of the conflict at that time. But that certainly isn't the case, as every file that I haven't changed has the time stamp of when I created the branch in the first place.

Fixed the above and resubmitted a pull request: https://github.com/TravelMapping/HighwayData/pull/3446

Comments after the above-quoted post have not yet been implemented, as well as my local to-do list (see earlier post) from GA37 up.

Nick

Offline ntallyn

  • TM Collaborator
  • Full Member
  • *****
  • Posts: 172
  • Last Login:Today at 07:11:27 pm
Re: usaga: Georgia State Highways
« Reply #215 on: December 22, 2019, 12:25:59 am »
I've made the changes from #208 and #209 locally, too. Only 2 of the OldUS441's remained (that's how it's signed on the blades).

Still to come:
Gray Bypass(all routes): update
GA37Trk (Camilla): add
GA45Trk (Colquitt): add
GA62Trk (Arlington): add
GA73: update routing
GA73Byp (Statesboro): add
GA75Con (Cleveland/White Co.): add
GA86 (Oak Park): update
GA91Trk (Colquitt): add
GA92: end location at Griffin?
GA154ConAtl: add?
GA158Trk (Douglas): add
GA166: update
GA216Trk (Arlington): add
GA246: split
GA540: add
US1 (Oak Park): update

GA route concurrency checks
US route updates to reflect GA route updates


Nick

Offline ntallyn

  • TM Collaborator
  • Full Member
  • *****
  • Posts: 172
  • Last Login:Today at 07:11:27 pm
Re: usaga (Georgia State Highways) - Preview
« Reply #216 on: December 22, 2019, 12:52:25 am »

GA 45TrkCol and GA91TrkCol There are fully signed truck routes for GA 45 and GA 91 in Colquitt that follow US 27 and GA 91spr, with GA 45 truck then using GA 91 back into downtown Colquitt


I don't know if I'd call them fully-signed. I could find no signage for GA91 Trk on GMSV (all from Dec 2018), and only could find a couple for GA45 Trk on westbound Main St. There was also a sign "All Trucks" heading south on First St at Main St (indicating to head east on Main). Nothing on or at US27. Staying out for now.

Offline Jim

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 1843
  • Last Login:Today at 10:37:43 pm
Re: usaga (Georgia State Highways) - Preview
« Reply #217 on: December 22, 2019, 09:43:33 am »
Pull request submitted:
https://github.com/TravelMapping/HighwayData/pull/3367

But there are conflicts (in the usausb.csv files). So obviously I'm doing something wrong. I figured when the system fetched the origin branch, it would update my master branch, as it does when I do it at work (though that is git, not github), and notify me of the conflict at that time. But that certainly isn't the case, as every file that I haven't changed has the time stamp of when I created the branch in the first place.

See the comments in the pull request.  It looks to include changes that undo lots of recent activity in the usausb.csv and usausb_con.csv files.

Fixed the above and resubmitted a pull request: https://github.com/TravelMapping/HighwayData/pull/3446

Comments after the above-quoted post have not yet been implemented, as well as my local to-do list (see earlier post) from GA37 up.

Nick

Offline ntallyn

  • TM Collaborator
  • Full Member
  • *****
  • Posts: 172
  • Last Login:Today at 07:11:27 pm
Re: usaga (Georgia State Highways) - Preview
« Reply #218 on: December 22, 2019, 12:07:09 pm »
See the comments in the pull request.  It looks to include changes that undo lots of recent activity in the usausb.csv and usausb_con.csv files.

Should be fixed now. Pull request resubmitted, along with all of the GA changes mentioned below:

Gray Bypass(GA11/18/22/44, US129): updated
GA11Byp (Cleveland): added
GA12Trk (Madison): added
GA29Bus (Milledgeville): added
GA35Con (Thomasville): added
GA35Lp (Tifton): added
GA37Trk (Camilla): added
GA45Trk (Arlington): added
GA62Trk (Arlington): added
GA75Con (Cleveland/White Co.): added
GA92: modified end location
GA154ConAtl: added
GA158Trk (Douglas): added
GA166: updated
GA246: split
GA540: added
US129Byp (Cleveland): added
US278Trk (Madison): added

The following changes mentioned in previous comments were NOT made:
GA32Trk (Douglas): add - only signed while approaching town. Not signed along the route itself.
GA45Trk (Colquitt): add - found minimal signage on GMSV (December 2018). See previous post regarding this one.
GA73: update routing - appears to have been previously completed
GA73Byp (Statesboro): add - appears to have been previously completed
GA86 (Oak Park): update - appears to have been previously completed
GA91Trk (Colquitt): add - found no signage on GMSV (December 2018)
GA216Trk (Arlington): add - only signed from GA45/62 (probably to avoid the turn downtown). It is NOT signed from GA216 itself.
US1 (Oak Park): update - appears to have been previously completed

The following items remain:
GA route concurrency checks
US route updates to reflect GA route updates
« Last Edit: December 22, 2019, 12:15:19 pm by ntallyn »

Offline mapmikey

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 551
  • Last Login:Yesterday at 06:58:32 pm
    • Co-curator Virginia Highways Project
Re: usaga (Georgia State Highways) - Preview
« Reply #219 on: December 22, 2019, 02:30:30 pm »

GA 45TrkCol and GA91TrkCol There are fully signed truck routes for GA 45 and GA 91 in Colquitt that follow US 27 and GA 91spr, with GA 45 truck then using GA 91 back into downtown Colquitt


I don't know if I'd call them fully-signed. I could find no signage for GA91 Trk on GMSV (all from Dec 2018), and only could find a couple for GA45 Trk on westbound Main St. There was also a sign "All Trucks" heading south on First St at Main St (indicating to head east on Main). Nothing on or at US27. Staying out for now.

Looks like they removed postings between the 2013 GMSV I had available in 2017 and the updated shots...

Offline CharlotteAllisonCDTG

  • Jr. Member
  • **
  • Posts: 72
  • Gender: Female
  • Last Login:June 21, 2020, 07:55:47 pm
  • Transgender Lesbian and Traveler
    • My Wikipedia User Page
Re: usaga: Georgia State Highways
« Reply #220 on: December 22, 2019, 08:55:19 pm »
GA 45 Truck and GA 91 Truck travel concurrently with US 27/GA 1 from College Street to 4th Street. Then, they use 4th Street to GA 91 (Main Street).  Here, GA 91 Truck ends, and GA 45 Truck follows GA 91 to GA 45.

GA 91 Spur is the aforementioned portion of 4th Street, from US 27/GA 1 to GA 91.
Completely clinched:  I-24, I-35W (MN), I-97, I-124, I-126, I-155 (MO-TN), I-190 (SD), I-195 (MD), I-240 (NC), I-295 (FL), I-375 (MI), I-516, I-520, I-526, I-564, I-585, I-640, I-675 (GA), I-895A, US 178, US 276

Offline CharlotteAllisonCDTG

  • Jr. Member
  • **
  • Posts: 72
  • Gender: Female
  • Last Login:June 21, 2020, 07:55:47 pm
  • Transgender Lesbian and Traveler
    • My Wikipedia User Page
Re: usaga: Georgia State Highways
« Reply #221 on: December 25, 2019, 01:51:40 am »
GA 73 Byp (Statesboro) and GA 135 Truck (Hazlehurst) are both missing from the Highway Browser.
Completely clinched:  I-24, I-35W (MN), I-97, I-124, I-126, I-155 (MO-TN), I-190 (SD), I-195 (MD), I-240 (NC), I-295 (FL), I-375 (MI), I-516, I-520, I-526, I-564, I-585, I-640, I-675 (GA), I-895A, US 178, US 276

Offline michih

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 2670
  • Last Login:Today at 03:55:34 pm
Re: usaga: Georgia State Highways
« Reply #222 on: December 25, 2019, 02:32:12 am »
GA 73 Byp (Statesboro) and GA 135 Truck (Hazlehurst) are both missing from the Highway Browser.

The following changes mentioned in previous comments were NOT made:

[...]

GA73Byp (Statesboro): add - appears to have been previously completed

[...]

The following items remain:
GA route concurrency checks
US route updates to reflect GA route updates

Offline ntallyn

  • TM Collaborator
  • Full Member
  • *****
  • Posts: 172
  • Last Login:Today at 07:11:27 pm
Re: usaga: Georgia State Highways
« Reply #223 on: December 25, 2019, 01:13:40 pm »
GA 73 Byp (Statesboro) and GA 135 Truck (Hazlehurst) are both missing from the Highway Browser.

Not sure where GA73 Bypass went off to. I saw that it was done, but now it is missing. I'll take a look at both of these over the holidays (with the concurrency checks and data errors).

Offline CharlotteAllisonCDTG

  • Jr. Member
  • **
  • Posts: 72
  • Gender: Female
  • Last Login:June 21, 2020, 07:55:47 pm
  • Transgender Lesbian and Traveler
    • My Wikipedia User Page
Re: usaga: Georgia State Highways
« Reply #224 on: December 25, 2019, 07:50:00 pm »
Thanks.  I know you said that GA 73 Byp (Statesboro) was previously completed.  After I refreshed the Highway Browser, I didn't see it.  That's why I mentioned it.
Completely clinched:  I-24, I-35W (MN), I-97, I-124, I-126, I-155 (MO-TN), I-190 (SD), I-195 (MD), I-240 (NC), I-295 (FL), I-375 (MI), I-516, I-520, I-526, I-564, I-585, I-640, I-675 (GA), I-895A, US 178, US 276