Author Topic: usaga: Georgia State Highways  (Read 175210 times)

0 Members and 6 Guests are viewing this topic.

Offline oscar

  • TM Collaborator
  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 1584
  • Last Login:Today at 02:23:09 am
    • Hot Springs and Highways pages
Re: usaga: Georgia State Highways
« Reply #300 on: March 22, 2020, 08:50:26 am »
GA 115 should get another waypoint in Cleveland, matching the GA115 point on US 129 Bypass.

Thanks for all the Perry area changes, which I've just incorporated in my list file.

Offline neroute2

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 1142
  • Last Login:Today at 01:46:39 am
Re: usaga: Georgia State Highways
« Reply #301 on: March 22, 2020, 09:52:30 am »
GA 115 should get another waypoint in Cleveland, matching the GA115 point on US 129 Bypass.
115 also has waypoints in the wrong order in Cleveland.

Offline ntallyn

  • TM Collaborator
  • Sr. Member
  • *****
  • Posts: 337
  • Last Login:October 31, 2024, 08:04:24 pm
Re: usaga: Georgia State Highways
« Reply #302 on: March 22, 2020, 10:56:36 am »
Looks like both of these issues are due to a "Duplicate Coordinate" issue. It appears I put the US129 coordinates in for the US129Byp label as well. Fixed locally.

Offline ntallyn

  • TM Collaborator
  • Sr. Member
  • *****
  • Posts: 337
  • Last Login:October 31, 2024, 08:04:24 pm
Re: usaga: Georgia State Highways
« Reply #303 on: March 28, 2020, 03:50:25 pm »
Everything has been pushed. I went through all of the route files and updated/removed all of the Old* labels. The ones that remain in the files fall into one of the following categories:

1. Closed intersections
2. Intersections that are actually signed Old*
3. Intersections that I couldn't find any evidence that the label was incorrect.

https://github.com/TravelMapping/HighwayData/pull/3705

At this point, I've completed all of the comments and suggestions in this thread, as well as all of the updates mentioned in the GA route update forum. Once this is merged, I believe this system is ready for activation.

Offline Jim

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 2856
  • Last Login:Yesterday at 09:42:37 pm
Re: usaga: Georgia State Highways
« Reply #304 on: March 28, 2020, 04:39:14 pm »
Assuming usaga is next to activate, it will be the one that puts us over 1,000,000 miles in active systems, and will blow past what we need to get there by quite a bit.

Offline michih

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 4849
  • Last Login:November 20, 2024, 11:21:09 am
Re: usaga: Georgia State Highways
« Reply #305 on: March 28, 2020, 04:41:38 pm »
Once this is merged,

with tonight's update

I believe this system is ready for activation.

You just need to edit systems.csv and systemupdates.csv.

Code: [Select]
usaga;USA;Georgia State Highways;brown;4;preview
->
usaga;USA;Georgia State Highways;brown;4;active

Code: [Select]
-->
2020-03-28;(USA) Georgia;usaga;Georgia State Highways;active

Offline ntallyn

  • TM Collaborator
  • Sr. Member
  • *****
  • Posts: 337
  • Last Login:October 31, 2024, 08:04:24 pm
Re: usaga: Georgia State Highways
« Reply #306 on: March 28, 2020, 06:17:14 pm »
I'm also moving the 3 NSF routes into the regular GA state highway folder. Do I need to do anything else with those?

Should I edit my current pull request with these files?

Offline si404

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 2067
  • Last Login:Today at 12:54:41 am
Re: usaga: Georgia State Highways
« Reply #307 on: March 28, 2020, 06:47:46 pm »
I'm also moving the 3 NSF routes into the regular GA state highway folder. Do I need to do anything else with those?
Remove them from the NSF system .csvs

Offline Jim

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 2856
  • Last Login:Yesterday at 09:42:37 pm
Re: usaga: Georgia State Highways
« Reply #308 on: March 28, 2020, 09:16:09 pm »
Are we good to go for tonight?  I can wait for the additions to the pull request or a new pull request that does the activation, or that can just happen tomorrow instead.

Offline ntallyn

  • TM Collaborator
  • Sr. Member
  • *****
  • Posts: 337
  • Last Login:October 31, 2024, 08:04:24 pm
Re: usaga: Georgia State Highways
« Reply #309 on: March 29, 2020, 10:59:01 am »
Sorry. Was out of pocket most of the evening. Family time. Pull request submitted for activation.

https://github.com/TravelMapping/HighwayData/pull/3708

Offline Jim

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 2856
  • Last Login:Yesterday at 09:42:37 pm
Re: usaga: Georgia State Highways
« Reply #310 on: March 29, 2020, 06:18:05 pm »
Not a problem at all.  The million mile mark will be eclipsed tonight.

Offline kjslaughter

  • Jr. Member
  • **
  • Posts: 77
  • Gender: Male
  • Last Login:November 19, 2024, 03:01:04 pm
Re: usaga: Georgia State Highways
« Reply #311 on: March 30, 2020, 02:12:14 pm »
So excited to see Georgia now in production!!  Thanks so much for all of you're work on this!!!!

Offline michih

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 4849
  • Last Login:November 20, 2024, 11:21:09 am
Re: usaga: Georgia State Highways
« Reply #312 on: March 30, 2020, 03:24:50 pm »
Yes, thanks for working on this, ntallyn :) There are some data errors to be checked: http://travelmapping.net/devel/datacheck.php?rg=GA

Offline ntallyn

  • TM Collaborator
  • Sr. Member
  • *****
  • Posts: 337
  • Last Login:October 31, 2024, 08:04:24 pm
Re: usaga: Georgia State Highways
« Reply #313 on: March 30, 2020, 05:52:55 pm »
All are FPs and are now in the datacheck.csv file.

I also noticed that I missed updating US23 when I added exit 14 on I-985.

Both are fixed locally and will be pushed soon.