Author Topic: PA: Pa160Trk & Pa23Trk (Try Again)  (Read 6102 times)

0 Members and 3 Guests are viewing this topic.

Offline osu-lsu

  • Full Member
  • ***
  • Posts: 169
  • Last Login:Yesterday at 10:43:19 pm
PA: Pa160Trk & Pa23Trk (Try Again)
« on: September 08, 2018, 09:18:22 pm »
When one goes to:
http://travelmapping.net/hb/?units=miles&u=osu_lsu&r=pa.pa023alttrkkop.wpt
http://travelmapping.net/hb/?units=miles&u=osu_lsu&r=pa.pa160trkwil.wpt

You will see the following:
Warning: Division by zero in /home/www/tm/hb/index.php on line 276

Somebody's coding needs to be fixed.

Offline mapcat

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 1767
  • Last Login:Yesterday at 12:05:27 pm
Clinched:

Offline Markkos1992

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 3301
  • Last Login:Today at 11:27:34 am
Re: PA: Pa160Trk & Pa23Trk (Try Again)
« Reply #2 on: September 08, 2018, 09:57:32 pm »
Was this a result of what you told me this morning?

I made sure to immediately put in a pull request to fix that.

-Mark

Offline osu-lsu

  • Full Member
  • ***
  • Posts: 169
  • Last Login:Yesterday at 10:43:19 pm
Re: PA: Pa160Trk & Pa23Trk (Try Again)
« Reply #3 on: September 08, 2018, 10:17:12 pm »

http://travelmapping.net/hb/?units=miles&u=osu_lsu&r=pa.pa160trkwil
http://travelmapping.net/hb/?units=miles&u=osu_lsu&r=pa.pa023alttrkkop

Code fixed  ;D

Sort of.
If you go to the update page and click on the link for either of those routes, you still get the error message.

Offline Jim

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 2856
  • Last Login:Today at 11:08:31 am
Re: PA: Pa160Trk & Pa23Trk (Try Again)
« Reply #4 on: September 08, 2018, 10:35:55 pm »
Somebody's coding needs to be fixed.

Any nonexistent route that attempts to get loaded results in that kind of thing. 

The code fix that needs to be made is not at the line 276 divide by zero, but to put up an error page when a nonexistent route is specified.  This normally only happens when people hand-edit URLs or as in this case, that there is a bad link being created from updates.csv in the update table. 

This is a known issue that hasn't risen to the top of the priority queue yet: https://github.com/TravelMapping/DataProcessing/issues/62

Offline mapcat

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 1767
  • Last Login:Yesterday at 12:05:27 pm
Re: PA: Pa160Trk & Pa23Trk (Try Again)
« Reply #5 on: September 08, 2018, 10:38:51 pm »
Sort of.
If you go to the update page and click on the link for either of those routes, you still get the error message.
Ah, didn't realize you were pointing out the same ones Mark had fixed this morning. Tonight's pull request will correct the entries.
« Last Edit: September 08, 2018, 10:41:06 pm by mapcat »
Clinched:

Offline Markkos1992

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 3301
  • Last Login:Today at 11:27:34 am
Re: PA: Pa160Trk & Pa23Trk (Try Again)
« Reply #6 on: September 08, 2018, 10:45:09 pm »

Offline Jim

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 2856
  • Last Login:Today at 11:08:31 am
Re: PA: Pa160Trk & Pa23Trk (Try Again)
« Reply #7 on: September 08, 2018, 11:01:02 pm »
In any case, with tonight's update done, the updates.csv fixes have been ingested and the Updates page now has the correct links.