Author Topic: Clinched Routes Highway Shields  (Read 340060 times)

0 Members and 1 Guest are viewing this topic.

Offline cockroachking

  • Full Member
  • ***
  • Posts: 127
  • Gender: Male
  • Last Login:Today at 11:24:25 am
Re: Clinched Routes Highway Shields
« Reply #285 on: August 05, 2025, 03:39:38 pm »
Batch 8 is on tmstage for testing.

There was a bad line in the latest update to shieldgen.php.  Fixed in https://github.com/TravelMapping/Web/commit/1e154f78821510508e96b2f2913ab6b949cf5216 and now on tmstage for testing.
I guess Notepad decided to throw in some unfriendly quotation marks. Thanks for fixing it.

Offline cockroachking

  • Full Member
  • ***
  • Posts: 127
  • Gender: Male
  • Last Login:Today at 11:24:25 am
Re: Clinched Routes Highway Shields
« Reply #286 on: August 05, 2025, 05:15:06 pm »
Fixes for Batch 8:
 - usaar: Added missing viewBox attributes for the AR980 template (at least my code worked).
 - lkae and lkaa: Added missing viewBox attributes.
 - asim: Added missing viewBox attributes.
 - grca: Added code and missing template for 3 digit routes.
 - turo: Fixed code to accurately display all routes (one was not showing up).
 - idnt: Fixed code to accurately display 2 digit numbered routes.

https://github.com/TravelMapping/Web/pull/861

Everything else from Batch 8 looks good.

Offline mapcat

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 1936
  • Last Login:Today at 08:39:24 am
Re: Clinched Routes Highway Shields
« Reply #287 on: August 05, 2025, 06:58:22 pm »
Looking at usasf, which has seen a lot of work lately, I wonder what's the ultimate plan for routes without a unique shield. Will the All American Freeway always be represented by a big green sign with "All Ame Fwy" on it, or will it and others like it eventually have their names spelled out (at least the ones with official, signed names)? Same for cansf and usanp, and probably others I can't think of right now.
Clinched:

Offline Jim

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 3033
  • Last Login:Today at 11:12:54 am
Re: Clinched Routes Highway Shields
« Reply #288 on: Yesterday at 09:14:56 pm »
Fixes for Batch 8:

Forgot to put these up on tmstage last night.  They're up now.

Offline cockroachking

  • Full Member
  • ***
  • Posts: 127
  • Gender: Male
  • Last Login:Today at 11:24:25 am
Re: Clinched Routes Highway Shields
« Reply #289 on: Yesterday at 09:28:08 pm »
Missing parenthesis broke everything. Try again now.

https://github.com/TravelMapping/Web/pull/862

Offline Jim

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 3033
  • Last Login:Today at 11:12:54 am
Re: Clinched Routes Highway Shields
« Reply #290 on: Yesterday at 09:36:58 pm »
Fix is up on tmstage

Offline cockroachking

  • Full Member
  • ***
  • Posts: 127
  • Gender: Male
  • Last Login:Today at 11:24:25 am
Re: Clinched Routes Highway Shields
« Reply #291 on: Yesterday at 09:54:52 pm »
Everything looks good now. Ready to move to main site.