Author Topic: dnkmr: Denmark Margueritruten  (Read 577 times)

0 Members and 1 Guest are viewing this topic.

Offline michih

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 2792
  • Last Login:September 16, 2020, 02:44:31 pm
dnkmr: Denmark Margueritruten
« on: May 01, 2020, 03:00:18 am »
System is ready for peer-review (2512mi): http://travelmapping.net/hb/index.php?sys=dnkmr

Offline si404

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 1332
  • Last Login:Today at 04:05:20 pm
Re: dnkmr: Denmark Margueritruten
« Reply #1 on: July 05, 2020, 06:38:34 am »
Viborg
 - SR519_AstW -> SR519_Ast
 - SR519_AstE -> SR519/535
 - SR517_X - I don't like the choices of X here. _N has the SR517 heading south, _S has the SR517 heading north, there's a W-S concurrency and an E-N one. I think each concurrency should be E-W or N-S (doesn't matter which), and either use different, or use the same pair of cardinal directions but add village names.
 - SR503_W -> SR503_Vej
 - PR52_W -> PR52_S (MR heads west, but PR52 heads south-south-east. Concurrency paired with _N)
 - PR52_S -> PR52_Vin
 - PR26/SR186 is off, and would need to be PR26/186
 - SR503_N -> SR503_W
 - SR180_RanW -> SR180_RanN

Svendborg
 - PR8_W -> PR8_Hor
 - PR8_S -> PR8_Faa or PR43/44
 - PR8_N -> PR8_W (I really don't get how you got _N at all here!)
 - LehVej_W -> LehVej_E (concurrency)
 - LehVej_E -> JuuVej
 - SR305/PR9 -> PR9_E or PR9_Sim
 - add point for SteVej (also SR305) as leads to correctly labelled SteVej_N

There's a systematic issue with your cardinal directions where they just make no sense half the time.
Quote
For the multiplex splits, add a suffix: an underscore followed by a direction letter. The direction letter should match the signed direction the concurrent route is splitting toward. US80_W in the US25 file means that US 80 heads west from US 25 at that point but is concurrent to the east.

If a non-exit-numbered highway is a cross road twice, add an underscored suffix. The direction letter refers to the relative position of the intersection along the route whose file is being made. US90_S is the southern of the two US 90 junctions along US 25, which runs S-N.

If a non-exit-numbered highway is a cross road a third time, a suffixless label is an option.

If more than two points for the same non-exit-numbered cross road are needed, there are two options which can be used in combination with or ignoring the previous options for pairs of identical labels.
1. Use alphabetical suffixes _A, _B, _C, etc.
2. Choose 3-letter suffixes for nearby towns if they are fairly close. The 3-letter suffix should be the first 3 letters of the town name. or a desired 3-letter abbreviation if the name consists of more than one word. Add a suffix with an underscore and those 3 letters.

And also, there's a systematic issue with PRxx/SRyyy points
Quote
Drop the prefix of the second highway if it is more than one character long. A5/A6 becomes A5/A6. I-5/I-6 becomes I-5/6. I-25/US50 becomes I-25/50.

Offline michih

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 2792
  • Last Login:September 16, 2020, 02:44:31 pm
Re: dnkmr: Denmark Margueritruten
« Reply #2 on: July 05, 2020, 10:35:43 am »
There's a systematic issue with your cardinal directions where they just make no sense half the time.

I know. I got this totally wrong when I read the manual in 2015/16.
When the "other" route (concurrent or intersecting) was a W-E route, I used _W + _E. When it was N-S, I used _N + _S route. To be honest, I never changed my way although I read the rule again a few weeks ago - but I should!

And also, there's a systematic issue with PRxx/SRyyy points

I think dnkmr is my first system with 2-letter prefix (eurtr routes in DEU-BY* too) and I was not sure how to deal with PR + SR in a label. I've checked all MR routes for this now: https://github.com/TravelMapping/HighwayData/pull/4029

*Locally fixed.
« Last Edit: July 05, 2020, 10:39:41 am by michih »

Offline michih

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 2792
  • Last Login:September 16, 2020, 02:44:31 pm
Re: dnkmr: Denmark Margueritruten
« Reply #3 on: July 05, 2020, 01:26:28 pm »
Quote
For the multiplex splits, add a suffix: an underscore followed by a direction letter. The direction letter should match the signed direction the concurrent route is splitting toward. US80_W in the US25 file means that US 80 heads west from US 25 at that point but is concurrent to the east.

I've never seen a "signed direction" anywhere except of in NA. Is the whole paragraph meaningless when there are no signed directions?

Just a random example:

Code: [Select]
D124_??? http://www.openstreetmap.org/?lat=45.639890&lon=5.109251
D313 http://www.openstreetmap.org/?lat=45.640102&lon=5.122056
D124/D125 http://www.openstreetmap.org/?lat=45.644014&lon=5.132868

Should it be D123_W since it is first heading west or D124_S since the main direction is south and the other main direction is north? Or - if the rule does not apply lack of direction signs - should I do it as desired?

Offline si404

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 1332
  • Last Login:Today at 04:05:20 pm
Re: dnkmr: Denmark Margueritruten
« Reply #4 on: July 05, 2020, 02:11:15 pm »
It's understable the systematic issue - and thanks for cleaning them up.

When it comes to a "signed direction" when no direction is signed, I've tended to go instinctively with whether its a rough E-W or N-S alignment and then applied that to the concurrency. Circular routes are more absolute directions (eg you had an O_S and O_E and that seemed fine to me), and if there's two concurrencies and it doesn't look silly then you can go with E-W for one, N-S for the other.

Offline si404

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 1332
  • Last Login:Today at 04:05:20 pm
Re: dnkmr: Denmark Margueritruten
« Reply #5 on: August 07, 2020, 09:14:17 am »
yes, I got the hint with your message about your trip to Denmark

Doing this roughly in order of length:

Ærø, Glyngøre, Hurup Thy - all fine

Svendborg
 - HegVej -> HagVej (also PR8Faa)
 - SkeVej is off (also PR44)
 - PR9/44 is slightly off (also PR9, PR44, SR163, SR167, SveMot)
 - SR305_W -> SR305_S ?

Nykøbing
 - does it not start at the ferry?
 - PorVej -> PomVej
 - GroVej_E -> GroVej_S (paired with GroVej_N)
 - GroVej_W -> GroVej_E
 - StovStr_N -> SkovStr_W
 - VanVej_E -> VanVej_S (paired with VanVej_N)
 - VanVej_W -> VanVej_E (concurrency split with the road heading east)
 - SkovStr_W -> SkovStr_Nys or _S
 - SR283_N -> SR283_S
 - SR297 is off (also SR283)
 - SR283_W -> SR283_N
 - KarVan_E -> KarVae_E (also KarVan_W)
 - VarVej is slightly off (also SR289) and check name
 - SR289_E -> SR289_W (concurrency split with road diverging W, not eastern junction)
 - PR9_StoS -> PR9_StoE (paired with _StoW)
 - SR289_W -> SR289_Kar (for Karleby)

Offline michih

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 2792
  • Last Login:September 16, 2020, 02:44:31 pm
Re: dnkmr: Denmark Margueritruten
« Reply #6 on: August 07, 2020, 01:14:23 pm »
yes, I got the hint with your message about your trip to Denmark

Thanks, I really appreciate that you work on this :)

However,... I was not sure whether I could be no. 1 in Denmark. I checked the preview+active column after my last day and saw that I'm still no. 2. When I wrote the report about my trip, I wanted to write that I missed the goal by xx miles but then saw that I'm no. 1 - for active systems. I was quite surprised and just wanted to write this - and that it's only temporary till dnkmr will be active.

Again, thanks for continuing the review! :)

Offline si404

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 1332
  • Last Login:Today at 04:05:20 pm
Re: dnkmr: Denmark Margueritruten
« Reply #7 on: August 07, 2020, 01:30:29 pm »
Aalborg
 - SR190/180 -> SR180 as SR190 doesn't intersect, merely ends.
 - StrVej -> O1_N (also SR180)
 - PriGade -> O1_S (also SR180)
 - OstAlle -> O2 (also SR180)
 - SR507/595 -> SR595
 - MarMolMot -> SR507
 - SR567_E -> SR567_W (concurrency split)
 - SR567_W -> SR567_E (concurrency split)
 - SR567_LogE -> SR533_LogE (SR567 ends here concurrent)
 - SR33_LogN -> SR533_LogW or SR533_LogN
 - SR187_W -> SR187/535 and extend SR535 to this point? If not then SR187_N (paired with SR187_S)
 - SR561_N -> SR561_W
 - SR561_S -> SR561_E
 - SR561_W -> SR561_Ged

Offline michih

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 2792
  • Last Login:September 16, 2020, 02:44:31 pm
Re: dnkmr: Denmark Margueritruten
« Reply #8 on: August 08, 2020, 03:17:38 am »
Just note to self: 7 out of 11 routes are reviewed now (Svendborg twice).

Offline michih

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 2792
  • Last Login:September 16, 2020, 02:44:31 pm
Re: dnkmr: Denmark Margueritruten
« Reply #9 on: August 08, 2020, 03:53:08 am »
- KarVan_E -> KarVae_E (also KarVan_W)

æ is one character, not two!

https://travelmapping.net/devel/manual/wayptlabels.php#latin

Quote
Waypoint labels may never use international characters. Instead, use the closest latin character without a diacritical mark.

https://en.wikipedia.org/wiki/%C3%86

Quote
Æ (minuscule: æ) is a character

Offline si404

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 1332
  • Last Login:Today at 04:05:20 pm
Re: dnkmr: Denmark Margueritruten
« Reply #10 on: August 21, 2020, 08:08:06 am »
Viborg - fine

Esbjerg
 - SR401_KruW -> SR401_Kru
 - LeijVej_N -> LeijVeg_W
 - LeijVej_S -> LeijVeg_N (not a concurrency split)
 - SR401_Far -> SR401_E ? (as concurrency split)
 - PR8_Bur -> PR8_E (as concurrency split and only two intersections with route)
 - PR8_Byl -> PR8_W (as concurrency split and only two intersections with route)
 - SR443 -> SR401/443 (concurrency switch)
 - SR401_Log -> SR401/429 (junction with both routes)
 - add point to match OstEnde at other end of road?
 - PR11/24 -> PR11_N (match concurrent either-side PR24's label)
 - JerVej -> SR191 (also E20)
 - OHavVej -> SR447_E (also E20 without suffix)
 - SR447_E -> SR447_S (paired with SR447_N at other end of concurrency)
 - PR25_W -> PR15_E
 - PR15_E -> PR15/16 or PR15_Rin
 - PR28_S is off
 - StdVej_E -> StdVej_N
 - StdVej_W -> StdVej_S
 - is BaekByVej SR537? (it's signed as such on GSV). If so, add route and relabel point (also SR181, and the PR16/28 point at the other end)
 - BejVej -> BjeVej (also SR181)
 - add point for GjeVej where it meets SR513 (also SR513)
 - ferry terminal looks to have moved in Sprogovej (also SR181)

Offline michih

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 2792
  • Last Login:September 16, 2020, 02:44:31 pm
Re: dnkmr: Denmark Margueritruten
« Reply #11 on: August 21, 2020, 10:17:51 am »
- OHavVej -> SR447_E (also E20 without suffix)
 - SR447_E -> SR447_S (paired with SR447_N at other end of concurrency)

SR447 is a point in use. Keep as alt label. OHavVej -> SR447_Esb

- BejVej -> BjeVej (also SR181)

Already in use for SR181. BejVej -> BjhVej

Offline si404

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 1332
  • Last Login:Today at 04:05:20 pm
Re: dnkmr: Denmark Margueritruten
« Reply #12 on: August 31, 2020, 06:19:14 am »
Odense
 - SR547_N -> SR547_All
 - SR547_W -> SR547_N
 - PR16_W -> PR16/547
 - SR547_S -> SR547_W
 - PR21_N -> PR21_S
 - RooVej -> RodVej
 - SR445_Tor -> SR445_E (paired with _W)
 - SR170/445 -> SR445_W (not a junction where SR170 diverges)
 - SR170_Hod -> SR170_S (paired with _N)
 - SR409_N -> SR409_W (paired with _E)
 - StoVreVej_W -> StoBreVej_W
 - SR453_W -> SR453_N (paired with _S)
 - SR453_N -> SR453_Vin
 - SR445_E -> SR445_Gam
 - SR453_E -> SR453_W
 - SR170/409 -> SR409/461
 - add point on MR and SR442 to corrispond with StaVej_S?
 - YdrVej -> YdreRingVej (also PR28)
 - PR28_FreW -> PR28_FreN
 - remove NorGade_S
 - PR28_FedS -> PR28_FreS
 - SR313_Lun -> SR307/313
 - SR311/329 -> SR311/317 (not a junction with SR329)
 - SR327_N -> SR327_W (paired with SR327_E)
 - SR335_N -> SR335_S
 - SR303/O2 is off (also SR303 and O2Ode)
 - SR167_N -> SR167_E
 - SR335_S -> SR335_W (paired with _E)
 - SR163_W -> SR163_BroN
 - SR163_S -> SR163_BroS
 - SR163_E -> SR163_LanS
 - SR163_N -> SR163_LanN
 - SR301_S -> SR301_E (paired with _W)
 - PR8_N -> PR8/323 ?
 - SR323_N -> SR323_Lin
 - SR301_BirN -> SR301_BirW
 - SR165_N -> SR165_E (paired with _W)
 - SR315_N -> SR315_W (paired with _E)
 - SR315_S -> SR315_N
 - SR165_E -> SR165_N (paired with _S)
 - SR315_W -> SR315_S
 - SR160_E -> SR160_W

Offline michih

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 2792
  • Last Login:September 16, 2020, 02:44:31 pm
Re: dnkmr: Denmark Margueritruten
« Reply #13 on: August 31, 2020, 01:45:54 pm »
Wow! What a mess I've done....

- remove NorGade_S

Why? It corresponds to O_N

Offline si404

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 1332
  • Last Login:Today at 04:05:20 pm
Re: dnkmr: Denmark Margueritruten
« Reply #14 on: August 31, 2020, 05:18:42 pm »
Why? It corresponds to O_N
Then it should be called O_S and intersect with OFre - just like the point right next to it that makes this point superfluous.