Author Topic: SC 31 extended  (Read 88 times)

0 Members and 1 Guest are viewing this topic.

Offline ohroadscholar

  • Newbie
  • *
  • Posts: 2
  • Gender: Male
  • Last Login:September 16, 2020, 08:48:03 pm
SC 31 extended
« on: September 15, 2020, 11:10:00 pm »
SC 31 extension from SC 544 to SC 707 is now open in the Myrtle Beach Area. There are no other exits between 544 and 707.

Offline Markkos1992

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 917
  • Last Login:Yesterday at 07:47:55 pm
Re: SC 31 extended
« Reply #1 on: September 16, 2020, 11:18:59 am »
It looks like it was an issue on our end with moving the route from usanf to usasc.  This was already done when we finished usasc.


Issue: https://forum.travelmapping.net/index.php?topic=104.105

Posts on adding SC 31 extension: https://forum.travelmapping.net/index.php?topic=104.msg16240#msg16240

Fix for SC 31 in usasc:  https://github.com/TravelMapping/HighwayData/pull/4176

mapmikey, as the maintainer for usasc, please make sure everything looks right before marking this as solved.

EDIT:  Jim requested on Github that your approval be placed here as well. 



« Last Edit: September 16, 2020, 06:38:36 pm by Markkos1992 »

Offline mapmikey

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 575
  • Last Login:Today at 10:02:03 am
    • Co-curator Virginia Highways Project
Re: SC 31 extended
« Reply #2 on: September 17, 2020, 09:09:41 am »
After looking at the github conversation, I believe I am being asked if it is ok for you guys to make the change to get SC 31 fully in the SC State Highway list.

The way I do updates for any of my states is to copy/paste the route waypoints off the github file for the route, make the changes in notepad and save on my PC, then when all changes are done, e-mail them to Jim.

I do it this way to ensure I don't unintentionally undo a change somebody else might have made with or without my knowledge.

So my repository is only good for dire emergency - as in the github site completely loses the file and cannot be recovered.

Short answer:  yes...please make the fix to SC 31

Offline Jim

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 1896
  • Last Login:Today at 07:56:41 pm
Re: SC 31 extended
« Reply #3 on: September 17, 2020, 10:50:41 am »
Great - I'll merge it in tonight.

Offline Markkos1992

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 917
  • Last Login:Yesterday at 07:47:55 pm
Re: SC 31 extended
« Reply #4 on: September 17, 2020, 11:34:00 am »
Quote
I do it this way to ensure I don't unintentionally undo a change somebody else might have made with or without my knowledge.

I did not even use your repository.  I used the overall master usanf file that was leftover for SC 31.

Offline mapmikey

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 575
  • Last Login:Today at 10:02:03 am
    • Co-curator Virginia Highways Project
Re: SC 31 extended
« Reply #5 on: September 17, 2020, 04:34:42 pm »
Quote
I do it this way to ensure I don't unintentionally undo a change somebody else might have made with or without my knowledge.

I did not even use your repository.  I used the overall master usanf file that was leftover for SC 31.

I'm apparently using the term repository for the wrong thing.  I mean the repository on my PC at home.  If I have access to some other repository on Github I am ignorant of it.

Offline Markkos1992

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 917
  • Last Login:Yesterday at 07:47:55 pm
Re: SC 31 extended
« Reply #6 on: September 17, 2020, 05:04:32 pm »
You are correct.  I was thinking about Github.  I am sure you have a Github repository, but I doubt with the way you submit files that it was ever used.