Author Topic: OR: OR39 point on OR 39  (Read 4115 times)

0 Members and 1 Guest are viewing this topic.

Offline Jim

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 2856
  • Last Login:Yesterday at 10:03:07 pm
OR: OR39 point on OR 39
« on: June 04, 2022, 10:35:42 pm »
Looks like there are two OR 39's that intersect in Altamont, leading to a LABEL_SELFREF datacheck error.  I haven't kept up with the best practice here.  Should the point be renamed or the datacheck error be marked as FP?

Offline Bickendan

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 553
  • Last Login:November 22, 2024, 09:47:18 pm
Re: OR: OR39 point on OR 39
« Reply #1 on: June 05, 2022, 04:14:26 am »
I'd have to check what OR 223's labels in Dallas are for its identical situation is.

Offline michih

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 4858
  • Last Login:Yesterday at 08:59:49 pm
Re: OR: OR39 point on OR 39
« Reply #2 on: June 05, 2022, 04:33:16 am »
I haven't kept up with the best practice here.

OR39: OR39 -> OR39Kla
OR39Kla: OR39 should be marked FP

Offline rickmastfan67

  • TM Collaborator (A)
  • Hero Member
  • *****
  • Posts: 2064
  • Gender: Male
  • Last Login:Today at 12:20:42 am
Re: OR: OR39 point on OR 39
« Reply #3 on: June 05, 2022, 05:15:16 am »
I haven't kept up with the best practice here.

OR39: OR39 -> OR39Kla
OR39Kla: OR39 should be marked FP

Did the same with FL-295 & FL-295WPe.
https://travelmapping.net/hb/showroute.php?r=fl.fl295
https://travelmapping.net/hb/showroute.php?r=fl.fl295wpe

Offline Jim

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 2856
  • Last Login:Yesterday at 10:03:07 pm
Re: OR: OR39 point on OR 39
« Reply #4 on: June 05, 2022, 09:06:35 am »
Thanks, updated the labels:

https://github.com/TravelMapping/HighwayData/commit/cff7b13fcbcdea202f773b12ef6580580e380725

Not touching OR 223 but it might need some tweaks.

Offline yakra

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 4422
  • Last Login:November 11, 2024, 12:50:03 pm
  • I like C++
Re: OR: OR39 point on OR 39
« Reply #5 on: June 05, 2022, 10:18:30 am »
OR39: OR39 -> OR39Kla
Yes.
OR39Kla: OR39 should be marked FP
This doesn't get flagged as an error anymore, so there's nothing to mark FP. :)

Did the same with FL-295 & FL-295WPe.
https://travelmapping.net/hb/showroute.php?r=fl.fl295
https://travelmapping.net/hb/showroute.php?r=fl.fl295wpe
This matches best practice. Here, there's a graph connection and the label matches what's expected from the .list name, so siteupdate doesn't flag an error here anymore. The FP entry was removed when the LABEL_SELFREF changes were made.

I haven't kept up with the best practice here.  Should the point be renamed or the datacheck error be marked as FP?
There will still be the occasional FP, but these are far fewer than before. Most of the cases that used to be FPs are no longer flagged as errors at all now.
For items that do get flagged, the Info column on the datacheck page indicates the underlying cause, linking to the bullet points here for info about what can be done to fix an error before marking FP.
Most of the time, there will be another fix available other than marking FP. (In fact, I believe only the NO_COLOC subtype should ever need to be marked FP.)
So yes, OR39 -> OR39Kla was the right thing to do here.
Sri Syadasti Syadavaktavya Syadasti Syannasti Syadasti Cavaktavyasca Syadasti Syannasti Syadavatavyasca Syadasti Syannasti Syadavaktavyasca

Offline michih

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 4858
  • Last Login:Yesterday at 08:59:49 pm
Re: OR: OR39 point on OR 39
« Reply #6 on: June 05, 2022, 10:45:13 am »
OR39Kla: OR39 should be marked FP
This doesn't get flagged as an error anymore, so there's nothing to mark FP. :)

Yep :) One easily forgets those great improvements but only remembers the hassle we had to deal with it manually (FP entries) in the past.

Offline Jim

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 2856
  • Last Login:Yesterday at 10:03:07 pm
Re: OR: OR39 point on OR 39
« Reply #7 on: June 05, 2022, 11:46:41 am »
Thanks, I'm running another update now to see this and my WA NMP fixes/FPs before I move on to another state.