Failed site update 09-17

[si404]

Last night's update failed.

I've fixed the error (the new spur in Missouri's file name in the .csvs was 'mo.mo112sprvie' in a copy-paste-edit error, as it should have been 'mo.mo028sprvie' with 'mo.mo112sprroa' being removed).

If the update is run again, it will work (I've run datacheck.sh on it)

[Jim]

Thanks, re-running now.  That was my mistake, I didn't use the updated CSV files that Highway63 sent because they didn't have the standard header line and I made a copy-paste error.

[Highway63]

I see where I made the typo but apparently I am missing something else.

I seem to recall being told, way long ago, that the first line in the plain CSV file did not matter. I thought it was a perfect place to park a "last modified" message. Now, in the first line of the usamo_con.csv, I have this header, which IS supposed to be standardized:

systemName;route;banner;groupName;roots

If the first line in the state csv header (usamo.csv) IS supposed to be standard, what is it? Or is it just my copy and paste typo that screwed things up?

[yakra]

The first .csv line is ignored, and a "last modified" message should not cause problems.
I haven't looked at the file in question, but I believe it'd just be the copy-paste typo that screwed things up.

[michih]

@yakra:

That was my mistake, I didn't use the updated CSV files that Highway63 sent because they didn't have the standard header line and I made a copy-paste error.

[yakra]

Jim's typo then, not Highway63's.
I assume Jim just chose to not use that file for the sake of uniformity of the headers, but header lines are indeed ignored:
https://github.com/TravelMapping/DataProcessing/blob/1e7d3ef1c544a1ba2297f0ee17b606414bd79a91/siteupdate/python-teresco/siteupdate.py#L1338-L1359

[Jim]

Yes, my error.

As far as what's in the header line, I like having the field names there as that's kind of the standard format for CSVs.  Plus, we have git history to give us versions and timestamps.  But I don't care enough about that to force anyone to have files they're responsible for to conform to what I prefer.