I synced my branch up with the master this morning and ran datacheck.sh on it to see if I could find the error. It worked successfully with no errors found.
I don't know what the problem is then.
Weird.
The fix wasn't committed until after this post.
Looks like last night's update failed. It seems to still be going.
I assume you saw the red "update in progress" banner atop one of the pages.
This is triggered by the presence of the
dbupdating file created during the site update process. If siteupdate.py fails,
localupdate.sh exits without
deleting the file.
I see few different ways to deal with this:
1. No-build.
2. Create a different file upon failure, which the web pages can detect and produce a new banner, "most recent site update failed" or somesuch.
3. Just quietly delete the
dbupdating file upon failure.
4. Remove the
dbupdating / banner functionality altogether. Without looking into it, I assume this predates the switch to the two-database (TravelMapping, TravelMappingCopy) model, and isn't really necessary anymore as when an update completes we switch seamlessly from the old to new DB and life goes on for site users.
The downside to #3-4 is it's a more transparent failure mode. Maybe an
email notification for failed updates would be a good idea.
