Travel Mapping

Highway Data Discussion => In-progress Highway Systems & Work => Topic started by: michih on June 04, 2025, 03:19:33 pm

Title: gbnmkgr: Milton Keynes Grid Roads
Post by: michih on June 04, 2025, 03:19:33 pm: The system has 22 routes for 84 miles. It's in preview for almost 3 years now, and ready for review. I'll do the review in the coming weeks but anyone is welcome to report issues.

https://travelmapping.net/hb/index.php?sys=gbnmkgr

Quote from: si404 on February 17, 2025, 02:29:51 pm
gbnmkgr* and jeyc can be reviewed and won't take long to do so either.

*V2 might need a short northern extension to a new development that'll look into.
Title: Re: gbnmkgr: Milton Keynes Grid Roads
Post by: si404 on June 05, 2025, 07:35:31 am: Something has gone wrong with the TMgray colour that it doesn't show up in mapview.

(and I did have to extend V2)
Title: Re: gbnmkgr: Milton Keynes Grid Roads
Post by: michih on June 05, 2025, 12:57:17 pm: Quote from: si404 on June 05, 2025, 07:35:31 am
Something has gone wrong with the TMgray colour that it doesn't show up in mapview.

I don't get it. I saw the lines on mapview yesterday but it doesn't work today :o

https://travelmapping.net/user/mapview.php?u=michih&sys=gbnmkgr
Title: Re: gbnmkgr: Milton Keynes Grid Roads
Post by: si404 on June 05, 2025, 01:40:54 pm: Checking other systems, it's not the grey.
Title: Re: gbnmkgr: Milton Keynes Grid Roads
Post by: michih on June 05, 2025, 01:51:37 pm: There is no change to the web repo on github for over a week but Jim might have changed something directly on the production server?
Title: Re: gbnmkgr: Milton Keynes Grid Roads
Post by: Jim on June 05, 2025, 04:01:41 pm: Mapview code draws segments in order of tiers 5, 4, 3, 2, 1. This is a tier 6, and looks to be the first one ever. I changed that loop temporarily on the production server and this system's routes are showing for me. I can fix that code so it draws from whatever the highest tier in existence is down to 1 assuming this was intentionally made a tier 6 system.
Title: Re: gbnmkgr: Milton Keynes Grid Roads
Post by: Jim on June 05, 2025, 04:15:04 pm: Non-TM comment: I found it interesting to read about this city and its road grid.
Title: Re: gbnmkgr: Milton Keynes Grid Roads
Post by: si404 on June 05, 2025, 05:23:31 pm: Quote from: Jim on June 05, 2025, 04:01:41 pm
Mapview code draws segments in order of tiers 5, 4, 3, 2, 1. This is a tier 6, and looks to be the first one ever. I changed that loop temporarily on the production server and this system's routes are showing for me. I can fix that code so it draws from whatever the highest tier in existence is down to 1 assuming this was intentionally made a tier 6 system.
I guessed it was that, so I brought it back to tier 5 (which it left as a review comment). But I can take it back to tier 6 if the problem is fixed to.
Title: Re: gbnmkgr: Milton Keynes Grid Roads
Post by: Jim on June 05, 2025, 09:44:11 pm: https://github.com/TravelMapping/Web/issues/821

I should be able to do this quickly.
Title: Re: gbnmkgr: Milton Keynes Grid Roads
Post by: michih on June 06, 2025, 12:58:40 pm: I'm 100% sure that it worked on Wednesday. It works again now. Have you fixed it today?
Title: Re: gbnmkgr: Milton Keynes Grid Roads
Post by: Jim on June 06, 2025, 01:33:43 pm: Quote from: michih on Yesterday at 12:58:40 pm
I'm 100% sure that it worked on Wednesday. It works again now. Have you fixed it today?

My temp fix is still on the production server. I am working on a better fix today.
Title: Re: gbnmkgr: Milton Keynes Grid Roads
Post by: Jim on June 06, 2025, 02:05:14 pm: I have a candidate good fix up on tmdevel.teresco.org and it looks like things work. I just changed the system's tier back to 6 for testing. I'll put this live on the server unless someone notices a problem with it on tmdevel soon.
Title: Re: gbnmkgr: Milton Keynes Grid Roads
Post by: Jim on June 06, 2025, 05:15:16 pm: FYI, this is on the production server now, and the tmdevel server is moving on to test some other changes I'm working on today.