Travel Mapping

Highway Data Discussion => In-progress Highway Systems & Work => Completed Highway Systems Threads => Topic started by: michih on June 04, 2025, 03:19:33 pm

Title: gbnmkgr: Milton Keynes Grid Roads
Post by: michih on June 04, 2025, 03:19:33 pm
The system has 22 routes for 84 miles. It's in preview for almost 3 years now, and ready for review. I'll do the review in the coming weeks but anyone is welcome to report issues.

https://travelmapping.net/hb/index.php?sys=gbnmkgr

gbnmkgr* and jeyc can be reviewed and won't take long to do so either.

*V2 might need a short northern extension to a new development that'll look into.
Title: Re: gbnmkgr: Milton Keynes Grid Roads
Post by: si404 on June 05, 2025, 07:35:31 am
Something has gone wrong with the TMgray colour that it doesn't show up in mapview.

(and I did have to extend V2)
Title: Re: gbnmkgr: Milton Keynes Grid Roads
Post by: michih on June 05, 2025, 12:57:17 pm
Something has gone wrong with the TMgray colour that it doesn't show up in mapview.

I don't get it. I saw the lines on mapview yesterday but it doesn't work today :o

https://travelmapping.net/user/mapview.php?u=michih&sys=gbnmkgr
Title: Re: gbnmkgr: Milton Keynes Grid Roads
Post by: si404 on June 05, 2025, 01:40:54 pm
Checking other systems, it's not the grey.
Title: Re: gbnmkgr: Milton Keynes Grid Roads
Post by: michih on June 05, 2025, 01:51:37 pm
There is no change to the web repo on github for over a week but Jim might have changed something directly on the production server?
Title: Re: gbnmkgr: Milton Keynes Grid Roads
Post by: Jim on June 05, 2025, 04:01:41 pm
Mapview code draws segments in order of tiers 5, 4, 3, 2, 1.  This is a tier 6, and looks to be the first one ever.  I changed that loop temporarily on the production server and this system's routes are showing for me.  I can fix that code so it draws from whatever the highest tier in existence is down to 1 assuming this was intentionally made a tier 6 system.
Title: Re: gbnmkgr: Milton Keynes Grid Roads
Post by: Jim on June 05, 2025, 04:15:04 pm
Non-TM comment: I found it interesting to read about this city and its road grid.
Title: Re: gbnmkgr: Milton Keynes Grid Roads
Post by: si404 on June 05, 2025, 05:23:31 pm
Mapview code draws segments in order of tiers 5, 4, 3, 2, 1.  This is a tier 6, and looks to be the first one ever.  I changed that loop temporarily on the production server and this system's routes are showing for me.  I can fix that code so it draws from whatever the highest tier in existence is down to 1 assuming this was intentionally made a tier 6 system.
I guessed it was that, so I brought it back to tier 5 (which it left as a review comment). But I can take it back to tier 6 if the problem is fixed to.
Title: Re: gbnmkgr: Milton Keynes Grid Roads
Post by: Jim on June 05, 2025, 09:44:11 pm
https://github.com/TravelMapping/Web/issues/821

I should be able to do this quickly.
Title: Re: gbnmkgr: Milton Keynes Grid Roads
Post by: michih on June 06, 2025, 12:58:40 pm
I'm 100% sure that it worked on Wednesday. It works again now. Have you fixed it today?
Title: Re: gbnmkgr: Milton Keynes Grid Roads
Post by: Jim on June 06, 2025, 01:33:43 pm
I'm 100% sure that it worked on Wednesday. It works again now. Have you fixed it today?

My temp fix is still on the production server.  I am working on a better fix today.
Title: Re: gbnmkgr: Milton Keynes Grid Roads
Post by: Jim on June 06, 2025, 02:05:14 pm
I have a candidate good fix up on tmdevel.teresco.org and it looks like things work.  I just changed the system's tier back to 6 for testing.  I'll put this live on the server unless someone notices a problem with it on tmdevel soon.
Title: Re: gbnmkgr: Milton Keynes Grid Roads
Post by: Jim on June 06, 2025, 05:15:16 pm
FYI, this is on the production server now, and the tmdevel server is moving on to test some other changes I'm working on today.
Title: Re: gbnmkgr: Milton Keynes Grid Roads
Post by: michih on June 10, 2025, 02:07:42 pm
H1:
Add shaping point to A5 and A422 to avoid overlapping H1


H5:
Add wp for partial GSJ west of A4146, also for A509


H8:
B4034_W -> B4034_Sne ?
Add wp for GSJ west of WadLn


H9:
Add wp for Newport Rd - west of V10 -, heading to A421's GSJ


H10:
V11 -> A4146_N


V6:
V6 -> H6


General:
- please check https://travelmapping.net/devel/datacheck.php?rg=eng&hide=VISIBLE_DISTANCE
- please check https://travelmapping.net/logs/unmatchedfps.log
- please change tier 5 -> 6 since some wp labels had to be changed (B -> H/V) if it would remain tier 5

Open:
Check V route wp labels in HB when showroute.php works again.
Title: Re: gbnmkgr: Milton Keynes Grid Roads
Post by: si404 on June 11, 2025, 03:22:44 am
- please change tier 5 -> 6 since some wp labels had to be changed (B -> H/V) if it would remain tier 5
If tier 6 is working, I will change it back. However I don't know why, if this system was tier 5, it would overdo the labels from the other tier 5 system.
Title: Re: gbnmkgr: Milton Keynes Grid Roads
Post by: Jim on June 11, 2025, 08:56:06 am
Tier 6 systems should not be a problem any longer on Mapview.  It would be good to give a thorough look elsewhere to make sure that upper limit of 5 wasn't hard-coded anywhere else.
Title: Re: gbnmkgr: Milton Keynes Grid Roads
Post by: michih on June 11, 2025, 12:26:28 pm
V4:
H10/V6 -> V6/H10 ? since the route is V too.


V6:
H10/V4 -> V4/H10 ?
Title: Re: gbnmkgr: Milton Keynes Grid Roads
Post by: michih on June 11, 2025, 12:29:54 pm
- please change tier 5 -> 6 since some wp labels had to be changed (B -> H/V) if it would remain tier 5
If tier 6 is working, I will change it back. However I don't know why, if this system was tier 5, it would overdo the labels from the other tier 5 system.

If gbnb and gbnmkgr would both be tier 5, the gbnmkgr Bxxx labels should be Hxxx or Vxxx labels since that's the primary prefix for that system. I think that how we went with nlds system. I just fail to find examples...
Title: Re: gbnmkgr: Milton Keynes Grid Roads
Post by: si404 on June 11, 2025, 01:37:01 pm
H5:
Add wp for partial GSJ west of A4146, also for A509
What partial GSJ? There's two Js. LILOs. But there's nothing remotely like a partial GSJ there.
Quote
H8:
Add wp for GSJ west of WadLn
There's no grade separated junction there. Again, it's just some LILOs with zero overbridge.

If these side roads were important, then rather than a LILO, there would be some way of accessing the other direction.
Title: Re: gbnmkgr: Milton Keynes Grid Roads
Post by: michih on June 11, 2025, 02:48:32 pm
Fair enough...
Title: Re: gbnmkgr: Milton Keynes Grid Roads
Post by: michih on June 12, 2025, 01:58:39 pm
https://github.com/TravelMapping/HighwayData/pull/8427

Looks good. Ready to go active I think :)