Author Topic: Scrollable Mapview on tmtest  (Read 1879 times)

0 Members and 1 Guest are viewing this topic.

Offline Jim

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 1897
  • Last Login:Today at 04:52:03 pm
Scrollable Mapview on tmtest
« on: May 24, 2020, 10:05:04 pm »
My first major Summer 2020 TM/METAL project has been to implement one of the features I've always wanted most myself: a version of Mapview that automatically loads all relevant TM data that's visible as the map is panned and zoomed.  I'm calling it "Scrollable Mapview."  I've made a ton of progress in the last several days and it's ready for some testing and feedback.

http://tmtest.teresco.org/user/mapview.php?v

Add a &u=username QS parameter if you also would like it to reflect your own clinched travels.

I'm most interested in hearing what you think so far and to report any problems you notice.  Please first check to see if it's something I already have noted with an Issue in the Web repository.  You can report problems by commenting on existing or creating new Issues there or by replying in this thread.

I'd also welcome general testing of existing Mapview functionality on tmtest and any other use there to make sure my work on the new Mapview functionality hasn't broken anything else.  It's pretty much a whole different codebase than the existing Mapview, so I'm confident I haven't broken much.  I'd like to fold this version back into the production site before continuing much further, which I hope will involve using the new codebase to replicate/improve existing Mapview functionality as well.
« Last Edit: May 24, 2020, 10:07:07 pm by Jim »

Offline Jim

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 1897
  • Last Login:Today at 04:52:03 pm
Re: Scrollable Mapview on tmtest
« Reply #1 on: May 24, 2020, 10:14:31 pm »
Note that the tmtest server doesn't switch databases to minimize disruptions during site updates, so if you notice problems with data not loading, try back in a few minutes as the DB update might be in progress.

Offline Jim

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 1897
  • Last Login:Today at 04:52:03 pm
Re: Scrollable Mapview on tmtest
« Reply #2 on: May 24, 2020, 10:19:08 pm »
Also, I'd like to call a bit of attention to the fact that waypoint markers are not shown in Mapview by default, but in the existing production version can be shown under the "Show Map Options" of the dropdown menu on the upper right.  The Scrollable Mapview implementation does not include waypoints, so can't show the markers.  If you care, please weigh in at https://github.com/TravelMapping/Web/issues/425 .

Offline mapcat

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 1000
  • Last Login:August 23, 2020, 06:59:50 pm
Re: Scrollable Mapview on tmtest
« Reply #3 on: May 24, 2020, 11:50:09 pm »
https://drive.google.com/open?id=1X2p-NExZVjamjOi9GxGRDjnJZiELf9_D

The concurrency of US 20 & NY 146 shows as unclinched, even though I have 100% of US 20 according to the stats on the right.

This is happening anywhere a clinched route is concurrent with a route I haven't entered into my .list.
« Last Edit: May 25, 2020, 12:01:46 am by mapcat »
Clinched:

Offline michih

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 2799
  • Last Login:Today at 03:46:52 pm

Offline Jim

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 1897
  • Last Login:Today at 04:52:03 pm
Re: Scrollable Mapview on tmtest
« Reply #5 on: May 25, 2020, 08:34:23 am »
https://drive.google.com/open?id=1X2p-NExZVjamjOi9GxGRDjnJZiELf9_D

The concurrency of US 20 & NY 146 shows as unclinched, even though I have 100% of US 20 according to the stats on the right.

This is happening anywhere a clinched route is concurrent with a route I haven't entered into my .list.

Thanks - quick fix is in.  It fixed the couple spots I checked.  Let me know if you see it cropping up elsewhere.

Offline mapcat

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 1000
  • Last Login:August 23, 2020, 06:59:50 pm
Re: Scrollable Mapview on tmtest
« Reply #6 on: May 25, 2020, 08:50:33 am »
Thanks - quick fix is in.  It fixed the couple spots I checked.  Let me know if you see it cropping up elsewhere.

Looks good now.
Clinched:

Offline yakra

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 2821
  • Last Login:Today at 03:38:32 pm
Re: Scrollable Mapview on tmtest
« Reply #7 on: May 25, 2020, 12:29:21 pm »
Gotta wonder how that happened, as siteupdate takes care of marking concurrencies as clinched, and all that info makes it into the DB.
I couldn't satisfy my curiosity on GitHub, as the code's not there yet. Which makes sense, with it all still undergoing heavy revision.

Offline michih

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 2799
  • Last Login:Today at 03:46:52 pm
Re: Scrollable Mapview on tmtest
« Reply #8 on: May 25, 2020, 12:34:11 pm »
I couldn't satisfy my curiosity on GitHub, as the code's not there yet. Which makes sense, with it all still undergoing heavy revision.

It is there: https://github.com/TravelMapping/Web/commit/5294e738d9792cb71ec926bc5ef36c30c653563a

Offline yakra

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 2821
  • Last Login:Today at 03:38:32 pm
Re: Scrollable Mapview on tmtest
« Reply #9 on: May 25, 2020, 12:57:42 pm »

Offline Jim

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 1897
  • Last Login:Today at 04:52:03 pm
Re: Scrollable Mapview on tmtest
« Reply #10 on: May 25, 2020, 01:15:47 pm »
Gotta wonder how that happened, as siteupdate takes care of marking concurrencies as clinched, and all that info makes it into the DB.
I couldn't satisfy my curiosity on GitHub, as the code's not there yet. Which makes sense, with it all still undergoing heavy revision.

As you found, the "scrolltest" branch has the latest.  I was indexing into an array to find out if the segment was clinched, but that array's indices had a different meaning.  Since no convenient array exists, I added a field to the connections so it was readily available when needed.

Offline Jim

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 1897
  • Last Login:Today at 04:52:03 pm
Re: Scrollable Mapview on tmtest
« Reply #11 on: May 29, 2020, 10:41:12 pm »
There's a new version up on tmtest that has stats for both the overall route and the visible portion of the route in the routes table.  Looking for everyone's impressions of this change.

Offline si404

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 1333
  • Last Login:Today at 02:40:18 pm
Re: Scrollable Mapview on tmtest
« Reply #12 on: May 30, 2020, 05:07:30 am »
It's unsurprisingly slow-loading, but looks excellent.

Thanks for this.

Offline mapcat

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 1000
  • Last Login:August 23, 2020, 06:59:50 pm
Re: Scrollable Mapview on tmtest
« Reply #13 on: May 30, 2020, 01:09:51 pm »
I like the table enhancements. Unfortunately I can still break it by panning too quickly.

https://drive.google.com/file/d/1SmZTwLbO9Tk7Y-a2gfRH0HLii2AR9Jjm/view?usp=sharing

I loaded an image centered on Pittsburgh, and the route table was correct. I zoomed out and panned west to Los Angeles without waiting for the route table to update. I didn't count how many times I clicked and dragged, but it must have been about 12-15. I zoomed in to the view shown in the image, and watched the route table slowly update with routes progressively farther west. It regenerated 10 times before the segments finally appeared, but never managed to show the routes actually in LA (in the image you can see that it quit after getting to Arizona). I left it alone while I uploaded the screenshot and it's now showing routes in Maryland and NYC, even though I never panned east after I loaded the Pittsburgh map (although I initially got to Pittsburgh by panning west from the mapview accessed by the link in the first post, centered at Siena).

Could you delay updating the map and route table by 1-2 seconds, to avoid loading any information while the user is still repositioning the map? Is that what you meant by "debouncing" in https://github.com/TravelMapping/Web/issues/423?
« Last Edit: May 30, 2020, 01:18:52 pm by mapcat »
Clinched:

Offline Jim

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 1897
  • Last Login:Today at 04:52:03 pm
Re: Scrollable Mapview on tmtest
« Reply #14 on: May 30, 2020, 02:36:27 pm »
Yes, @mapcat, I believe the problem you describe will be addressed by debouncing.  I'm also looking into ways to speed the queries themselves, so more frequent reloads will not be so much of a problem.