Author Topic: Shading table entries based on traveled %  (Read 464 times)

0 Members and 1 Guest are viewing this topic.

Offline Jim

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 1896
  • Last Login:Yesterday at 10:51:04 pm
Shading table entries based on traveled %
« on: June 03, 2020, 03:01:06 pm »
The first implementation for CHM-like shading of table backgrounds to indicate percentage of a route traveled is now on the Scrollable Mapview on tmtest:

http://tmtest.teresco.org/user/mapview.php?v

I chose colors similar to what I remember from CHM.  They range from red for 0% up through oranges, yellows, greens, to blue for 100%.  Lightness value (in the HSL color scheme) is also decreased for 0% and 100% values to make them stand out a bit from close to 0% and close to 100%.

I'll add it to more of the tables throughout the site.  For now, I'm interested in hearing if this color scheme is good, or maybe I should make everything a little darker and use white text, or something else entirely.

Related to https://github.com/TravelMapping/Web/issues/440

Offline michih

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 2799
  • Last Login:Yesterday at 02:55:24 pm
Re: Shading table entries based on traveled %
« Reply #1 on: June 03, 2020, 03:10:11 pm »
Like it!

0% and 100% are something special. Maybe both should get darker colors and white text. 0.01% and 99.99% should remain black though.

Offline Jim

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 1896
  • Last Login:Yesterday at 10:51:04 pm
Re: Shading table entries based on traveled %
« Reply #2 on: June 03, 2020, 04:39:19 pm »
Also now functional on http://tmtest.teresco.org/user/

Offline mapcat

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 1000
  • Last Login:August 23, 2020, 06:59:50 pm
Re: Shading table entries based on traveled %
« Reply #3 on: June 03, 2020, 04:39:42 pm »
Yeah, this is good. I agree with michih that 0% and 100% should be highlighted more, and think his suggestion of white text on darker/more vivid colors for those would work well.

Also, the system headings in the table should be white or grey now, instead of light green/light yellow. IMO it's not necessary to differentiate between active and preview systems everywhere.
« Last Edit: June 03, 2020, 04:49:30 pm by mapcat »
Clinched:

Offline Jim

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 1896
  • Last Login:Yesterday at 10:51:04 pm
Re: Shading table entries based on traveled %
« Reply #4 on: June 03, 2020, 04:55:49 pm »
Yeah, this is good. I agree with michih that 0% and 100% should be highlighted more, and think his suggestion of white text on darker/more vivid colors for those would work well.

Thanks.  I'll gather more opinions on it and it should be easy enough to change as we prefer.

Quote
Also, the system headings in the table should be white or grey now, instead of light green/light yellow. IMO it's not necessary to differentiate between active and preview systems everywhere.

I can go either way on this (and the same elsewhere on the site where we color things based on active/preview/devel), and would like to hear opinions.

Offline mapcat

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 1000
  • Last Login:August 23, 2020, 06:59:50 pm
Re: Shading table entries based on traveled %
« Reply #5 on: June 03, 2020, 05:21:17 pm »
I can go either way on this (and the same elsewhere on the site where we color things based on active/preview/devel), and would like to hear opinions.
If differentiation is necessary, could you try light green/light yellow text on a black background for the system headings?

And devel should still not be showing up in this table, correct?
Clinched:

Offline Jim

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 1896
  • Last Login:Yesterday at 10:51:04 pm
Re: Shading table entries based on traveled %
« Reply #6 on: June 03, 2020, 05:49:30 pm »
And devel should still not be showing up in this table, correct?

The devel routes should be ignored by everything except the Highway Browser.  Please report if you see them cropping up anywhere else.

Offline yakra

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 2821
  • Last Login:Yesterday at 10:08:28 pm
Re: Shading table entries based on traveled %
« Reply #7 on: June 03, 2020, 07:06:35 pm »
The devel routes should be ignored by everything except the Highway Browser.  Please report if you see them cropping up anywhere else.
http://forum.travelmapping.net/index.php?topic=3640.msg19062#msg19062

Offline Jim

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 1896
  • Last Login:Yesterday at 10:51:04 pm
Re: Shading table entries based on traveled %
« Reply #8 on: June 03, 2020, 07:23:33 pm »
region.php and system.php on tmtest now have the background colors on their tables.

Offline mapcat

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 1000
  • Last Login:August 23, 2020, 06:59:50 pm
Re: Shading table entries based on traveled %
« Reply #9 on: June 03, 2020, 08:23:13 pm »
New(?) bug: something hinky with the clinched % calculations.

https://drive.google.com/file/d/1SQjPO08fbYsGCnPbU6coQ3Jqj1PJWKok/view

Note US 9W, route overall: 129.14 out of 129.15. Yet I'm credited with 129.15 out of 129.15 here: http://tmtest.teresco.org/hb/?units=miles&u=mapcat&r=ny.us009w. And I'm credited with 129.14 out of 129.14 here: http://tmtest.teresco.org/user/mapview.php?units=miles&u=mapcat&rte=US9W

FWIW my .list entries are:

NJ US9W I-95 NJ/NY
NY US9W NJ/NY US9
Clinched:

Offline Jim

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 1896
  • Last Login:Yesterday at 10:51:04 pm
Re: Shading table entries based on traveled %
« Reply #10 on: June 03, 2020, 08:23:53 pm »
And finally the HB, stat.php, and topstats.php.

I think that's everywhere.  I'll give it a day or two for feedback then get it on the production site.

Offline Jim

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 1896
  • Last Login:Yesterday at 10:51:04 pm
Re: Shading table entries based on traveled %
« Reply #11 on: June 03, 2020, 08:30:50 pm »
New(?) bug: something hinky with the clinched % calculations.

https://drive.google.com/file/d/1SQjPO08fbYsGCnPbU6coQ3Jqj1PJWKok/view

Note US 9W, route overall: 129.14 out of 129.15. Yet I'm credited with 129.15 out of 129.15 here: http://tmtest.teresco.org/hb/?units=miles&u=mapcat&r=ny.us009w. And I'm credited with 129.14 out of 129.14 here: http://tmtest.teresco.org/user/mapview.php?units=miles&u=mapcat&rte=US9W

FWIW my .list entries are:

NJ US9W I-95 NJ/NY
NY US9W NJ/NY US9


Opened an Issue

https://github.com/TravelMapping/Web/issues/464

Offline michih

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 2799
  • Last Login:Yesterday at 02:55:24 pm
Re: Shading table entries based on traveled %
« Reply #12 on: June 04, 2020, 12:02:40 pm »
I need to get used to it (again, since it was like that or even more colored on CHM) but I think that I will like it.

Is the color code obvious or do we need a color legend?
Anywhere on the site or on the manual, e.g. here?

Offline Jim

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 1896
  • Last Login:Yesterday at 10:51:04 pm
Re: Shading table entries based on traveled %
« Reply #13 on: June 04, 2020, 08:59:31 pm »
This and various fixes to recently-reported problems are live on the main site.

I don't know that a manual entry is necessary related to the coloring, but I am open to suggestions on how best to include a legend.