TM fixes following June 2025 upgrade

[Jim]

The main OS upgrades are done and seemed to go well, but now I need to rebuild all the software.  This is where things like new versions of compilers, apache httpd, and php can cause troubles.  This part also takes a while as it needs to reinstall about 500 packages.

[Jim]

We are up and running on the new OS and updated software overall.  My spot checks of functionality all look good.  I have some housekeeping items to take care of that should not cause any disruptions.  Let me know if you notice any problems that might have been caused by the upgrade.

[michih]

showroute doesn't work: https://travelmapping.net/hb/showroute.php?u=null&r=eng.h001

Code: [Select]

Fatal error: Uncaught Error: Call to undefined function ctype_alpha() in /fast/www/tm/lib/tmphpfuncs.php:511 Stack trace: #0 /fast/www/tm/hb/showroute.php(192): tm_validate_root('eng.h001') #1 {main} thrown in /fast/www/tm/lib/tmphpfuncs.php on line 511
Edit: The issue came just 5 minutes before I posted this.
Edit2: same issue on tmdevel: https://tmdevel.teresco.org/hb/showroute.php?u=null&r=eng.h001

[Jim]

Looks like our version of PHP is no longer supported.  Hopefully this won't take long but it has the potential to be a difficult one to handle.

[Jim]

I think there's a really good chance I'm going to break the forum by upgrading things to the supported version of PHP.  Deciding how to proceed.

[Jim]

Upgraded.  There are things broken on both the forum and the main TM site.  I'll see what I can do.

[Jim]

I've fixed all of the problems I have noticed.  Please let me know if you see things not working here on the forum or on the main TM site.  Thanks for your patience.

I'll also leave a note here for lack of a better place that I had to change line 19 of index.php in the forum software to

Code: [Select]

error_reporting(E_ALL);
as the E_STRICT option is no longer supported.  We just need to remember this if we upgrade the forum software and the corresponding fix has not been made in the new version.

[osu-lsu]

FWIW, at the header of the front page for travel mapping is this message:

Warning: Undefined variable $nobigheader in /fast/www/tm/lib/tmheader.php on line 4

[TBKS1]

I get this error on the stat.php page

Code: [Select]

Deprecated: Using ${var} in strings is deprecated, use {$var} instead in /fast/www/tm/stat.php on line 171

Warning: Cannot modify header information - headers already sent by (output started at /fast/www/tm/stat.php:171) in /fast/www/tm/lib/tmphpuser.php on line 33

[Jim]

I believe the two reported errors, along with a few others I discovered with a bit more thorough testing, are now fixed.  Keep the reports coming if you see any problems.

[CoreySamson]

When I click on the user stats page, the table for "Longest Clinched Routes" is not coming up for me.

[Jim]

Thanks - I fixed clinched.php and a couple more things I noticed (including that I hadn't updated tmrail with any of the fixes, and the lack of any active systems there exposed some other things that broke with the upgrade).

[michih]

1. The 'Longest Clinched Routes' table on topstats.php does not work: empty table output.
2. The user cookie does not work as before. e.g. change from user page to stat.php
3. The unit cookie does also not work but I think that this issue already existed before the latest upgrade. e.g. this (similar: this)

[Jim]

Thanks - I have implemented a fix for the top stats table.  Turns out that was a longstanding typo that PHP 7 didn't care about but PHP 8 does.

I'm looking at the cookies, and I think I am on to something.  These problems look to stem from the https conversion years ago but something about PHP 8 is doing extra checking and causing them not to be updated to be carried across on some page transitions.

[Jim]

I have some cookie fixes in.  Old cookies can cause troubles, so please follow these steps if you are noticing any problems with user selections not being persistent across all pages:

- force reload TM
- clear all travelmapping.net cookies saved in your browser

Once you then choose your username from any traveler list, it should be remembered across all page transitions.

Note that you would need to do the same thing on other TM sites if you use the development or staging servers, or if you are a tmrail.teresco.org user.