usanp (U.S. National Park Highways)

[dfilpus]

MD BalWasPkwy: MD201 has a waypoint for MD295/BaltWash, but there is no waypoint on MD295 or BalWasPkwy.

There's a waypoint...it's simply labeled differently because the waypoint is also coincident with US 50.  IMO, the solution here would be to relabel the BalWasPkwy list point to match that of the MD295 list (label it as "US50/201").

MD201 has two waypoints for MD295/BaltWash. The southern one is labeled "US50/295". The northern one is labeled "MD295". It is this northern waypoint on MD201 that has no corresponding waypoint on MD295 or BalWasPkwy.

[si404]

FL MainParkRd: Amp-> End
KY MamCavePkwy:
     GreRivFerRd  -> GreRivRd
     FliRidRd should be moved to the parking lot and renamed End.

MD BalWasPkwy: MD201 has a waypoint for MD295/BaltWash, but there is no waypoint on MD295 or BalWasPkwy.
MS NatTraPkwy:
     US61_PG -> US61_N
     US61_Ad -> US61_S
NC BlueRidPkwy: CirRidRd is not an intersection. Move waypoint to Mt Lyn Lowry viewpoint or make hidden.
NC LinFalRd: LinFalDisCen -> End or VisCen

Done these: https://github.com/TravelMapping/HighwayData/pull/2431

rickmastfan67 (FL), mapcat (KY), froggie (MS), and mapmikey (NC) - I've made changes to roads in your states, but only usanp. MD is no one specific, so my adding a point to MD295 should be fine (though, IIRC, that's not MD295 and needs to be truncated when we activate the system).

[froggie]

^^ Okay, I see which point you're referring to now.  Odd that Tim considered that single ramp a "separate interchange".

[Markkos1992]

(though, IIRC, that's not MD295 and needs to be truncated when we activate the system).

I have always thought that it was MD 295, but it was just unsigned in favor of the Baltimore-Washington Pkwy designation on the portion maintained by the NPS.

[mapcat]

North Capitol St ≠ South Capitol St ≠ East Capitol St.

North Capitol St and South Capitol St mostly follow the same longitude, and would form a continuous street had someone not decided to put a building where the designation changes.

(You modified my post, rather than replied)

Froggie's reply: The building in question came first.  And the two really are different streets.

[mapmikey]

Done these: https://github.com/TravelMapping/HighwayData/pull/2431

rickmastfan67 (FL), mapcat (KY), froggie (MS), and mapmikey (NC) - I've made changes to roads in your states, but only usanp. MD is no one specific, so my adding a point to MD295 should be fine (though, IIRC, that's not MD295 and needs to be truncated when we activate the system).

Acknowledged...thanks

[bhemphill]

It looks like those particular streets were named in the original plan before they or the buildings were built.  https://www.loc.gov/resource/g3850.ct000299/

[dfilpus]

Part 3 of review, by state:

NM DunDr: DuneLifeNatTrl -> DuneLifeTrl
NV WhePeakSceDr: WhePeakSceDr actually starts at waypoint LehCavVisCen. The road that is a continuation of NV 488 into the park is named "Entrance Road". It continues to the Visitor Center. WhePeakSceDr should be truncated to LehCavVisCen -> EntRd. Entrance Road should have its own map.
OK PerRd: This road doesn't really have a concurrency with US 177.
OR CraLakeHwy: Could use a visible waypoint, perhaps at the PCT crossing or Pumice Desert view parking lot?
OR CraLakeRimDr: Could use more visible waypoints, perhaps at Cleetwood Cove parking lot and Cloudcap Viewpoint Road?
PA, SC, SD: No comments.
TN LauCreRd: CadCoveLpRd -> CadCoveLp or CadCoveRd
TN LitRivGorRd: WearCoveGapRd -> WearCoveRd
TX: No comments.

[dfilpus]

Part 4 of review, by state:

UT CubCreRd: QuaVisCen -> UT149
UT KolTerRd: OakVlyRd -> OakValRd
UT NeeSceDr: LockHartRd -> LockRd
UT ZionCynDr: Add waypoint for Zion Lodge.
VA ColPkwy: Add waypoint for North England Street exit to the Royal Palace.
VA SieRd: EFlaVisCen -> VisCen
VA SkyDr: BearDenMtnTrl -> BearDenTrl ; BlaRockGapRd -> BlaRockRd
WA HurRidRd: OlyNPVisCen -> NPVisCen
WA SunParkRd: WhiRivCamRd -> WhiRivRd
WA UppHohRd: HohRainForVC -> VisCen
WY DevTowRd: BelFouRivCamp -> BelFouRd
WY GraLpRd: GibFls - GibFal ; NRimDr -> SRimDr
WY MooWilRd: WhiGraTraRd -> WhiGraRd
WY SEntRd: Technically, US89/191 could be RocMemDr

[the_spui_ninja]

WY DevTowRd: BelFouRivCamp -> BelFouRd

Sorry to butt in, but I think the name of that road is actually Campground Rd: http://crookgrowdev.maps.arcgis.com/apps/webappviewer/index.html?id=7238ec86a82749ff9154ee84734f5c33

[si404]

ping oscar (NM, NV), yakra (OK), Bickendan (OR), mapcat (TN), Duke87 (UT), mapmikey (VA) and compdude787 (WA) as I've changed usanp files in your states per this review.

While we're waiting for Oscar (no hurry) to chime in on the DC issue and make the CA changes, I'll happily receive other review comments.

Like this one:

Sorry to butt in, but I think the name of that road is actually Campground Rd: http://crookgrowdev.maps.arcgis.com/apps/webappviewer/index.html?id=7238ec86a82749ff9154ee84734f5c33

which I've fixed locally, but not added to open pull request.

[froggie]

VA SkyDr: BearDenMtnTrl -> BearDenTrl ; BlaRockGapRd -> BlaRockRd

Where did you get these?  Everything I'm seeing shows the original name labels were correct.

[yakra]

VA SkyDr: BearDenMtnTrl -> BearDenTrl ; BlaRockGapRd -> BlaRockRd

Where did you get these?  Everything I'm seeing shows the original name labels were correct.

These are cases of keeping with the manual's instructions on roads names with >3 words:

If the cross road name has more than 3 words, use one of two options:
1. Pick out the two most important words besides the road type and use only those: Martin Luther King Boulevard becomes MarKingBlvd. Three words in total are included in shortened form.
2. Pick out one important word besides the road type and use it and the initials of the other words: Martin Luther King Boulevard becomes MLKingBlvd. Two words in total are included in shortened form along with initials of the rest.

[froggie]

I saw that as a Tim-quirement from when he was trying to minimize file sizes and such, which became a moot point when we shifted to TM.  I can see it as an optional item, though.

[yakra]

But we're still using the manual, save for a few minor changes such as allowing exit numbers on US Routes. Why throw the baby out with the bathwater...
IMO it's good practice to not let labels get overly long, potentially gunking up things taking up too much real estate onscreen in the HB.
And then, when combining labels into vertex names in the HDX, things start growing much more quickly.