Author Topic: gbnmkgr: Milton Keynes Grid Roads  (Read 1888 times)

0 Members and 1 Guest are viewing this topic.

Offline michih

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 5182
  • Last Login:Today at 12:58:25 pm
gbnmkgr: Milton Keynes Grid Roads
« on: June 04, 2025, 03:19:33 pm »
The system has 22 routes for 84 miles. It's in preview for almost 3 years now, and ready for review. I'll do the review in the coming weeks but anyone is welcome to report issues.

https://travelmapping.net/hb/index.php?sys=gbnmkgr

gbnmkgr* and jeyc can be reviewed and won't take long to do so either.

*V2 might need a short northern extension to a new development that'll look into.

Offline si404

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 2162
  • Last Login:Today at 06:32:23 pm
Re: gbnmkgr: Milton Keynes Grid Roads
« Reply #1 on: Yesterday at 07:35:31 am »
Something has gone wrong with the TMgray colour that it doesn't show up in mapview.

(and I did have to extend V2)

Offline michih

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 5182
  • Last Login:Today at 12:58:25 pm
Re: gbnmkgr: Milton Keynes Grid Roads
« Reply #2 on: Yesterday at 12:57:17 pm »
Something has gone wrong with the TMgray colour that it doesn't show up in mapview.

I don't get it. I saw the lines on mapview yesterday but it doesn't work today :o

https://travelmapping.net/user/mapview.php?u=michih&sys=gbnmkgr

Offline si404

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 2162
  • Last Login:Today at 06:32:23 pm
Re: gbnmkgr: Milton Keynes Grid Roads
« Reply #3 on: Yesterday at 01:40:54 pm »
Checking other systems, it's not the grey.

Offline michih

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 5182
  • Last Login:Today at 12:58:25 pm
Re: gbnmkgr: Milton Keynes Grid Roads
« Reply #4 on: Yesterday at 01:51:37 pm »
There is no change to the web repo on github for over a week but Jim might have changed something directly on the production server?

Offline Jim

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 2936
  • Last Login:Today at 05:20:57 pm
Re: gbnmkgr: Milton Keynes Grid Roads
« Reply #5 on: Yesterday at 04:01:41 pm »
Mapview code draws segments in order of tiers 5, 4, 3, 2, 1.  This is a tier 6, and looks to be the first one ever.  I changed that loop temporarily on the production server and this system's routes are showing for me.  I can fix that code so it draws from whatever the highest tier in existence is down to 1 assuming this was intentionally made a tier 6 system.

Offline Jim

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 2936
  • Last Login:Today at 05:20:57 pm
Re: gbnmkgr: Milton Keynes Grid Roads
« Reply #6 on: Yesterday at 04:15:04 pm »
Non-TM comment: I found it interesting to read about this city and its road grid.

Offline si404

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 2162
  • Last Login:Today at 06:32:23 pm
Re: gbnmkgr: Milton Keynes Grid Roads
« Reply #7 on: Yesterday at 05:23:31 pm »
Mapview code draws segments in order of tiers 5, 4, 3, 2, 1.  This is a tier 6, and looks to be the first one ever.  I changed that loop temporarily on the production server and this system's routes are showing for me.  I can fix that code so it draws from whatever the highest tier in existence is down to 1 assuming this was intentionally made a tier 6 system.
I guessed it was that, so I brought it back to tier 5 (which it left as a review comment). But I can take it back to tier 6 if the problem is fixed to.

Offline Jim

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 2936
  • Last Login:Today at 05:20:57 pm
Re: gbnmkgr: Milton Keynes Grid Roads
« Reply #8 on: Yesterday at 09:44:11 pm »
https://github.com/TravelMapping/Web/issues/821

I should be able to do this quickly.

Offline michih

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 5182
  • Last Login:Today at 12:58:25 pm
Re: gbnmkgr: Milton Keynes Grid Roads
« Reply #9 on: Today at 12:58:40 pm »
I'm 100% sure that it worked on Wednesday. It works again now. Have you fixed it today?

Offline Jim

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 2936
  • Last Login:Today at 05:20:57 pm
Re: gbnmkgr: Milton Keynes Grid Roads
« Reply #10 on: Today at 01:33:43 pm »
I'm 100% sure that it worked on Wednesday. It works again now. Have you fixed it today?

My temp fix is still on the production server.  I am working on a better fix today.

Offline Jim

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 2936
  • Last Login:Today at 05:20:57 pm
Re: gbnmkgr: Milton Keynes Grid Roads
« Reply #11 on: Today at 02:05:14 pm »
I have a candidate good fix up on tmdevel.teresco.org and it looks like things work.  I just changed the system's tier back to 6 for testing.  I'll put this live on the server unless someone notices a problem with it on tmdevel soon.

Offline Jim

  • TM Collaborator
  • Hero Member
  • *****
  • Posts: 2936
  • Last Login:Today at 05:20:57 pm
Re: gbnmkgr: Milton Keynes Grid Roads
« Reply #12 on: Today at 05:15:16 pm »
FYI, this is on the production server now, and the tmdevel server is moving on to test some other changes I'm working on today.